[REVIEW]: UQTestFuns: A Python3 library of uncertainty quantification (UQ) test functions

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@damar-wicaksono@Nikoleta-v3<!--end-editor-- Reviewers: @Himscipy, @AnjaliSandip Archive: 10.5281/zenodo.10047512

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cc63dbaea06ee71e1effea1dcf204679"><img src="https://joss.theoj.org/papers/cc63dbaea06ee71e1effea1dcf204679/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cc63dbaea06ee71e1effea1dcf204679/status.svg)](https://joss.theoj.org/papers/cc63dbaea06ee71e1effea1dcf204679)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Himscipy & @AnjaliSandip, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Nikoleta-v3 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @AnjaliSandip

📝 Checklist for @Himscipy

editorialbot commented 9 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4734, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

Nikoleta-v3 commented 9 months ago

Hey @damar-wicaksono one of the references is causing a warning: https://github.com/openjournals/joss-reviews/issues/5671#issuecomment-1784607971.

The journal should be "Reliability Engineering & System Safety" could you tweak this line.

damar-wicaksono commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

damar-wicaksono commented 9 months ago

@Nikoleta-v3: Thanks a lot for pointing that out! An automatic metadata import issue; I hope it's fixed now.

danielskatz commented 9 months ago

@editorialbot recommend-accept

editorialbot commented 9 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.7712/120221.8034.19093 is OK
- 10.1007/978-3-319-12385-1_64 is OK
- 10.23919/eucap.2017.7928679 is OK
- 10.3850/978-981-07-2219-7_p321 is OK
- 10.1007/978-1-4899-7547-8_5 is OK
- 10.1007/978-1-4471-6269-8_8 is OK
- 10.1016/j.strusafe.2018.02.005 is OK
- 10.1002/9780470725184 is OK
- 10.1016/j.advengsoft.2019.03.005 is OK
- 10.1016/0951-8320(95)00099-2 is OK
- 10.21105/joss.00097 is OK
- 10.18174/sesmo.18155 is OK
- 10.1002/cnm.2755 is OK
- 10.13182/nse16-37 is OK
- 10.1137/16m1061928 is OK
- 10.1016/j.ress.2023.109211 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 9 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4736, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 9 months ago

@damar-wicaksono - I'm the track editor who will finish the processing of your submission - I'll next proofread the paper

danielskatz commented 9 months ago

@damar-wicaksono - My suggested small changes are in https://github.com/damar-wicaksono/uqtestfuns/pull/315 - please merge this, or let me know your opinions, and we can proceed. (There may be a slight delay on my part today, perhaps until tomorrow.)

damar-wicaksono commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

damar-wicaksono commented 9 months ago

@danielskatz: Thank you very much for handling our submission further, proofreading the paper, and the suggested fixes via the PR! I've merged the PR and the manuscript has been updated.

danielskatz commented 9 months ago

@editorialbot recommend-acceot

editorialbot commented 9 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

danielskatz commented 9 months ago

@editorialbot recommend-accept

editorialbot commented 9 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.7712/120221.8034.19093 is OK
- 10.1007/978-3-319-12385-1_64 is OK
- 10.23919/eucap.2017.7928679 is OK
- 10.3850/978-981-07-2219-7_p321 is OK
- 10.1007/978-1-4899-7547-8_5 is OK
- 10.1007/978-1-4471-6269-8_8 is OK
- 10.1016/j.strusafe.2018.02.005 is OK
- 10.1002/9780470725184 is OK
- 10.1016/j.advengsoft.2019.03.005 is OK
- 10.1016/0951-8320(95)00099-2 is OK
- 10.21105/joss.00097 is OK
- 10.18174/sesmo.18155 is OK
- 10.1002/cnm.2755 is OK
- 10.13182/nse16-37 is OK
- 10.1137/16m1061928 is OK
- 10.1016/j.ress.2023.109211 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 9 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4740, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 9 months ago

@editorialbot accept

editorialbot commented 9 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 9 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wicaksono given-names: Damar orcid: "https://orcid.org/0000-0001-8587-7730" - family-names: Hecht given-names: Michael orcid: "https://orcid.org/0000-0001-9214-8253" contact: - family-names: Wicaksono given-names: Damar orcid: "https://orcid.org/0000-0001-8587-7730" doi: 10.5281/zenodo.10047512 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wicaksono given-names: Damar orcid: "https://orcid.org/0000-0001-8587-7730" - family-names: Hecht given-names: Michael orcid: "https://orcid.org/0000-0001-9214-8253" date-published: 2023-10-30 doi: 10.21105/joss.05671 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5671 title: "UQTestFuns: A Python3 library of uncertainty quantification (UQ) test functions" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05671" volume: 8 title: "UQTestFuns: A Python3 library of uncertainty quantification (UQ) test functions" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 9 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 9 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4741
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05671
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 9 months ago

Congratulations to @damar-wicaksono (Damar Wicaksono) and co-author on your publication!!

And thanks to @Himscipy and @AnjaliSandip for reviewing, and to @Nikoleta-v3 for editing JOSS is dependent on volunteers and we couldn't do this without you

editorialbot commented 9 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05671/status.svg)](https://doi.org/10.21105/joss.05671)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05671">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05671/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05671/status.svg
   :target: https://doi.org/10.21105/joss.05671

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

damar-wicaksono commented 9 months ago

@danielskatz, @Nikoleta-v3: Thank you very much for handling our submission and your feedbacks!

@AnjaliSandip and @Himscipy: Thank you very much for reviewing the paper and the package, and for your comments and feedbacks!

openjournals / joss-reviews