[REVIEW]: Pysersic: A Python package for determining galaxy structural properties via Bayesian inference, accelerated with jax

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@prappleizer@eloisabentivegna<!--end-editor-- Reviewers: @AstroBarker, @JBorrow Archive: 10.5281/zenodo.8335352

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4214c6e588774490458e34630e8052c1"><img src="https://joss.theoj.org/papers/4214c6e588774490458e34630e8052c1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4214c6e588774490458e34630e8052c1/status.svg)](https://joss.theoj.org/papers/4214c6e588774490458e34630e8052c1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@AstroBarker & @JBorrow, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @eloisabentivegna know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @AstroBarker

📝 Checklist for @JBorrow

dfm commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2012.15797 is OK
- 10.3847/1538-4357/ab290a is OK
- 10.1093/mnras/stu2467 is OK
- 10.3847/1538-4357/ac1f21 is OK
- 10.1088/0004-637X/799/2/226 is OK
- 10.1086/340952 is OK
- 10.1093/mnras/stw3039 is OK
- 10.21105/joss.04475 is OK
- 10.48550/arXiv.2111.08721 is OK
- 10.21105/joss.03283 is OK
- 10.1093/mnras/stz1796 is OK
- 10.3847/1538-3881/ac5908 is OK
- 10.5281/zenodo.3509134 is OK
- 10.5281/zenodo.6825092 is OK
- 10.1007/978-1-4842-2677-3_5 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5281/zenodo.7697295 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.21105/joss.00024 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.5281/zenodo.7799772 is OK
- 10.21105/joss.01143 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 11 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4578, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Pasha given-names: Imad orcid: "https://orcid.org/0000-0002-7075-9931" - family-names: Miller given-names: Tim B. orcid: "https://orcid.org/0000-0001-8367-6265" doi: 10.5281/zenodo.8335352 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Pasha given-names: Imad orcid: "https://orcid.org/0000-0002-7075-9931" - family-names: Miller given-names: Tim B. orcid: "https://orcid.org/0000-0001-8367-6265" date-published: 2023-09-15 doi: 10.21105/joss.05703 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5703 title: "pysersic: A Python package for determining galaxy structural properties via Bayesian inference, accelerated with jax" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05703" volume: 8 title: "pysersic: A Python package for determining galaxy structural properties via Bayesian inference, accelerated with jax" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4579
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05703
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 11 months ago

The publication page is giving a 404 which happens when the DOI link gets clicked on too quickly because of PDF caching. But, the PDF was correctly deposited so I'm going to close the issue. If the PDF doesn't display properly by tomorrow, let's check back in.

In the meantime:

Many thanks to @AstroBarker and @JBorrow for reviewing and to @eloisabentivegna for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@prappleizer — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05703/status.svg)](https://doi.org/10.21105/joss.05703)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05703">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05703/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05703/status.svg
   :target: https://doi.org/10.21105/joss.05703

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews