[REVIEW]: CMakePPLang: An object-oriented extension to CMake

[editorialbot]

Submitting author: !--author-handle-->@ryanmrichard<!--end-author-handle-- (Ryan M. Richard) Repository: https://github.com/CMakePP/CMakePPLang/ Branch with paper.md (empty if default branch): joss_paper Version: v1.0.3 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @bast, @tianyi93 Archive: 10.5281/zenodo.8339121

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3cc2bc54aa95fc4c57aed8ccab049cae"><img src="https://joss.theoj.org/papers/3cc2bc54aa95fc4c57aed8ccab049cae/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3cc2bc54aa95fc4c57aed8ccab049cae/status.svg)](https://joss.theoj.org/papers/3cc2bc54aa95fc4c57aed8ccab049cae)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@bast & @tianyi93, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @tianyi93

[diehlpk]

@ryanmrichard The title of the archive is wrong it should read as

CMakePPLang: An object-oriented extension to CMake

but it reads as

CMakePP/CMakePPLang: JOSS Submission

[diehlpk]

@ryanmrichard The authors seem not to match as well.

In the paper, we have

Zachery Crandall 1,2* , Blake Mulnix1,2* , Branden Butler1,2 , Theresa L. Windus 1,2 , and Ryan M. Richard

and in the archive, we have

Ryan Richard; Zachery Crandall; Blake Mulnix; Branden Butler

[ryanmrichard]

Sorry, let me see if I can figure out what I did wrong.

[ryanmrichard]

@editorialbot set 10.5281/zenodo.8339121 as archive

[editorialbot]

I'm sorry @ryanmrichard, I'm afraid I can't do that. That's something only editors are allowed to do.

[ryanmrichard]

@diehlpk I think I fixed it the new DOI is 10.5281/zenodo.8339121 and it's version v1.0.3

[diehlpk]

@editorialbot set v1.0.3 as version

[editorialbot]

Done! version is now v1.0.3

[diehlpk]

@editorialbot set 10.5281/zenodo.8339121 as archive

[editorialbot]

Done! archive is now 10.5281/zenodo.8339121

[diehlpk]

@ryanmrichard thanks. It looks good now.

[diehlpk]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1063/5.0147903 is OK
- 10.1109/MC.2006.20 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4557, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[ryanmrichard]

@editorialbot accept

[editorialbot]

I'm sorry @ryanmrichard, I'm afraid I can't do that. That's something only eics are allowed to do.

[danielskatz]

Hi - I'm the track editor for this submission, and I'll proofread this and get back to you with next steps soon.

[danielskatz]

@ryanmrichard - see https://github.com/CMakePP/CMakePPLang/pull/119 for some small changes in the paper. Please merge this or let me know what you disagree with, then we can continue the process

[ryanmrichard]

@danielskatz it's merged.

[danielskatz]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1063/5.0147903 is OK
- 10.1109/MC.2006.20 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4567, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[danielskatz]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Crandall given-names: Zachery orcid: "https://orcid.org/0000-0003-3161-9378" - family-names: Mulnix given-names: Blake - family-names: Butler given-names: Branden - family-names: Windus given-names: Theresa L. orcid: "https://orcid.org/0000-0001-6065-3167" - family-names: Richard given-names: Ryan M. orcid: "https://orcid.org/0000-0003-4235-5179" contact: - family-names: Richard given-names: Ryan M. orcid: "https://orcid.org/0000-0003-4235-5179" doi: 10.5281/zenodo.8339121 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Crandall given-names: Zachery orcid: "https://orcid.org/0000-0003-3161-9378" - family-names: Mulnix given-names: Blake - family-names: Butler given-names: Branden - family-names: Windus given-names: Theresa L. orcid: "https://orcid.org/0000-0001-6065-3167" - family-names: Richard given-names: Ryan M. orcid: "https://orcid.org/0000-0003-4235-5179" date-published: 2023-09-14 doi: 10.21105/joss.05711 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5711 title: "CMakePPLang: An object-oriented extension to CMake" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05711" volume: 8 title: "CMakePPLang: An object-oriented extension to CMake" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4568
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05711
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[danielskatz]

Congratulations to @ryanmrichard (Ryan M. Richard) and co-authors on your publication!!

And thanks to @bast and @tianyi93 for reviewing, and to @diehlpk for editing! JOSS depends on volunteers like you

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05711/status.svg)](https://doi.org/10.21105/joss.05711)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05711">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05711/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05711/status.svg
   :target: https://doi.org/10.21105/joss.05711

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[twindus]

Thank you!!