openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[REVIEW]: PyDGN: a Python Library for Flexible and Reproducible Research on Deep Learning for Graphs #5713

Closed editorialbot closed 9 months ago

editorialbot commented 11 months ago

Submitting author: !--author-handle-->@diningphil<!--end-author-handle-- (Federico Errica) Repository: https://github.com/diningphil/PyDGN/ Branch with paper.md (empty if default branch): paper Version: v1.5.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @idoby, @sepandhaghighi Archive: 10.5281/zenodo.8396373

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/912b1b0ae8bf2ae2d44aaafc50126b74"><img src="https://joss.theoj.org/papers/912b1b0ae8bf2ae2d44aaafc50126b74/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/912b1b0ae8bf2ae2d44aaafc50126b74/status.svg)](https://joss.theoj.org/papers/912b1b0ae8bf2ae2d44aaafc50126b74)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@idoby & @sepandhaghighi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @idoby

πŸ“ Checklist for @sepandhaghighi

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/72.572108 is OK
- 10.1109/TNN.2008.2005605 is OK
- 10.1109/TNN.2008.2010350 is OK
- 10.1109/MSP.2017.2693418 is OK
- 10.1186/s40649-019-0069-y is OK
- 10.1016/j.neunet.2020.06.006 is OK
- 10.1109/TNNLS.2020.2978386 is OK
- 10.1109/TKDE.2020.2981333 is OK
- 10.1109/MCI.2020.3039072 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 9 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4635, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 9 months ago

@editorialbot accept

editorialbot commented 9 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 9 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Errica given-names: Federico orcid: "https://orcid.org/0000-0001-5181-2904" - family-names: Bacciu given-names: Davide orcid: "https://orcid.org/0000-0001-5213-2468" - family-names: Micheli given-names: Alessio orcid: "https://orcid.org/0000-0001-5764-5238" contact: - family-names: Errica given-names: Federico orcid: "https://orcid.org/0000-0001-5181-2904" doi: 10.5281/zenodo.8396373 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Errica given-names: Federico orcid: "https://orcid.org/0000-0001-5181-2904" - family-names: Bacciu given-names: Davide orcid: "https://orcid.org/0000-0001-5213-2468" - family-names: Micheli given-names: Alessio orcid: "https://orcid.org/0000-0001-5764-5238" date-published: 2023-10-01 doi: 10.21105/joss.05713 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5713 title: "PyDGN: a Python Library for Flexible and Reproducible Research on Deep Learning for Graphs" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05713" volume: 8 title: "PyDGN: a Python Library for Flexible and Reproducible Research on Deep Learning for Graphs" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 9 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 9 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4636
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05713
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

arfon commented 9 months ago

@idoby, @sepandhaghighi – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@diningphil – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 9 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05713/status.svg)](https://doi.org/10.21105/joss.05713)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05713">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05713/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05713/status.svg
   :target: https://doi.org/10.21105/joss.05713

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

diningphil commented 9 months ago

Thank you all for the swift review process! It has been a pleasure and the feeback has been incredibly useful!

Best regards, the authors

idoby commented 9 months ago

Congrats @diningphil