[PRE REVIEW]: FrEDI: An R package for estimating future climate impacts within the United States

[editorialbot]

Submitting author: !--author-handle-->@knoiva-indecon<!--end-author-handle-- () Repository: https://github.com/USEPA/FrEDI/ Branch with paper.md (empty if default branch): joss Version: v3.4.0 Editor: !--editor-->@pdebuyl<!--end-editor-- Reviewers: @tonyewong, @hahsan1 Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a7c382ac5257ff28de021514a4388101"><img src="https://joss.theoj.org/papers/a7c382ac5257ff28de021514a4388101/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a7c382ac5257ff28de021514a4388101/status.svg)](https://joss.theoj.org/papers/a7c382ac5257ff28de021514a4388101)

Author instructions

Thanks for submitting your paper to JOSS @knoiva-indecon. Currently, there isn't a JOSS editor assigned to your paper.

@knoiva-indecon if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=1.71 s (68.4 files/s, 19850.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                       7           2100           1937           7039
R                               40           1129           3830           6157
HTML                            36           1187            104           6147
Rmd                             12            785           1759            644
Markdown                         9            144              0            367
CSS                              4             54             10            231
YAML                             5             20             15            127
XML                              1              0              0            102
TeX                              1              5              0             60
SVG                              1              0              1             11
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                           117           5424           7656          20886
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10584-021-03048-6 is OK

MISSING DOIs

- 10.1163/9789004322714_cclc_2021-0166-513 may be a valid DOI for title: Climate Change and Social Vulnerability in the United States: A Focus on Six Impacts
- 10.5194/egusphere-2023-114 may be a valid DOI for title: Advancing the estimation of future climate impacts within the United States

INVALID DOIs

- https://www.pnas.org/doi/full/10.1073/pnas.1517056113 is INVALID because of 'https://doi.org/' prefix

[editorialbot]

Wordcount for paper.md is 1459

[editorialbot]

Failed to discover a valid open source license

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@knoiva-indecon Please see the notes above about DOIs, and the error when generating the pdf includes: "Author (Erin McDuffie) is missing affiliation" so please add in that affiliation.

Unfortunately our editors are all full so I will add this to the waitlist. Thanks for your patience.

[knoiva-indecon]

@kthyng Thanks for the heads up and update. I fixed the DOIs that I could and added the missing DOIs that were available. Also fixed the missing affiliations. Will the @editorialbot try compiling the PDF again so I can confirm that the issues were fixed?

[kthyng]

@knoiva-indecon Sure I'll run the command by hand and you should have the permission to do so too, if you want to try it or change anything else and rerun.

[kthyng]

@editorialbot generate pdf

[kthyng]

We also do require a valid open source license.

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[knoiva-indecon]

@kthyng Great, thank you! We did/do have an open source license but it wasn't located in our main project directory so I copied it over

[kthyng]

@pdebuyl could you edit this submission?

[kthyng]

@editorialbot invite @pdebuyl as editor

[editorialbot]

Invitation to edit this submission sent!

[pdebuyl]

@editorialbot assign me as editor

[editorialbot]

Assigned! @pdebuyl is now the editor

[pdebuyl]

@hahsan1 would you review this article for the Journal of Open Source Software ?

[pdebuyl]

@tonyewong would you review this article for the Journal of Open Source Software ?

[tonyewong]

Happy to! The semester starts Monday, so things may be bumpy for a week or two...

[hahsan1]

I'd be glad to review the article.

[pdebuyl]

Hello @tonyewong and @hahsan1 thanks a lot to both of you for accepting. I will start the review.

@tonyewong I'll keep reminders for two weeks :-)

[pdebuyl]

@editorialbot assign @tonyewong as reviewer

[editorialbot]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

[pdebuyl]

@editorialbot add @tonyewong as reviewer

[editorialbot]

@tonyewong added to the reviewers list!

[pdebuyl]

@editorialbot add @hahsan1 as reviewer

[editorialbot]

@hahsan1 added to the reviewers list!

[pdebuyl]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5784.