[REVIEW]: SPICY: A python toolbox for meshless assimilation from image velocimetry using radial basis functions

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@mendezVKI@philipcardiff<!--end-editor-- Reviewers: @nolankucd, @MatthewFlamm, @ctdegroot Archive: 10.5281/zenodo.10473329

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400"><img src="https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400/status.svg)](https://joss.theoj.org/papers/ca453152e765cab3bab8a8b57f6aa400)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@nolankucd & @MatthewFlamm & @ctdegroot, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @philipcardiff know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @nolankucd

📝 Checklist for @MatthewFlamm

📝 Checklist for @ctdegroot

editorialbot commented 8 months ago

Done! version is now 1.0.5

philipcardiff commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

philipcardiff commented 8 months ago

FYI, I proposed some minor English edits to the paper at https://github.com/mendezVKI/SPICY_VKI/pull/10

mendezVKI commented 8 months ago

English edits and version tag applied.

philipcardiff commented 8 months ago

@editorialbot generate pdf

philipcardiff commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1088/1361-6501/ac70a9 is OK
- 10.1016/j.cageo.2019.03.007 is OK
- 10.5334/jors.101 is OK
- 10.6084/M9.FIGSHARE.12330608 is OK
- 10.5334/jors.334 is OK
- 10.1017/s0962492914000130 is OK
- 10.1016/j.taml.2020.01.039 is OK
- 10.1007/s00348-016-2133-9 is OK
- 10.1007/s00348-021-03172-0 is OK

MISSING DOIs

- 10.18409/ispiv.v1i1.198 may be a valid DOI for title: Main results of the first Data Assimilation Challenge
- 10.55037/lxlaser.20th.115 may be a valid DOI for title: A RANS approach to the Meshless Computation of Pressure Fields From Image Velocimetry

INVALID DOIs

- None

editorialbot commented 8 months ago

The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.

\mathsemicolon
              ^
unexpected control sequence \mathsemicolon
expecting "%", "\\label", "\\tag", "\\nonumber" or whitespace

editorialbot commented 8 months ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4908, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

philipcardiff commented 8 months ago

The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
\mathsemicolon
              ^
unexpected control sequence \mathsemicolon
expecting "%", "\\label", "\\tag", "\\nonumber" or whitespace

@mendezVKI , can you check if you can resolve this error? Thanks.

kyleniemeyer commented 8 months ago

@mendezVKI the issue looks to be in your paper.bib file, specifically the Heyman2019 reference. Please change the journal field to be just Computers \& Geosciences.

mendezVKI commented 8 months ago

Sorry guys for the late response and thank you for all your help. It should be fixed

kyleniemeyer commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 8 months ago

Hi @mendezVKI, I made a few more changes in this PR: https://github.com/mendezVKI/SPICY_VKI/pull/11

kyleniemeyer commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 8 months ago

@editorialbot accept

editorialbot commented 8 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Sperotto given-names: Pietro orcid: "https://orcid.org/0000-0001-9412-0828" - family-names: Ratz given-names: M. orcid: "https://orcid.org/0009-0008-8491-8367" - family-names: Mendez given-names: M. A. orcid: "https://orcid.org/0000-0002-1115-2187" contact: - family-names: Mendez given-names: M. A. orcid: "https://orcid.org/0000-0002-1115-2187" doi: 10.5281/zenodo.10473329 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Sperotto given-names: Pietro orcid: "https://orcid.org/0000-0001-9412-0828" - family-names: Ratz given-names: M. orcid: "https://orcid.org/0009-0008-8491-8367" - family-names: Mendez given-names: M. A. orcid: "https://orcid.org/0000-0002-1115-2187" date-published: 2024-01-16 doi: 10.21105/joss.05749 issn: 2475-9066 issue: 93 journal: Journal of Open Source Software publisher: name: Open Journals start: 5749 title: "SPICY: a Python toolbox for meshless assimilation from image velocimetry using radial basis functions" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05749" volume: 9 title: "SPICY: a Python toolbox for meshless assimilation from image velocimetry using radial basis functions" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4916
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05749
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 8 months ago

Congratulations @mendezVKI on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already.

Many thanks to @nolankucd, @MatthewFlamm, and @ctdegroot for reviewing this, and @philipcardiff for editing.

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05749/status.svg)](https://doi.org/10.21105/joss.05749)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05749">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05749/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05749/status.svg
   :target: https://doi.org/10.21105/joss.05749

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews