search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[REVIEW]: einprot: flexible, easy-to-use, reproducible workflows for statistical analysis of quantitative proteomics data #5750

Closed editorialbot closed 12 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@csoneson<!--end-author-handle-- (Charlotte Soneson) Repository: https://github.com/fmicompbio/einprot Branch with paper.md (empty if default branch): joss Version: v0.7.7 Editor: !--editor-->@fboehm<!--end-editor-- Reviewers: @AnthonyOfSeattle, @ByrumLab Archive: 10.5281/zenodo.8298657

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/200654a73547392769c222793680a83a"><img src="https://joss.theoj.org/papers/200654a73547392769c222793680a83a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/200654a73547392769c222793680a83a/status.svg)](https://joss.theoj.org/papers/200654a73547392769c222793680a83a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@AnthonyOfSeattle & @ByrumLab, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fboehm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ByrumLab

📝 Checklist for @AnthonyOfSeattle

csoneson commented 12 months ago

Thank you @Kevin-Mattheus-Moerman! I get a 404 on the DOI link (https://doi.org/10.21105/joss.05750), both directly and from the list of papers on the website. Should it resolve by itself, or do you think there's an issue? Thanks!

Kevin-Mattheus-Moerman commented 12 months ago

@csoneson I closed this issue after I noticed the DOI resolving. Sometimes one needs to refresh the page. (and in some cases in takes longer for me on Firefox). If this remains an issue we can investigate a bit more. It does resolve still/again for me now.

csoneson commented 12 months ago

Interesting - yes, I guess a cache issue or something (I refreshed several times, and tried in different windows). In an incognito session, it resolves for me as well 🙂 Sorry for the noise, and thanks again!