search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: OpenFEPOPS: A Python implementation of the FEPOPS molecular similarity technique #5763

Closed editorialbot closed 11 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@stevenshave<!--end-author-handle-- (Steven Shave) Repository: https://github.com/JustinYKC/FEPOPS Branch with paper.md (empty if default branch): Version: v1.8.2 Editor: !--editor-->@richardjgowers<!--end-editor-- Reviewers: @hannahbaumann, @exs-cbouy Archive: 10.6084/m9.figshare.24477184.v1

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8"><img src="https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8/status.svg)](https://joss.theoj.org/papers/b4ab6027d3eca941ca7b3ffc70e636d8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@hannahbaumann & @exs-cbouy, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @richardjgowers know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @exs-cbouy

📝 Checklist for @hannahbaumann

stevenshave commented 11 months ago

I see that the paper is now live!

I have added a CITATION.cff to the repository and GitHub has picked it up, enabling the "Cite this repository" link/button.

Again, my thanks to the reviewers for the in depth reviews which forced me to rethink many things and also become more proficient at github, and to the editors for making this such a good experience. We will be looking in the future to improve the speed of the technique with some compiled rust to replace performance critical sections and increase the utility of OpenFEPOPS.

Best wishes, Steve

Kevin-Mattheus-Moerman commented 11 months ago

Congratulations on this JOSS publication @stevenshave

Thanks for editing @richardjgowers

And a special thanks to the reviewers: @hannahbaumann, @exs-cbouy

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05763/status.svg)](https://doi.org/10.21105/joss.05763)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05763">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05763/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05763/status.svg
   :target: https://doi.org/10.21105/joss.05763

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: