search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Tide Model Driver for MATLAB #5770

Closed editorialbot closed 11 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@chadagreene<!--end-author-handle-- (Chad Greene) Repository: https://github.com/chadagreene/Tide-Model-Driver Branch with paper.md (empty if default branch): Version: 3.0.0 Editor: !--editor-->@kthyng<!--end-editor-- Reviewers: @adamdanz, @lnferris Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/228e6fd7edc42dc6d443ce60feef8c6d"><img src="https://joss.theoj.org/papers/228e6fd7edc42dc6d443ce60feef8c6d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/228e6fd7edc42dc6d443ce60feef8c6d/status.svg)](https://joss.theoj.org/papers/228e6fd7edc42dc6d443ce60feef8c6d)

Author instructions

Thanks for submitting your paper to JOSS @chadagreene. Currently, there isn't a JOSS editor assigned to your paper.

@chadagreene if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.58 s (123.7 files/s, 27422.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          38           1208           3058           3884
Markdown                        17            576              0           2266
HTML                            13            636           2294           1879
TeX                              1              9              0             74
XML                              2              7             13             34
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            72           2437           5369           8155
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 504

editorialbot commented 1 year ago

Failed to discover a Statement of need section in paper

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18739/A21Z41V08 is OK

MISSING DOIs

- 10.1175/jtech-1687.1 may be a valid DOI for title: Detiding ADCP data in a highly variable shelf sea: the Celtic Sea
- 10.1175/1520-0485(1980)010<1399:trotco>2.0.co;2 may be a valid DOI for title: Topographic rectification of tidal currents on the sides of Georges Bank
- 10.1016/s0967-0637(98)00070-3 may be a valid DOI for title: Abyssal recipes II: Energetics of tidal and wind mixing
- 10.1029/2003gl019003 may be a valid DOI for title: A barotropic inverse tidal model for the Arctic Ocean
- 10.1002/2016rg000546 may be a valid DOI for title: Ocean tide influences on the Antarctic and Greenland ice sheets
- 10.1007/s001900000101 may be a valid DOI for title: Ocean tides from T/P, ERS-1, and GEOSAT altimetry

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

chadagreene commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

chadagreene commented 1 year ago

Potential reviewers:

kthyng commented 1 year ago

Hi @chadagreene! Sorry my delay saying anything. We're full up at the moment for editors, so I will add you to the waitlist for now. Thanks for your patience.

kthyng commented 1 year ago

Hi @chadagreene and sorry for the wait.

I want to state that @chadagreene and I are co-authors on a paper from 2016 and paper from 2019. The work done for this latter paper was done in January 2019 so I am ok to edit this submission in terms of a potential conflict of interest, as per our policy.

kthyng commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @kthyng is now the editor

kthyng commented 1 year ago

I will start up this process by early next week.

kthyng commented 1 year ago

Hi @kakearney and @adamdanz! Are you interested in reviewing this submission for the Journal for Open Source Software (JOSS)? Our reviews are done openly in a github issue and are checklist driven — you can get more information here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html# I would ask that you start your review in the next 3 weeks with the intention of having it finished within 4-6 weeks, given that the process is often iterative with the submitting author(s).

Thanks for your consideration!

adamdanz commented 1 year ago

@kthyng , I'd be happy to be a reviewer.

kakearney commented 1 year ago

I'd be happy to review this, though I would not be able to start until Nov. at the earliest, and will likely be on the 6-week end of the timetable (currently have 3 other journal reviews on my plate and will be attending a conference the week of Oct 23). Let me know if this works for everyone.

-Kelly

On Mon, Oct 9, 2023 at 2:53 PM Adam Danz @.***> wrote:

@kthyng https://github.com/kthyng , I'd be happy to be a reviewer.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5770#issuecomment-1753933450, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGIMNEZYAYJ2IX5V4JQCLTX6RW6NAVCNFSM6AAAAAA3VV2OVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTHEZTGNBVGA . You are receiving this because you were mentioned.Message ID: @.***>

kthyng commented 1 year ago

@kakearney That sounds really busy. I'll reach out to another potential reviewer or two and get back to you in the next few weeks if we haven't found someone in the meantime. Thanks for your response!

kthyng commented 1 year ago

Hi @mhalvers! Are you interested in reviewing this submission for the Journal for Open Source Software (JOSS)? Our reviews are done openly in a github issue and are checklist driven — you can get more information here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html# I would ask that you start your review in the next 3 weeks with the intention of having it finished within 4-6 weeks, given that the process is often iterative with the submitting author(s).

Thanks for your consideration!

kthyng commented 1 year ago

@editorialbot add @adamdanz as reviewer

editorialbot commented 1 year ago

@adamdanz added to the reviewers list!

mhalvers commented 1 year ago

@kthyng I'm flattered that you thought of me! I haven't coded in Matlab or worked in oceanography since 2020 🙁. Out of curiosity I attempted to open Matlab on my computer and it crashed immediately. I'm not sure how to fix the issue, and I also don't have access to newer versions. In light of all I have to decline.

kthyng commented 1 year ago

@mhalvers Totally understand! Thanks for your response.

kthyng commented 1 year ago

I found someone on Matlab's community site to ask to review but not sure of their github handle. Waiting to hear back.

kthyng commented 1 year ago

@jklymak do you still use Matlab? If so would you be interested in reviewing this submission to the Journal for Open Source Software? Our reviews are done openly in a github issue and are checklist driven — you can get more information here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html# I would ask that you start your review in the next 3 weeks with the intention of having it finished within 4-6 weeks, given that the process is often iterative with the submitting author(s).

Thanks for your consideration!

mhalvers commented 1 year ago

@kthyng You could always try Rich Pawlowicz - it's quite likely he and his group still use Matlab.

kthyng commented 1 year ago

@mhalvers Yeah that is a good idea but I couldn't find a github account for him which would make jumping into a JOSS review pretty difficult.

jklymak commented 1 year ago

apologies - I've not used Matlab much for 10 years or so and I have a bunch of reviews backlogged in addition to editing for JPO. I'm not sure who to ask - few Matlab people use Github!

kthyng commented 1 year ago

Thanks @jklymak, agreed.

@dgwyther, @wschwanghart: Are either of you interested in reviewing this submission for the Journal for Open Source Software (JOSS)? Our reviews are done openly in a github issue and are checklist driven — you can get more information here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html# I would ask that you start your review in the next 3 weeks with the intention of having it finished within 4-6 weeks, given that the process is often iterative with the submitting author(s).

Thanks for your consideration!

mhalvers commented 1 year ago

@kthyng The owner of this repo might be a suitable reviewer: https://github.com/lnferris/ocean_data_tools. Found by a simple searh on github for matlab oceanography

kthyng commented 1 year ago

Hey I remember that trash panda from when the submission came through JOSS. Good idea.

@lnferris would you be interested in reviewing this submission to the Journal for Open Source Software? Our reviews are done openly in a github issue and are checklist driven — you can get more information here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html# I would ask that you start your review in the next 3 weeks with the intention of having it finished within 4-6 weeks, given that the process is often iterative with the submitting author(s).

Thanks for your consideration!

lnferris commented 11 months ago

Yes I will review.

kthyng commented 11 months ago

Ok let's go with @lnferris. I realize that @kakearney's time frame has reached us but still sounds like a pretty busy schedule plus it's nice to get a more unrelated reviewer to come in. Thanks everyone.

kthyng commented 11 months ago

@editorialbot add @lnferris as reviewer

editorialbot commented 11 months ago

@lnferris added to the reviewers list!

kthyng commented 11 months ago

@editorialbot start review

editorialbot commented 11 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6018.

dgwyther commented 11 months ago

Apologies on the slow reply, I was on leave last week. I am happy to review if you need a 3rd reviewer for some reason. Cheers, Dave

kthyng commented 11 months ago

@dgwyther Thank you! Yeah there isn't a good way in github to say you're out of office...

If you're interested you can register as a reviewer for JOSS here so that you're discoverable for next time there is a relevant submission: https://reviewers.joss.theoj.org/