[REVIEW]: JetNet: A Python package for accessing open datasets and benchmarking machine learning methods in high energy physics

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@rkansal47@matthewfeickert<!--end-editor-- Reviewers: @smsharma, @saforem2 Archive: 10.5281/zenodo.10044601

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/09532bcc705c4ad7f1f8ba57845e8e50"><img src="https://joss.theoj.org/papers/09532bcc705c4ad7f1f8ba57845e8e50/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/09532bcc705c4ad7f1f8ba57845e8e50/status.svg)](https://joss.theoj.org/papers/09532bcc705c4ad7f1f8ba57845e8e50)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@smsharma, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @matthewfeickert know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @smsharma

📝 Checklist for @jpata

📝 Checklist for @saforem2

rkansal47 commented 1 year ago

Thanks @matthewfeickert! We should be able to incorporate your suggestions next week.

matthewfeickert commented 1 year ago

Sounds good @rkansal47. As a heads up I will be traveling without cell phone or internet access next week, so if you have questions or if anything urgent comes up between now and 2023-10-21 please tag @kyleniemeyer in this Issue (Physics and Engineering Editor-in-chief) and ask him to help out.

matthewfeickert commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21468/SciPostPhys.15.4.130 is OK
- 10.1038/s41597-021-01109-0 is OK
- 10.1140/epjc/s10052-023-11633-5 is OK
- 10.5281/zenodo.6975118 is OK
- 10.1103/PhysRevD.107.076017 is OK
- 10.1088/1361-6633/ac36b9 is OK
- 10.5281/zenodo.2603256 is OK
- 10.21468/SciPostPhys.7.1.014 is OK
- 10.5281/zenodo.3164691 is OK
- 10.1103/PhysRevD.101.034009 is OK
- 10.1103/PhysRevD.108.036025 is OK
- 10.1103/PhysRevLett.123.041801 is OK
- 10.25495/7GXK-RD71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

matthewfeickert commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

matthewfeickert commented 1 year ago

@rkansal47 Things look good and we can move forward with the last few steps! Can you please now make a new release of JetNet and then also deposit it in an archive with a DOI, as described in https://github.com/openjournals/joss-reviews/issues/5789#issuecomment-1761074857. If you have any questions on this step please let me know.

When you get the Zenodo archive for this release please also ensure that:

the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
the license listed for the archive is the same as the software license.

rkansal47 commented 1 year ago

Hi @matthewfeickert, I have made a new release https://github.com/jet-net/JetNet/releases/tag/v0.2.4 and this is its DOI: https://doi.org/10.5281/zenodo.10044601. We also added @zichunhao as an author to recognize his early contributions to the library.

matthewfeickert commented 1 year ago

We also added @zichunhao as an author to recognize his early contributions to the library.

@rkansal47 that's fine, but the authors should match on the paper and the release, so can you please update the paper to reflect this?

matthewfeickert commented 1 year ago

@editorialbot set v0.2.4 as version

editorialbot commented 1 year ago

Done! version is now v0.2.4

matthewfeickert commented 1 year ago

@editorialbot set 10.5281/zenodo.10044601 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.10044601

rkansal47 commented 1 year ago

We also added @zichunhao as an author to recognize his early contributions to the library.

@rkansal47 that's fine, but the authors should match on the paper and the release, so can you please update the paper to reflect this?

Yup, I believe the paper and release are both updated with this.

matthewfeickert commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21468/SciPostPhys.15.4.130 is OK
- 10.1038/s41597-021-01109-0 is OK
- 10.1140/epjc/s10052-023-11633-5 is OK
- 10.5281/zenodo.6975118 is OK
- 10.1103/PhysRevD.107.076017 is OK
- 10.1088/1361-6633/ac36b9 is OK
- 10.5281/zenodo.2603256 is OK
- 10.21468/SciPostPhys.7.1.014 is OK
- 10.5281/zenodo.3164691 is OK
- 10.1103/PhysRevD.101.034009 is OK
- 10.1103/PhysRevD.108.036025 is OK
- 10.1103/PhysRevLett.123.041801 is OK
- 10.25495/7GXK-RD71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

matthewfeickert commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

matthewfeickert commented 1 year ago

@rkansal47 please update the metadata for the 10.5281/zenodo.10044601 archive so that the title matches the paper title of "JetNet: A Python package for accessing open datasets and benchmarking machine learning methods in high energy physics". That's the final thing on https://github.com/openjournals/joss-reviews/issues/5789#issuecomment-1752319309, so I'll go ahead and recommend acceptacne while you take care of that! :+1:

matthewfeickert commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21468/SciPostPhys.15.4.130 is OK
- 10.1038/s41597-021-01109-0 is OK
- 10.1140/epjc/s10052-023-11633-5 is OK
- 10.5281/zenodo.6975118 is OK
- 10.1103/PhysRevD.107.076017 is OK
- 10.1088/1361-6633/ac36b9 is OK
- 10.5281/zenodo.2603256 is OK
- 10.21468/SciPostPhys.7.1.014 is OK
- 10.5281/zenodo.3164691 is OK
- 10.1103/PhysRevD.101.034009 is OK
- 10.1103/PhysRevD.108.036025 is OK
- 10.1103/PhysRevLett.123.041801 is OK
- 10.25495/7GXK-RD71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4728, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

rkansal47 commented 1 year ago

@rkansal47 please update the metadata for the 10.5281/zenodo.10044601 archive so that the title matches the paper title of "JetNet: A Python package for accessing open datasets and benchmarking machine learning methods in high energy physics". That's the final thing on #5789 (comment), so I'll go ahead and recommend acceptacne while you take care of that! 👍

Done.

kyleniemeyer commented 1 year ago

Hi @rkansal47, I'm doing some final checks before publishing. Can you merge the PR I made with a small edit to the paper? https://github.com/jet-net/JetNet/pull/61

kyleniemeyer commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Kansal given-names: Raghav orcid: "https://orcid.org/0000-0003-2445-1060" - family-names: Pareja given-names: Carlos orcid: "https://orcid.org/0000-0002-9022-2349" - family-names: Hao given-names: Zichun orcid: "https://orcid.org/0000-0002-5624-4907" - family-names: Duarte given-names: Javier orcid: "https://orcid.org/0000-0002-5076-7096" contact: - family-names: Kansal given-names: Raghav orcid: "https://orcid.org/0000-0003-2445-1060" doi: 10.5281/zenodo.10044601 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Kansal given-names: Raghav orcid: "https://orcid.org/0000-0003-2445-1060" - family-names: Pareja given-names: Carlos orcid: "https://orcid.org/0000-0002-9022-2349" - family-names: Hao given-names: Zichun orcid: "https://orcid.org/0000-0002-5624-4907" - family-names: Duarte given-names: Javier orcid: "https://orcid.org/0000-0002-5076-7096" date-published: 2023-10-30 doi: 10.21105/joss.05789 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5789 title: "JetNet: A Python package for accessing open datasets and benchmarking machine learning methods in high energy physics" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05789" volume: 8 title: "JetNet: A Python package for accessing open datasets and benchmarking machine learning methods in high energy physics" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4737
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05789
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

matthewfeickert commented 1 year ago

Congratulations @rkansal47 on the nice publication! Thank you for your reviews @smsharma and @saforem2!

kyleniemeyer commented 1 year ago

Congratulations @rkansal47 on your article's publication in JOSS!

Many thanks to @smsharma and @saforem2 for reviewing, and @matthewfeickert for editing.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05789/status.svg)](https://doi.org/10.21105/joss.05789)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05789">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05789/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05789/status.svg
   :target: https://doi.org/10.21105/joss.05789

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews