openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: The vtreat R package: a statistically sound data processor for predictive modeling #579

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @JohnMount (John Mount) Repository: https://github.com/WinVector/vtreat/ Version: 1.0.2 Editor: @karthik Reviewer: @earino

Author instructions

Thanks for submitting your paper to JOSS @JohnMount. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@JohnMount if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @danielskatz it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #579 with the following error:

Can't find any papers to compile :-(

arfon commented 6 years ago

👋 @danielskatz - the submitting author suggested you as the handling editor.

arfon commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #579 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 16 0 16 0 0 77 0 --:--:-- --:--:-- --:--:-- 77 Error reading bibliography ./paper.bib (line 25, column 2): unexpected "@" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

JohnMount commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

danielskatz commented 6 years ago

hmmm. I don't have any experience with R, and I'm much more of a computer scientist and computational scientist than a data scientist. I really don't think I'm the right person to edit this one.

JohnMount commented 6 years ago

Perhaps one or more of @milesmcbain @earino @Fusionet24 @nhejazi @trallard could review? I was just looking through for people with a combination of interests in R, statistics, data science, and data preparation.

JohnMount commented 6 years ago

@danielskatz sorry for the trouble. Should I suggest another editor or is there some other way to go forward? I just found some R people from the review list.

danielskatz commented 6 years ago

If you can suggest another editor, I certainly would appreciate it :)

JohnMount commented 6 years ago

Perhaps Thomas J. Leeper (@leeper). A social scientist (they know their statistics) and CRAN contributor.

JohnMount commented 6 years ago

And if that isn't appropriate how about Karthik Ram (@karthik), for data science?

JohnMount commented 6 years ago

@whedon commands

whedon commented 6 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf
JohnMount commented 6 years ago

@arfon thank for helping with this. I assume that I do not assign editors, but have put in some suggestions. Please let me know if I need to do something.

earino commented 6 years ago

Hi am I needed for something?

karthik commented 6 years ago

I’m happy to handle as editors. Ed: would you like to review?

karthik commented 6 years ago

@whedon assign karthik as editor

whedon commented 6 years ago

OK, the editor is karthik

nhejazi commented 6 years ago

Looks like @earino has already stepped up, but also happy to review should it become necessary.

earino commented 6 years ago

LOL hang on, let's make sure I have any idea what I'm doing. I mostly just asked if I was needed :-) what are the requirements for excellent reviewing?

On Sun, Feb 11, 2018, 7:43 AM Nima Hejazi notifications@github.com wrote:

Looks like @earino https://github.com/earino has already stepped up, but also happy to review should it become necessary.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/579#issuecomment-364727244, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMukg6gWq57TR7Y_NlOt4ABCZKOP5eks5tTov_gaJpZM4SBKb- .

earino commented 6 years ago

But instinctively this sounds like something I would enjoy.

On Sun, Feb 11, 2018, 3:27 PM Eduardo Arino de la Rubia earino@gmail.com wrote:

LOL hang on, let's make sure I have any idea what I'm doing. I mostly just asked if I was needed :-) what are the requirements for excellent reviewing?

On Sun, Feb 11, 2018, 7:43 AM Nima Hejazi notifications@github.com wrote:

Looks like @earino https://github.com/earino has already stepped up, but also happy to review should it become necessary.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/579#issuecomment-364727244, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMukg6gWq57TR7Y_NlOt4ABCZKOP5eks5tTov_gaJpZM4SBKb- .

JohnMount commented 6 years ago

@whedon set 10.5281/zenodo.1173318 as archive

whedon commented 6 years ago

I'm sorry @JohnMount, I'm afraid I can't do that. That's something only editors are allowed to do.

JohnMount commented 6 years ago

Sorry, didn't mean to overstep.

arfon commented 6 years ago

Sorry, didn't mean to overstep.

:-) no problem. There are some things only editors can do and we generally do this towards the end of the review process...

karthik commented 6 years ago

@whedon assign @earino as reviewer

whedon commented 6 years ago

OK, the reviewer is @earino

karthik commented 6 years ago

@earino I’m just about to go offline for a week but once a new review issue is created, you’ll have instructions on what to do. I can also help if you run into problems.

karthik commented 6 years ago

@whedon start review

whedon commented 6 years ago

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas
karthik commented 6 years ago

@whedon start review magic-word=bananas

whedon commented 6 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/584. Feel free to close this issue now!