search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[REVIEW]: pyheartlib: A Python package for processing electrocardiogram signals #5792

Closed editorialbot closed 6 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@devnums<!--end-author-handle-- (Sadegh Mohammadi) Repository: https://github.com/devnums/pyheartlib Branch with paper.md (empty if default branch): paper Version: 1.22.0 Editor: !--editor-->@britta-wstnr<!--end-editor-- Reviewers: @cudmore, @LegrandNico, @Bsingstad Archive: 10.5281/zenodo.10730468

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8"><img src="https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8/status.svg)](https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@cudmore & @LegrandNico, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @britta-wstnr know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @cudmore

šŸ“ Checklist for @Bsingstad

šŸ“ Checklist for @LegrandNico

editorialbot commented 6 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/51.932724 is OK
- 10.1161/01.CIR.101.23.e215 is OK
- 10.13026/9njx-6322 is OK
- 10.13026/zzpx-h016 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.05411 is OK
- 10.1109/TBME.1985.325532 is OK
- 10.1109/CIC.2002.1166717 is OK

MISSING DOIs

- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- 10.1163/2214-8647_dnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None
editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

britta-wstnr commented 6 months ago

@editorialbot set 10.5281/zenodo.10730468 as archive

editorialbot commented 6 months ago

Done! archive is now 10.5281/zenodo.10730468

britta-wstnr commented 6 months ago

@editorialbot set 1.22.0 as version

editorialbot commented 6 months ago

Done! version is now 1.22.0

britta-wstnr commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

britta-wstnr commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/51.932724 is OK
- 10.1161/01.CIR.101.23.e215 is OK
- 10.13026/9njx-6322 is OK
- 10.13026/zzpx-h016 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.05411 is OK
- 10.1109/TBME.1985.325532 is OK
- 10.1109/CIC.2002.1166717 is OK

MISSING DOIs

- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- 10.1163/2214-8647_dnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None
britta-wstnr commented 6 months ago

Okay! Everything in order here as far as I can see šŸŽ‰ @devnums I will hand this off to our EiC now for acceptance.

A big thank you to the reviewers @cudmore @LegrandNico and @Bsingstad - we deeply appreciate your review work for JOSS! šŸ™ šŸŒ·

A quick note to the EiC taking this over: I checked the two missing DOIs that the editorialbot flags and both Keras and Tensorflow are cited as the homepages for the softwares request as far as I can see.

britta-wstnr commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 6 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/51.932724 is OK
- 10.1161/01.CIR.101.23.e215 is OK
- 10.13026/9njx-6322 is OK
- 10.13026/zzpx-h016 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.05411 is OK
- 10.1109/TBME.1985.325532 is OK
- 10.1109/CIC.2002.1166717 is OK

MISSING DOIs

- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- 10.1163/2214-8647_dnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None
editorialbot commented 6 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5104, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 6 months ago

šŸ‘‹ @devnums - I've now proofread this as the track editor, and it all looks fine

danielskatz commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Mohammadi given-names: Sadegh orcid: "https://orcid.org/0000-0001-9763-4963" doi: 10.5281/zenodo.10730468 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Mohammadi given-names: Sadegh orcid: "https://orcid.org/0000-0001-9763-4963" date-published: 2024-03-09 doi: 10.21105/joss.05792 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 5792 title: "Pyheartlib: A Python package for processing electrocardiogram signals" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05792" volume: 9 title: "Pyheartlib: A Python package for processing electrocardiogram signals" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 6 months ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5111
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05792
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

danielskatz commented 6 months ago

Congratulations to @devnums (Sadegh Mohammadi) on your publication!!

And thanks to @cudmore, @LegrandNico, and @Bsingstad for reviewing, and to @britta-wstnr for editing! JOSS depends on volunteers and we couldn't do this without you

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05792/status.svg)](https://doi.org/10.21105/joss.05792)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05792">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05792/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05792/status.svg
   :target: https://doi.org/10.21105/joss.05792

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

devnums commented 6 months ago

Great, thank you all šŸ™