search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: LIBSsa: an open source software for analyzing LIBS spectra #5805

Closed editorialbot closed 11 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@kstenio<!--end-author-handle-- (Kleydson Stenio) Repository: https://github.com/kstenio/libssa/ Branch with paper.md (empty if default branch): joss Version: v2.1.0 Editor: !--editor-->@csoneson<!--end-editor-- Reviewers: @domna, @alberto-battistel, @Tillsten Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ace86f6d3f6f628f007814e026d0232b"><img src="https://joss.theoj.org/papers/ace86f6d3f6f628f007814e026d0232b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ace86f6d3f6f628f007814e026d0232b/status.svg)](https://joss.theoj.org/papers/ace86f6d3f6f628f007814e026d0232b)

Author instructions

Thanks for submitting your paper to JOSS @kstenio. Currently, there isn't a JOSS editor assigned to your paper.

@kstenio if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (301.8 files/s, 72386.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           9            273           1211           2687
Qt                               1              0              0           2379
SVG                             15              0              0            251
TeX                              1             23              0            227
Markdown                         2             61              0            192
HTML                             1              2              0             83
JSON                             1              0              0             23
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            31            360           1215           5860
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 900

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.talanta.2011.04.001 may be a valid DOI for title: Evaluation of laser induced breakdown spectroscopy for multielemental determination in soils under sewage sludge application
- 10.1016/j.geoderma.2015.09.018 may be a valid DOI for title: Laser-induced breakdown spectroscopy to determine soil texture: A fast analytical technique
- 10.1016/j.microc.2018.05.008 may be a valid DOI for title: Nutritional characterization of healthy and Aphelenchoides besseyi infected soybean leaves by laser-induced breakdown spectroscopy (LIBS)
- 10.1007/s12161-017-1086-9 may be a valid DOI for title: Direct determination of Ca, K and Mg in cassava flour samples by laser-induced breakdown spectroscopy (LIBS)
- 10.1039/c8ja00076j may be a valid DOI for title: LIBS analyses for industrial applications–an overview of developments from 2014 to 2018
- 10.1016/j.trac.2018.08.003 may be a valid DOI for title: Laser-induced breakdown spectroscopy (LIBS) applications in the chemical analysis of waste electrical and electronic equipment (WEEE)
- 10.1039/c5ay01615k may be a valid DOI for title: Phosphorus quantification in fertilizers using laser induced breakdown spectroscopy (LIBS): a methodology of analysis to correct physical matrix effects
- 10.1364/ao.53.002170 may be a valid DOI for title: Quantification of total carbon in soil using laser-induced breakdown spectroscopy: a method to correct interference lines
- 10.1039/d0ay02008g may be a valid DOI for title: Total phosphorus determination in eutrophic tropical river sediments by laser-induced breakdown spectroscopy techniques
- 10.1039/d2ay01424f may be a valid DOI for title: Carbon quantification in soils with different textures using laser-induced breakdown spectroscopy: spectral interference correction and use of a 3D plane model
- 10.1039/c6ja00224b may be a valid DOI for title: Twelve different types of data normalization for the proposition of classification, univariate and multivariate regression models for the direct analyses of alloys by laser-induced breakdown spectroscopy (LIBS)
- 10.21236/ada409023 may be a valid DOI for title: Distance metrics and band selection in hyperspectral processing with applications to material identification and spectral libraries
- 10.1016/j.jesp.2013.03.013 may be a valid DOI for title: Detecting outliers: Do not use standard deviation around the mean, use absolute deviation around the median
- 10.25080/majora-92bf1922-00a may be a valid DOI for title: Data structures for statistical computing in python

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@kstenio thanks for this submission. I am the AEiC on this track and here to help with the initial steps. I will be looking for a handling editor. For the moment can you check those potentially missing DOIs? :point_up: You can amend your .bib file and rerun (in a clean comment here): @editorialbot generate pdf

Followed by: @editorialbot check references

Thanks.

kstenio commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kstenio commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.talanta.2011.04.001 is OK
- 10.1016/j.geoderma.2015.09.018 is OK
- 10.1016/j.microc.2018.05.008 is OK
- 10.1007/s12161-017-1086-9 is OK
- 10.1039/C8JA00076J is OK
- 10.1016/j.trac.2018.08.003 is OK
- 10.1039/C5AY01615K is OK
- 10.1364/AO.53.002170 is OK
- 10.1039/D0AY02008G is OK
- 10.1039/D2AY01424F is OK
- 10.1039/C6JA00224B is OK
- 10.1039/D1AY02101J is OK
- 10.1109/TGRS.2004.830549 is OK
- 10.1016/j.jesp.2013.03.013 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- None

INVALID DOIs

- None
kstenio commented 1 year ago

Hello @Kevin-Mattheus-Moerman, thank you very much for the support in this review. I've already added the missing DOIs in the paper.bib file. Regarding potential reviewers, I've checked the recommended list and found some of them with repositories (and/or forks) with subject aligned to mine (spectroscopy): tillsten, ivergara and ksunden.

Kevin-Mattheus-Moerman commented 12 months ago

@editorialbot invite @csoneson as editor

editorialbot commented 12 months ago

Invitation to edit this submission sent!

csoneson commented 12 months ago

@editorialbot assign @csoneson as editor

editorialbot commented 12 months ago

Assigned! @csoneson is now the editor

csoneson commented 12 months ago

@kstenio - I will handle your submission, and will start by recruiting two suitable reviewers. Thanks for your suggestions above!

csoneson commented 12 months ago

👋🏻 @tillsten, @ivergara, @ksunden - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra https://github.com/openjournals/joss-reviews/issues/5805

Thanks in advance!

csoneson commented 11 months ago

Ping @Tillsten, @ivergara, @ksunden - would you be willing to review this submission for JOSS?

👋🏻 @Tillsten, @ivergara, @ksunden - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra

5805

Thanks in advance!

csoneson commented 11 months ago

👋🏻 @jwuttke, @tpeulen, @alberto-battistel - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra https://github.com/openjournals/joss-reviews/issues/5805

Thanks in advance!

csoneson commented 11 months ago

👋🏻 @adrien-matta, @domna, @jwuttke, @tpeulen, @alberto-battistel - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra https://github.com/openjournals/joss-reviews/issues/5805

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

domna commented 11 months ago

Yes, I can do a review.

csoneson commented 11 months ago

Thank you @domna! As soon as we have secured one more reviewer, I will open the review issue.

csoneson commented 11 months ago

@editorialbot add @domna as reviewer

editorialbot commented 11 months ago

@domna added to the reviewers list!

kstenio commented 11 months ago

Hi @domna, thank you very much for your availability to review this paper/software! And @csoneson, thank you very much for all the support so far! I hope we can find another reviewer soon. Best wishes to everyone.

Tillsten commented 11 months ago

Is there example data given? If so, I can try do a review

kstenio commented 11 months ago

Hi @Tillsten, thank you very much for your availability! Yes, I have some spectra/example data I can provide in order to test software usability. If it is OK for @csoneson, I can create a short lived branch (based on current "joss" branch) with compressed files.

csoneson commented 11 months ago

@kstenio - sure, that should work (unless the files are too big for GitHub). In general though, it would be good to have some small example data provided with the package, or somewhere else easily accessible, so that a new user could quickly test e.g. that their installation works and see what the output files would look like.

kstenio commented 11 months ago

Great @csoneson. I've created a new branch, joss_sample_data, and inside the folder data you will able to find the compressed (7z) sample spectra and some instructions.

Regarding the small data, I see no problems in including a minor sample set in the official repository.

alberto-battistel commented 11 months ago

👋🏻 @adrien-matta, @domna, @jwuttke, @tpeulen, @alberto-battistel - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra #5805

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

I can review it too.

csoneson commented 11 months ago

Thanks @alberto-battistel and @Tillsten! I will assign you both and start the review.

csoneson commented 11 months ago

@editorialbot add @alberto-battistel as reviewer

editorialbot commented 11 months ago

@alberto-battistel added to the reviewers list!

csoneson commented 11 months ago

@editorialbot add @Tillsten as reviewer

editorialbot commented 11 months ago

@Tillsten added to the reviewers list!

csoneson commented 11 months ago

@editorialbot start review

editorialbot commented 11 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5961.

adrien-matta commented 11 months ago

Dear Charlotte,

Thanks a lot for this opportunity. Unfortunately I am not available at this time to provide a review.

Best regards, Adrien.

• Dr Adrien Matta • Chargé de Recherche CNRS • [ @. | @. ] • +33 2 31 45 24 43 • LPC Caen, ENSICAEN, 6 Boulevard du Maréchal Juin, 14050, CAEN Cedex

De: "Charlotte Soneson" @.> À: "openjournals/joss-reviews" @.> Cc: "adrien matta" @.>, "Mention" @.> Envoyé: Dimanche 15 Octobre 2023 11:57:55 Objet: Re: [openjournals/joss-reviews] [PRE REVIEW]: LIBSsa: an open source software for analyzing LIBS spectra (Issue #5805)

👋🏻 [ https://github.com/adrien-matta | @adrien-matta ] , [ https://github.com/domna | @domna ] , [ https://github.com/jwuttke | @jwuttke ] , [ https://github.com/tpeulen | @tpeulen ] , [ https://github.com/alberto-battistel | @alberto-battistel ] - would you be interested in reviewing this submission for JOSS?

LIBSsa: an open source software for analyzing LIBS spectra [ https://github.com/openjournals/joss-reviews/issues/5805 | #5805 ]

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See [ https://joss.readthedocs.io/en/latest/review_criteria.html | https://joss.readthedocs.io/en/latest/review_criteria.html ] .

Thanks in advance!

— Reply to this email directly, [ https://github.com/openjournals/joss-reviews/issues/5805#issuecomment-1763340092 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ABKRIKKO23BGDOR3KL4VHILX7OXSHAVCNFSM6AAAAAA4LN7GHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGM2DAMBZGI | unsubscribe ] . You are receiving this because you were mentioned. Message ID: @.***>