openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: BrainDiffusion: A Python package for brain anatomic connectivity matrix. #5809

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@CoderNoMercy<!--end-author-handle-- (Zheyu Wen) Repository: https://github.com/CoderNoMercy/BrainDiffusion Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: Pending Reviewers: Pending Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b69a875d6f082e5a34545456bdab103c"><img src="https://joss.theoj.org/papers/b69a875d6f082e5a34545456bdab103c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b69a875d6f082e5a34545456bdab103c/status.svg)](https://joss.theoj.org/papers/b69a875d6f082e5a34545456bdab103c)

Author instructions

Thanks for submitting your paper to JOSS @CoderNoMercy. Currently, there isn't a JOSS editor assigned to your paper.

@CoderNoMercy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (321.7 files/s, 46319.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5            268            180            490
TeX                              1             19              0            207
Markdown                         2             28              0             81
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             9            316            184            796
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1227/00006123-199604000-00026 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/j.neuroimage.2007.10.060 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1002/nbm.1579 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.neuroimage.2019.116137 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1038/s41467-020-15701-2 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1038/nature12481 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1038/s41591-021-01309-6 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jmps.2018.10.013 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.48550/arXiv.2106.06016 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1007/BF02127704 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1002/jmri.27188 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1038/s41583-018-0071-7 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1002/mrm.1910340409 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1002/mrm.22159 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.neuroimage.2021.118870 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1155/2012/412512 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.clineuro.2014.06.009 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1007/s00285-015-0888-x is INVALID because of 'https://doi.org/' prefix
editorialbot commented 1 year ago

Wordcount for paper.md is 1151

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

Zheyu-Wen commented 1 year ago

@editorialbot generate pdf

The Open Journals editorial robot @.***> 于2023年9月5日周二 15:36写道:

Hello human, I'm @editorialbot https://github.com/editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5809#issuecomment-1707275585, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYQVMAOOF2VXGHBZSVDNPTXY6ELPANCNFSM6AAAAAA4MKHAZQ . You are receiving this because you were mentioned.Message ID: @.***>

-- University of Michigan, Ann Arbor Signal, image processing and machine learning major Personal Website: https://zheyw.netlify.app/ GitHub: https://github.com/CoderNoMercy

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @emdupre as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot query scope

editorialbot commented 1 year ago

Submission flagged for editorial review.

Kevin-Mattheus-Moerman commented 1 year ago

@emdupre Apologies, I invited you too soon. This will need to pass the scope review first.

Kevin-Mattheus-Moerman commented 1 year ago

@CoderNoMercy thanks for this submission. I am the AEiC for this track and here to help with the initial steps. For the moment I have flagged this submission for a scope review by our editorial board. This is because of the relatively small size (in terms of lines of code) of this project. As such we will need to determine if in terms of size and functionality contained in it, this work conforms to our substantial scholarly effort criteria. The scope review should take about 2 weeks to complete.

Zheyu-Wen commented 1 year ago

Thanks so much for your email! If any questions, please let me know!

Best, Zheyu

Kevin Mattheus Moerman @.***> 于2023年9月11日周一 07:59写道:

@CoderNoMercy https://github.com/CoderNoMercy thanks for this submission. I am the AEiC for this track and here to help with the initial steps. For the moment I have flagged this submission for a scope review by our editorial board. This is because of the relatively small size (in terms of lines of code) of this project. As such we will need to determine if in terms of size and functionality contained in it, this work conforms to our substantial scholarly effort criteria https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort. The scope review should take about 2 weeks to complete.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5809#issuecomment-1713830496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYQVMALIU66HCZTXLM5PHTXZ4DJZANCNFSM6AAAAAA4MKHAZQ . You are receiving this because you were mentioned.Message ID: @.***>

-- University of Michigan, Ann Arbor Signal, image processing and machine learning major Personal Website: https://zheyw.netlify.app/ GitHub: https://github.com/CoderNoMercy

Kevin-Mattheus-Moerman commented 1 year ago

@CoderNoMercy the editorial scope review has unfortunately concluded that this work is not deemed in scope for JOSS in its current form. In particular given its small size and relative immature nature it does not conform to our substantial scholarly effort criteria.

We will now proceed to reject this submission.

Note that although we will now reject this submission, this does not mean the work is not useful, or of a poor quality, it merely means that it is not in scope in its present form.

We do hope you'll consider JOSS for any (re)submissions of a more substantial/mature nature. You may also want to look into other avenues to making your code citable, e.g. this GitHub/ZENODO guide to obtain DOI's for your work.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot reject

editorialbot commented 1 year ago

Paper rejected.

Zheyu-Wen commented 1 year ago

Dear Editor,

We regret that our submission has been rejected. We are open to implementing the suggested improvements. Currently, the code is supported only by the GPU version. Our plan is to incorporate a CPU version and an MPI (Message Passing Interface) version into the code repository. Would these adjustments align with the journal's requirements?

It's worth noting that the repository has been under development for over a year and has been utilized in work accepted by the 2023 MICCAI workshop. Furthermore, it will also feature in an upcoming paper for IEEE Transactions on Medical Imaging. We are enthusiastic about the opportunity to have our work be part of JOSS results.

Best, Zheyu

On Tue, Sep 26, 2023 at 02:40 Kevin Mattheus Moerman < @.***> wrote:

@CoderNoMercy https://github.com/CoderNoMercy the editorial scope review has unfortunately concluded that this work is not deemed in scope for JOSS in its current form. In particular given its small size and relative immature nature it does not conform to our substantial scholarly effort criteria https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort .

We will now proceed to reject this submission.

Note that although we will now reject this submission, this does not mean the work is not useful, or of a poor quality, it merely means that it is not in scope in its present form.

We do hope you'll consider JOSS for any (re)submissions of a more substantial/mature nature. You may also want to look into other avenues to making your code citable, e.g. this GitHub/ZENODO guide to obtain DOI's for your work https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content .

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5809#issuecomment-1734997730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYQVMH4LX36X2PYNDA6AULX4KBG7ANCNFSM6AAAAAA4MKHAZQ . You are receiving this because you were mentioned.Message ID: @.***>

-- University of Michigan,Ann Arbor personal website:codernomercy.github.io