search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: SphericalScattering: A Julia Package for Electromagnetic Scattering from Spherical Objects #5820

Closed editorialbot closed 11 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@HoBeZwe<!--end-author-handle-- (Bernd Hofmann) Repository: https://github.com/HoBeZwe/SphericalScattering.jl Branch with paper.md (empty if default branch): Version: v0.6.0 Editor: !--editor-->@pdebuyl<!--end-editor-- Reviewers: @iliarasskazov, @berquist Archive: 10.5281/zenodo.10211642

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f3c8b7dd9fde474874e9a2f5f3a9db48"><img src="https://joss.theoj.org/papers/f3c8b7dd9fde474874e9a2f5f3a9db48/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f3c8b7dd9fde474874e9a2f5f3a9db48/status.svg)](https://joss.theoj.org/papers/f3c8b7dd9fde474874e9a2f5f3a9db48)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@iliarasskazov & @berquist, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @pdebuyl know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @berquist

📝 Checklist for @iliarasskazov

HoBeZwe commented 11 months ago

Hi, while reading the proof, we indeed spotted and fixed some typos in the references: Helmholtz, Poincare, and Julia start now with an upper-case letter and we added a comma. With that, everything appears fine from our side :-)

kyleniemeyer commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Hofmann given-names: Bernd orcid: "https://orcid.org/0000-0003-1435-6203" - family-names: Respondek given-names: Paula orcid: "https://orcid.org/0009-0005-4892-2711" - family-names: Adrian given-names: Simon B. orcid: "https://orcid.org/0000-0001-8008-6235" contact: - family-names: Hofmann given-names: Bernd orcid: "https://orcid.org/0000-0003-1435-6203" doi: 10.5281/zenodo.10211642 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Hofmann given-names: Bernd orcid: "https://orcid.org/0000-0003-1435-6203" - family-names: Respondek given-names: Paula orcid: "https://orcid.org/0009-0005-4892-2711" - family-names: Adrian given-names: Simon B. orcid: "https://orcid.org/0000-0001-8008-6235" date-published: 2023-11-30 doi: 10.21105/joss.05820 issn: 2475-9066 issue: 91 journal: Journal of Open Source Software publisher: name: Open Journals start: 5820 title: "SphericalScattering: A Julia Package for Electromagnetic Scattering from Spherical Objects" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05820" volume: 8 title: "SphericalScattering: A Julia Package for Electromagnetic Scattering from Spherical Objects" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4806
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05820
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 11 months ago

Congratulations @HoBeZwe on your article's publication in JOSS! Please consider signing up as a future reviewer if you haven't already.

Many thanks to @iliarasskazov and @berquist for reviewing this, and @pdebuyl for editing.

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05820/status.svg)](https://doi.org/10.21105/joss.05820)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05820">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05820/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05820/status.svg
   :target: https://doi.org/10.21105/joss.05820

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

HoBeZwe commented 11 months ago

Thank you, and thanks again for everybody's effort :-)

pdebuyl commented 11 months ago

Thanks @kyleniemeyer