openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: Arabica: A Python package for exploratory analysis of text data #5829

Closed editorialbot closed 8 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@PetrKorab<!--end-author-handle-- (Petr Koráb) Repository: https://github.com/PetrKorab/Arabica Branch with paper.md (empty if default branch): main Version: 1.7.1 Editor: !--editor-->@oliviaguest<!--end-editor-- Reviewers: @linuxscout, @amitkumarj441 Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8"><img src="https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8/status.svg)](https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8)

Author instructions

Thanks for submitting your paper to JOSS @PetrKorab. Currently, there isn't a JOSS editor assigned to your paper.

@PetrKorab if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: paper joss

editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: paper joss

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

arfon commented 1 year ago

@editorialbot set main as branch

editorialbot commented 1 year ago

Done! branch is now main

arfon commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.21 s (344.6 files/s, 159188.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      13           4507           4506          16694
CSS                              6            496            126           1791
HTML                             8            317              0            905
Python                          11            218             46            898
reStructuredText                17            394            340            395
Jupyter Notebook                 2              0            147            357
Markdown                         2             65              0            195
TeX                              1             13              0            125
XHTML                            3             14              0             79
XML                              3              0              0             67
YAML                             3              6             19             27
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            71           6042           5192          21568
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 0

arfon commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

arfon commented 1 year ago

@PetrKorab – I don't think @editorialbot knows how to find your paper when it's in a path with a space in it. Could you please rename the paper joss folder to paper-joss?

arfon commented 1 year ago

Also, it would be very helpful to describe how your submission varies in scope/goals to this one: https://github.com/openjournals/joss-reviews/issues/4886

PetrKorab commented 1 year ago

@arfon Thanks. I moved the paper files to the main directory (https://github.com/PetrKorab/Arabica). The paper should now compile without problems. I also updated the paper with the contribution to the literature you mentioned.

arfon commented 11 months ago

@editorialbot generate pdf

arfon commented 11 months ago

@editorialbot query scope

@PetrKorab – due to the relatively limited size of this submission, I'm going to ask the JOSS editorial team to take a look at whether this submission is in scope for us. This will likely take a couple of weeks to complete.

editorialbot commented 11 months ago

Submission flagged for editorial review.

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

TextDescriptives: A Python package for calculating a large variety of metrics from text Submitting author: @HLasse Handling editor: @fabian-s (Active) Reviewers: @RichardLitt, @linuxscout Similarity score: 0.8207

textnets: A Python package for text analysis with networks Submitting author: @jboynyc Handling editor: @gkthiruvathukal (Active) Reviewers: @sara-02, @tresoldi Similarity score: 0.8147

niacin: A Python package for text data enrichment Submitting author: @deniederhut Handling editor: @oliviaguest (Active) Reviewers: @BayesforDays, @sara-02 Similarity score: 0.8066

LISC: A Python Package for Scientific Literature Collection and Analysis Submitting author: @TomDonoghue Handling editor: @danielskatz (Active) Reviewers: @timClicks, @linuxscout Similarity score: 0.8030

Altair: Interactive Statistical Visualizations for Python Submitting author: @domoritz Handling editor: @jedbrown (Active) Reviewers: @dnszafir, @terrytangyuan, @kellieotto Similarity score: 0.7993

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 11 months ago

@PetrKorab – I don't see any way of testing this software. Could you please explain to me how this library is tested?

PetrKorab commented 11 months ago

@arfon I have added "tests" folder that contains the Travis CI test of the code generating the graphs used in the paper. I can provide additional manual tests, if necessary.

arfon commented 11 months ago

@arfon I have added "tests" folder that contains the Travis CI test of the code generating the graphs used in the paper. I can provide additional manual tests, if necessary.

This is probably useful, but not what I'm looking for. As a part of the JOSS review process, your software needs to have tests for reviewers to exercise (see https://joss.readthedocs.io/en/latest/review_criteria.html#tests). Without these, the package cannot be reviewed.

PetrKorab commented 11 months ago

@arfon The "tests" folder in the main branch now contains automated tests with Travis CI (Circle Ci alike). The reviews can fork the repository and make pull requests to run the test.

arfon commented 10 months ago

@PetrKorab – your software has passed the scope review. I'm now moving it to be 'waitlisted' while we await a suitable editor to take this submission on.

oliviaguest commented 8 months ago

@linuxscout @amitkumarj441 @kikarimullah can any or all of you review this, please? ☺️

oliviaguest commented 8 months ago

@editorialbot assign me as editor

editorialbot commented 8 months ago

Assigned! @oliviaguest is now the editor

amitkumarj441 commented 8 months ago

Hi @oliviaguest Sure, I would be happy to help.

linuxscout commented 8 months ago

Ok, I can review it.

oliviaguest commented 8 months ago

@editorialbot add @linuxscout as reviewer

editorialbot commented 8 months ago

@linuxscout added to the reviewers list!

oliviaguest commented 8 months ago

@editorialbot add @amitkumarj441 as reviewer

editorialbot commented 8 months ago

@amitkumarj441 added to the reviewers list!

oliviaguest commented 8 months ago

@editorialbot start review

editorialbot commented 8 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6186.

oliviaguest commented 8 months ago

@linuxscout @amitkumarj441 @PetrKorab please go to #6186; and thank you to the reviewers for agreeing to review! 😊

PetrKorab commented 8 months ago

@linuxscout @amitkumarj441 @oliviaguest Thanks !