openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: OriTsgEFA: Origami and Tensegrity Equilibrium and Form-finding Analysis #5856

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@Muhao-Chen<!--end-author-handle-- (Muhao Chen) Repository: https://github.com/Muhao-Chen/Origami_and_Tensegrity_Equilibrium_and_Form-finding_Analysis_OriTsgEFA Branch with paper.md (empty if default branch): main Version: v1.1 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @Kevin-Mattheus-Moerman, @iammix Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/477530fbcc16c569efc667f979a75991"><img src="https://joss.theoj.org/papers/477530fbcc16c569efc667f979a75991/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/477530fbcc16c569efc667f979a75991/status.svg)](https://joss.theoj.org/papers/477530fbcc16c569efc667f979a75991)

Author instructions

Thanks for submitting your paper to JOSS @Muhao-Chen. Currently, there isn't a JOSS editor assigned to your paper.

@Muhao-Chen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: JOSS_paper

editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: JOSS_paper

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

kyleniemeyer commented 1 year ago

Hello @Muhao-Chen, it looks like you indicated that the JOSS paper was on the JOSS_paper branch, but there is no such branch in the repository. The paper looks to be on the main branch, just in the JOSS_paper directory.

Also, while we are getting started, can you please explain in detail the differences between this submission and the previous submission "TsgFEM: Tensegrity Finite Element Method"? I noticed that some of the files in the repository for the current position seem copied from TsgFEM.

kyleniemeyer commented 1 year ago

@editorialbot set main as branch

editorialbot commented 1 year ago

Done! branch is now main

kyleniemeyer commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

kyleniemeyer commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (1241.2 files/s, 130004.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          34            481           1342           2408
TeX                              1             39              0            364
Markdown                        12             85              0            204
-------------------------------------------------------------------------------
SUM:                            47            605           1342           2976
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1208

Muhao-Chen commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

Muhao-Chen commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Muhao-Chen commented 1 year ago

Hello @Muhao-Chen, it looks like you indicated that the JOSS paper was on the JOSS_paper branch, but there is no such branch in the repository. The paper looks to be on the main branch, just in the JOSS_paper directory.

@kyleniemeyer Thanks for helping us. I have fixed the problem. The pdf looks good now.

Also, while we are getting started, can you please explain in detail the differences between this submission and the previous submission "TsgFEM: Tensegrity Finite Element Method"? I noticed that some of the files in the repository for the current position seem copied from TsgFEM.

Yes, the TsgFEM facilitates static and dynamic analyses via the finite element method (FEM) for tensegrity systems simulations. On the other hand, OriTsgFEA provides a comprehensive platform for both equilibrium and form-finding studies of combined origami and tensegrity systems. Some of the .m files (i.e., generate the connectivity matrices, the material definition of tensegrity bars and strings) are copied from TsgFEM; these source codes are appropriately cited.

kyleniemeyer commented 1 year ago

@Muhao-Chen thanks - can you quantify how many of the source code files are copied from TsgFEM? I want to make sure that this new submission is sufficiently substantial on its own.

Muhao-Chen commented 1 year ago

@kyleniemeyer Thanks for your question. There are about 12/35 (TsgFEM/OriTsgEFA). Both are independent software packages for different analysis purposes. The shared files are more like generating pictures, videos, material libraries, etc. Could you please let me know if this is ok? Many thanks!

Muhao-Chen commented 1 year ago

@kyleniemeyer, May I know if you have difficulties finding reviewers? The reviewers of TsgFEM are very professional and an excellent option to invite: HaoZeke, Kevin-Mattheus-Moerman, and likask. Thanks very much!

kyleniemeyer commented 1 year ago

@editorialbot invite @diehlpk as editor

Hi @diehlpk, since you edited the previous related submission (https://joss.theoj.org/papers/10.21105/joss.03390), could you edit this submission as well? Thanks!

editorialbot commented 1 year ago

Invitation to edit this submission sent!

diehlpk commented 1 year ago

@editorialbot add @diehlpk as editor

editorialbot commented 1 year ago

Assigned! @diehlpk is now the editor

diehlpk commented 1 year ago

Hi @HaoZeke do you have time to review this paper?

diehlpk commented 1 year ago

Hi @Kevin-Mattheus-Moerman do you have time to review this paper?

diehlpk commented 1 year ago

Hi @likask do you have time to review this paper?

Kevin-Mattheus-Moerman commented 1 year ago

@diehlpk yes sounds interesting

diehlpk commented 1 year ago

@editorialbot add @Kevin-Mattheus-Moerman as reviewer

editorialbot commented 1 year ago

@Kevin-Mattheus-Moerman added to the reviewers list!

diehlpk commented 1 year ago

Hi @iammix do you have time to review this paper?

diehlpk commented 1 year ago

Hi @CWillberg do you have time to review this paper?

iammix commented 1 year ago

Hello @diehlpk, yes I will be able to review it.

diehlpk commented 1 year ago

@editorialbot add @iammix as reviewer

editorialbot commented 1 year ago

@iammix added to the reviewers list!

diehlpk commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5939.