[REVIEW]: sparse-lm: Sparse linear regression models in Python

[editorialbot]

Submitting author: !--author-handle-->@lbluque<!--end-author-handle-- (Luis Barroso-Luque) Repository: https://github.com/CederGroupHub/sparse-lm Branch with paper.md (empty if default branch): paper Version: v0.5.2 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @htjb, @mhu48 Archive: 10.5281/zenodo.10246640

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7ff5b2d9175c3e316ff7e9ac02d15540"><img src="https://joss.theoj.org/papers/7ff5b2d9175c3e316ff7e9ac02d15540/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7ff5b2d9175c3e316ff7e9ac02d15540/status.svg)](https://joss.theoj.org/papers/7ff5b2d9175c3e316ff7e9ac02d15540)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@htjb & @mhu48, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @htjb

📝 Checklist for @mhu48

[editorialbot]

Done! archive is now 10.5281/zenodo.10246640

[jbytecode]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.2517-6161.1996.tb02080.x is OK
- 10.1198/016214506000000735 is OK
- 10.1080/00401706.1967.10490502 is OK
- 10.1214/15-AOS1388 is OK
- 10.1287/opre.2015.1436 is OK
- 10.1111/j.1467-9868.2005.00532.x is OK
- 10.1080/10618600.2012.681250 is OK
- 10.1007/s00362-017-0882-z is OK
- 10.21105/joss.03024 is OK
- 10.1257/jep.31.2.3 is OK
- 10.23919/CCC52363.2021.9549471 is OK
- 10.1080/03610918.2011.611311 is OK
- 10.1039/C7RE00210F is OK
- 10.1186/1471-2105-8-60 is OK
- 10.1103/PhysRevB.100.134108 is OK
- 10.1016/j.commatsci.2022.112000 is OK
- 10.1103/PhysRevB.106.024203 is OK
- 10.1103/PRXEnergy.2.043005 is OK
- 10.1103/PhysRevB.106.144202 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[jbytecode]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[jbytecode]

@lbluque - Thank you for adding ORCIDs. Almost done. The reference list looks fine. Please have a full read of the compiled pdf and perform a full grammar check. Correct any issue if exists, and then ping me again.

[lbluque]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[jbytecode]

@lbluque - is that the latest form or are you still checking?

[lbluque]

Almost @jbytecode. I am waiting on final comments from my coauthor, and then it should be ready to go!

[lbluque]

@editorialbot generate pdf

[lbluque]

Hi @jbytecode - sorry this was delayed longer than expected.

I have pushed final edits based on my coauthor's comments to the paper and it should be ready to go.

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[jbytecode]

@lbluque - Looks good to me. I am now recommending an accept. The track editor will make the final decision. Thank you.

[jbytecode]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.2517-6161.1996.tb02080.x is OK
- 10.1198/016214506000000735 is OK
- 10.1080/00401706.1967.10490502 is OK
- 10.1214/15-AOS1388 is OK
- 10.1287/opre.2015.1436 is OK
- 10.1111/j.1467-9868.2005.00532.x is OK
- 10.1080/10618600.2012.681250 is OK
- 10.1007/s00362-017-0882-z is OK
- 10.21105/joss.03024 is OK
- 10.1257/jep.31.2.3 is OK
- 10.23919/CCC52363.2021.9549471 is OK
- 10.1080/03610918.2011.611311 is OK
- 10.1039/C7RE00210F is OK
- 10.1186/1471-2105-8-60 is OK
- 10.1103/PhysRevB.100.134108 is OK
- 10.1016/j.commatsci.2022.112000 is OK
- 10.1103/PhysRevB.106.024203 is OK
- 10.1103/PRXEnergy.2.043005 is OK
- 10.1103/PhysRevB.106.144202 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[jbytecode]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.2517-6161.1996.tb02080.x is OK
- 10.1198/016214506000000735 is OK
- 10.1080/00401706.1967.10490502 is OK
- 10.1214/15-AOS1388 is OK
- 10.1287/opre.2015.1436 is OK
- 10.1111/j.1467-9868.2005.00532.x is OK
- 10.1080/10618600.2012.681250 is OK
- 10.1007/s00362-017-0882-z is OK
- 10.21105/joss.03024 is OK
- 10.1257/jep.31.2.3 is OK
- 10.23919/CCC52363.2021.9549471 is OK
- 10.1080/03610918.2011.611311 is OK
- 10.1039/C7RE00210F is OK
- 10.1186/1471-2105-8-60 is OK
- 10.1103/PhysRevB.100.134108 is OK
- 10.1016/j.commatsci.2022.112000 is OK
- 10.1103/PhysRevB.106.024203 is OK
- 10.1103/PRXEnergy.2.043005 is OK
- 10.1103/PhysRevB.106.144202 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.

    &\begin{array}{r@{~}l@{}l@{\quad}l}
     ^
unexpected "\\"
expecting "&", "\\\\", white space or "\\end"

[editorialbot]

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4859, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[lbluque]

@lbluque - Looks good to me. I am now recommending an accept. The track editor will make the final decision. Thank you.

Thanks so much for your detailed editing @jbytecode !

And many thanks @htjb and @mhu48 for your reviews!

[arfon]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.

    &\begin{array}{r@{~}l@{}l@{\quad}l}
     ^
unexpected "\\"
expecting "&", "\\\\", white space or "\\end"

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Barroso-Luque given-names: Luis orcid: "https://orcid.org/0000-0002-6453-9545" - family-names: Xie given-names: Fengyu orcid: "https://orcid.org/0000-0002-1169-1690" contact: - family-names: Barroso-Luque given-names: Luis orcid: "https://orcid.org/0000-0002-6453-9545" doi: 10.5281/zenodo.10246640 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Barroso-Luque given-names: Luis orcid: "https://orcid.org/0000-0002-6453-9545" - family-names: Xie given-names: Fengyu orcid: "https://orcid.org/0000-0002-1169-1690" date-published: 2023-12-21 doi: 10.21105/joss.05867 issn: 2475-9066 issue: 92 journal: Journal of Open Source Software publisher: name: Open Journals start: 5867 title: "sparse-lm: Sparse linear regression models in Python" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05867" volume: 8 title: "sparse-lm: Sparse linear regression models in Python" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4860
1. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05867
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[arfon]

@htjb, @mhu48 – many thanks for your reviews here and to @jbytecode for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@lbluque – your paper is now accepted and published in JOSS :zap::rocket::boom:

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05867/status.svg)](https://doi.org/10.21105/joss.05867)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05867">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05867/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05867/status.svg
   :target: https://doi.org/10.21105/joss.05867

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss