openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: OneWorld: python mapping made easy #5880

Closed editorialbot closed 11 months ago

editorialbot commented 11 months ago

Submitting author: !--author-handle-->@toni-am<!--end-author-handle-- (Antoni Aguilar-Mogas) Repository: https://bitbucket.org/taguilar/oneworld Branch with paper.md (empty if default branch): Version: 1.0.7 Editor: Pending Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e0be64c027bde2700908aef822993d14"><img src="https://joss.theoj.org/papers/e0be64c027bde2700908aef822993d14/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e0be64c027bde2700908aef822993d14/status.svg)](https://joss.theoj.org/papers/e0be64c027bde2700908aef822993d14)

Author instructions

Thanks for submitting your paper to JOSS @. Currently, there isn't a JOSS editor assigned to your paper.

@ if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 11 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 11 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.26 s (641.1 files/s, 251550.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            86           5056             46          40425
JavaScript                      11           2213           2211           8197
SVG                              1              0              0           2671
Python                          17            163           1512           1236
CSS                              4            192             40            779
reStructuredText                41            328            239            561
Markdown                         2             52              0            133
TeX                              1              1              0            111
JSON                             1              0              0             59
DOS Batch                        1              8              1             26
YAML                             2              4              5             16
make                             1              4              7              9
INI                              1              0              0              2
-------------------------------------------------------------------------------
SUM:                           169           8021           4061          54225
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 11 months ago

Wordcount for paper.md is 1601

editorialbot commented 11 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2105/ajph.94.10.1695 is OK
- 10.21105/joss.03021 is OK
- 10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- 10.1109/mcse.2007.55 may be a valid DOI for title: Matplotlib: A 2D Graphics Environment

INVALID DOIs

- None
editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

BigX: A geographical dataset visualisation tool Reviewers: @liberostelios, @jvdkwast Similarity score: 0.8327

Leafmap: A Python package for interactive mapping and geospatial analysis with minimal coding in a Jupyter environment Reviewers: @martinfleis, @TomasBeuzen Similarity score: 0.8269

geemap: A Python package for interactive mapping with Google Earth Engine Reviewers: @fbiljecki, @steflhermitte Similarity score: 0.8259

splot - visual analytics for spatial statistics Reviewers: @ResidentMario, @martinfleis Similarity score: 0.8185

GeoHexViz: A Python package for the visualizing hexagonally binned geospatial data Reviewers: @gassmoeller, @kaustavbhattacharjee Similarity score: 0.8101

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 11 months ago

Pausing this until we have a GitHub handle for the author to interact with here.

toni-am commented 11 months ago

Thank you for comments. I am the author of the submitted paper and this is my github user.

arfon commented 11 months ago

Thanks for the ping @toni-am. As this submission is on the smaller side of what we typically publish in JOSS I'm going to start a scope review and seek the opinion of the wider editorial team. This will likely take a couple of weeks to complete.

arfon commented 11 months ago

@editorialbot query scope

editorialbot commented 11 months ago

Submission flagged for editorial review.

toni-am commented 11 months ago

Dear @arfon thank you very much for considering the paper for publication. Regarding the size of the software, in defense of the module and hoping that it will help with the discussion process, I would like to point out that the module is 1.5K lines of code long, above the threshold cutoff stated in the JOSS submission guide. For reference, from the last 5 papers published in JOSS regarding python modules, three of them are longer (pydgn with 5.4K LOC, ggce with 2.2K LOC and exorad with 4.9K LOC), while two of them are shorter (blackbirds and pyswarming with 1.0K LOC and 0.5K LOC respectively).

toni-am commented 11 months ago

I would also like to mention here that the software has been and is currently being used in a series of reports for the USDA ( reference Golden 2019 in the paper), as well as in ongoing research regarding health disparities (with one paper submitted to Patient Experience Journal).

toni-am commented 11 months ago

I am sorry if this is not the right venue to communicate. I am looking forward to any kind of feedback that will help me improve the software. Thanks again for your consideration.

oliviaguest commented 11 months ago

@toni-am it is the right place, I just was away for a week. :blush:

toni-am commented 11 months ago

Hi @oliviaguest , no worries! I do this extra hours so it usually takes me a couple of days to respond (I apologize in advance). No rush! Please let me know how I can help. Thank you!

oliviaguest commented 11 months ago

@toni-am the mapping functionality provided is a plotting-based utility and while for sure useful, we do not publish this kind of work at JOSS. I am really sorry to bring you this bad news and hope you consider JOSS for the future.

oliviaguest commented 11 months ago

@editorialbot reject

editorialbot commented 11 months ago

Paper rejected.

toni-am commented 11 months ago

Thank you for getting back to me so quickly. I am surprised to see that the reason for rejecting my paper is that "JOSS does not publish plotting-based utilities", since the publication of plotting-based utilities in JOSS (e.g. Seaborn) is why I decided to submit my work to JOSS in the first place.

I feel like if this "no plotting-based utilities" policy was stated clearly in the submission instructions it would have saved us all our time and effort.

Thank you for your feedback and your suggestions. Kind regards.