[REVIEW]: PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@pswpswpsw@olexandr-konovalov<!--end-editor-- Reviewers: @ulf1, @fandreuz Archive: 10.5281/zenodo.10685233

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d57dcd25ed8a287b4de09502d05890cd"><img src="https://joss.theoj.org/papers/d57dcd25ed8a287b4de09502d05890cd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d57dcd25ed8a287b4de09502d05890cd/status.svg)](https://joss.theoj.org/papers/d57dcd25ed8a287b4de09502d05890cd)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ulf1 & @fandreuz, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @olexandr-konovalov know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @fandreuz

📝 Checklist for @ulf1

editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Pan given-names: Shaowu orcid: "https://orcid.org/0000-0002-2462-362X" - family-names: Kaiser given-names: Eurika orcid: "https://orcid.org/0000-0001-6049-0812" - family-names: Silva given-names: Brian M. name-particle: de orcid: "https://orcid.org/0000-0003-0944-900X" - family-names: Kutz given-names: J. Nathan orcid: "https://orcid.org/0000-0002-6004-2275" - family-names: Brunton given-names: Steven L. orcid: "https://orcid.org/0000-0002-6565-5118" doi: 10.5281/zenodo.10685233 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Pan given-names: Shaowu orcid: "https://orcid.org/0000-0002-2462-362X" - family-names: Kaiser given-names: Eurika orcid: "https://orcid.org/0000-0001-6049-0812" - family-names: Silva given-names: Brian M. name-particle: de orcid: "https://orcid.org/0000-0003-0944-900X" - family-names: Kutz given-names: J. Nathan orcid: "https://orcid.org/0000-0002-6004-2275" - family-names: Brunton given-names: Steven L. orcid: "https://orcid.org/0000-0002-6565-5118" date-published: 2024-02-25 doi: 10.21105/joss.05881 issn: 2475-9066 issue: 94 journal: Journal of Open Source Software publisher: name: Open Journals start: 5881 title: "PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05881" volume: 9 title: "PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5050
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05881
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 8 months ago

Congratulations to @pswpswpsw (Shaowu Pan) and co-authors on your publication!!

And thanks to @ulf1 and @fandreuz for reviewing, and to @olexandr-konovalov for editing! JOSS depends on volunteers and we couldn't do this without you

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05881/status.svg)](https://doi.org/10.21105/joss.05881)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05881">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05881/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05881/status.svg
   :target: https://doi.org/10.21105/joss.05881

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

pswpswpsw commented 8 months ago

@danielskatz @olexandr-konovalov @fandreuz @ulf1 Thank you all for the hard work! Happy weekend!

openjournals / joss-reviews