openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: MathMat: A Mathematically Aware Matrix Library #5902

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@furmada<!--end-author-handle-- (Adam Furman) Repository: https://github.com/furmada/MathMat Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bdc11794e63cfe04fa9762437666c3a9"><img src="https://joss.theoj.org/papers/bdc11794e63cfe04fa9762437666c3a9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bdc11794e63cfe04fa9762437666c3a9/status.svg)](https://joss.theoj.org/papers/bdc11794e63cfe04fa9762437666c3a9)

Author instructions

Thanks for submitting your paper to JOSS @furmada. Currently, there isn't a JOSS editor assigned to your paper.

@furmada if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (288.2 files/s, 217562.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              5              0            123           7729
HTML                             7           1039              0           7430
Python                           6            237            375            979
TeX                              2             99              0            574
Markdown                         2             43              0            153
JavaScript                       1              3              3             40
TOML                             1              1              0             23
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            25           1423            505          16946
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 950

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

The SuiteSparse Matrix Collection Website Interface Submitting author: @ScottKolo Handling editor: @jedbrown (Active) Reviewers: @dblarremore, @tkonolige Similarity score: 0.8180

PYroMat: A Python package for thermodynamic properties Submitting author: @jranalli Handling editor: @jgostick (Active) Reviewers: @espottesmith, @fwitte Similarity score: 0.8142

mpnum: A matrix product representation library for Python Submitting author: @dseuss Handling editor: @labarba (Retired) Reviewers: @SylvainCorlay Similarity score: 0.8072

Armadillo: a template-based C++ library for linear algebra Submitting author: @conradsnicta Handling editor: @arfon (Active) Reviewers: @wrathematics Similarity score: 0.8062

MatD^3^: A Database and Online Presentation Package for Research Data Supporting Materials Discovery, Design, and Dissemination Submitting author: @raullaasner Handling editor: @majensen (Active) Reviewers: @dgasmith, @mkhorton Similarity score: 0.8007

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

👋 @furmada - thanks for your submission.

Note that your paper doesn't have a "References" header. Please follow the example paper. In addition, please remove the references you aren't using in the .bib file. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check the DOI, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

In addition, due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

danielskatz commented 1 year ago

@editorialbot query scope

editorialbot commented 1 year ago

Submission flagged for editorial review.

furmada commented 1 year ago

@editorialbot check references

furmada commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

The SuiteSparse Matrix Collection Website Interface Submitting author: @ScottKolo Handling editor: @jedbrown (Active) Reviewers: @dblarremore, @tkonolige Similarity score: 0.8187

MatDL: A Lightweight Deep Learning Library in MATLAB Submitting author: @haythamfayek Handling editor: @cMadan (Active) Reviewers: @nirum Similarity score: 0.8167

mpnum: A matrix product representation library for Python Submitting author: @dseuss Handling editor: @labarba (Retired) Reviewers: @SylvainCorlay Similarity score: 0.8104

Armadillo: a template-based C++ library for linear algebra Submitting author: @conradsnicta Handling editor: @arfon (Active) Reviewers: @wrathematics Similarity score: 0.8054

PyArmadillo: a streamlined linear algebra library for Python Submitting author: @jason-rumengan Handling editor: @mjsottile (Retired) Reviewers: @JaroslavHron, @uellue Similarity score: 0.8044

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

👋 @furmada - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS.

Comments from editors discussed the relatively simplicity of the software and the fact that some of it is wrapping of existing software. Some editors were unsure how it improves upon numpy/scipy for general usage. The lack of tests was also an issue.

Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

danielskatz commented 1 year ago

@editorialbot reject

editorialbot commented 1 year ago

Paper rejected.