openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[PRE REVIEW]: cppdlr: Imaginary time calculations using the discrete Lehmann representation #5913

Open editorialbot opened 9 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@jasonkaye<!--end-author-handle-- (Jason Kaye) Repository: https://github.com/flatironinstitute/cppdlr/ Branch with paper.md (empty if default branch): joss Version: v1.0.0 Editor: !--editor-->@jarvist<!--end-editor-- Reviewers: !--reviewers-list-->@neutrino155<!--end-reviewers-list-- Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8fd2af732c1adedb99b271dfc91d7e1e"><img src="https://joss.theoj.org/papers/8fd2af732c1adedb99b271dfc91d7e1e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8fd2af732c1adedb99b271dfc91d7e1e/status.svg)](https://joss.theoj.org/papers/8fd2af732c1adedb99b271dfc91d7e1e)

Author instructions

Thanks for submitting your paper to JOSS @jasonkaye. Currently, there isn't a JOSS editor assigned to your paper.

@jasonkaye if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (1737.9 files/s, 235574.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             17            728            872           1735
C/C++ Header                     7            346           1069            822
CMake                           15            116            205            600
reStructuredText                 8            192            122            463
CSS                              2             80             20            354
TeX                              1             27              0            286
XML                              1              6              8            226
Markdown                         5             53              0            161
YAML                             4             12              6            130
MATLAB                           1             14             11             66
HTML                             2              6              0             60
JavaScript                       2              0             13              2
-------------------------------------------------------------------------------
SUM:                            65           1580           2326           4905
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 895

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1103/PhysRevB.98.035104 is OK
- 10.1103/PhysRevB.105.235115 is OK
- 10.1007/s10444-023-10067-7 is OK
- 10.1103/PhysRevB.107.245123 is OK
- 10.1103/PhysRevB.96.035147 is OK
- 10.1103/PhysRevB.84.075145 is OK
- 10.1063/5.0003145 is OK
- 10.1103/PhysRevB.98.075127 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.106.L220502 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/j.cpc.2022.108458 is INVALID because of 'https://doi.org/' prefix
- http://dx.doi.org/10.1016/j.cpc.2015.04.023 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.softx.2022.101266 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 9 months ago

@editorialbot invite @jarvist as editor

Hi @jarvist, could you take this one on?

editorialbot commented 9 months ago

Invitation to edit this submission sent!

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

iharm3D: Vectorized General Relativistic Magnetohydrodynamics Submitting author: @bprather Handling editor: @eloisabentivegna (Active) Reviewers: @bgiacoma, @cpalenzuela Similarity score: 0.8004

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices Submitting author: @ljakoster Handling editor: @rkurchin (Active) Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie Similarity score: 0.7930

Interface to high-performance periodic coupled-cluster theory calculations with atom-centered, localized basis functions Submitting author: @Evmoerman Handling editor: @rkurchin (Active) Reviewers: @awvwgk, @wcwitt Similarity score: 0.7902

PetIBM: toolbox and applications of the immersed-boundary method on distributed-memory architectures Submitting author: @labarba Handling editor: @kyleniemeyer (Active) Reviewers: @jedbrown Similarity score: 0.7869

GRChombo: An adaptable numerical relativity code for fundamental physics Submitting author: @kaclough Handling editor: @rkurchin (Active) Reviewers: @sbozzolo, @rashti-alireza Similarity score: 0.7866

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

HugoStrand commented 9 months ago

Dear Editor,

In your list of reviewers Evan1415 https://reviewers.joss.theoj.org/reviewers/815 seems to have background in the field.

Best regards, Hugo U. R. Strand (co-author)

Wentzell commented 9 months ago

Dear Editor,

I suggest further the following reviewers: mdavezac, mturiansky, jwuttke

Best regards, Nils Wentzell (co-author)

kyleniemeyer commented 9 months ago

Hi @jarvist, just a ping on my request to edit this.

jarvist commented 7 months ago

@kyleniemeyer thanks for following up by email! The github pings got buried. I am very busy this term, but as its a good technical fit to my area, I will take it on.

jarvist commented 7 months ago

@editorialbot assign @jarvist as editor

editorialbot commented 7 months ago

Assigned! @jarvist is now the editor

jarvist commented 7 months ago

OK, thank you for your suggestions @HugoStrand - I've emailed some potential reviewers.

jasonkaye commented 6 months ago

Hi @jarvist, just wanted to check in to see if there has been any movement on this.

jarvist commented 5 months ago

Dear Jason, My apologies - my emails went either unanswered, or the person I contacted stated it was outside their expertise. I have asked my PhD student @neutrino155 to review, as it is in their area of expertise but they are currently writing up their thesis :)

If you have any other suggestions for more senior / independent people who could review this, I would be much obliged!

jarvist commented 5 months ago

@editorialbot assign @neutrino155 as reviewer

editorialbot commented 5 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

jarvist commented 5 months ago

@editorialbot add @neutrino155 as reviewer

editorialbot commented 5 months ago

@neutrino155 added to the reviewers list!

jarvist commented 5 months ago

As @neutrino155 has some time now, and it has been going on for a while, I will start the review so you can get some feedback ASAP.

jarvist commented 5 months ago

@editorialbot start review

editorialbot commented 5 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6297.