openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: ClassipyGRB: Machine Learning-Based Classification and Visualization of Gamma Ray Bursts using t-SNE #5923

Closed editorialbot closed 7 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@KenethGarcia<!--end-author-handle-- (Keneth Stiven Garcia Cifuentes) Repository: https://github.com/KenethGarcia/ClassiPyGRB Branch with paper.md (empty if default branch): Version: v1.1.0 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: @wkerzendorf, @dfm Archive: 10.5281/zenodo.10909942

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7bcbbbccadea95a7ff3311554fe92dcc"><img src="https://joss.theoj.org/papers/7bcbbbccadea95a7ff3311554fe92dcc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7bcbbbccadea95a7ff3311554fe92dcc/status.svg)](https://joss.theoj.org/papers/7bcbbbccadea95a7ff3311554fe92dcc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wkerzendorf & @dfm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @dfm

πŸ“ Checklist for @wkerzendorf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 7 months ago

@editorialbot recommend-accept

editorialbot commented 7 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/acb999 is OK
- 10.1086/186969 is OK
- 10.1038/s41586-022-05403-8 is OK
- 10.3847/2041-8213/ab964d is OK
- 10.48550/arXiv.2304.08666 is OK
- 10.48550/arXiv.2201.05145 is OK
- 10.1093/mnras/stad3624 is OK
- 10.3847/1538-4357/ace325 is OK
- 10.3847/1538-4357/ac9d38 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 7 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5230, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 7 months ago

@editorialbot accept

editorialbot commented 7 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 7 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Garcia-Cifuentes given-names: Keneth orcid: "https://orcid.org/0009-0001-2607-6359" - family-names: Becerra given-names: Rosa L. orcid: "https://orcid.org/0000-0002-0216-3415" - family-names: Colle given-names: Fabio De orcid: "https://orcid.org/0000-0002-3137-4633" contact: - family-names: Garcia-Cifuentes given-names: Keneth orcid: "https://orcid.org/0009-0001-2607-6359" doi: 10.5281/zenodo.10909942 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Garcia-Cifuentes given-names: Keneth orcid: "https://orcid.org/0009-0001-2607-6359" - family-names: Becerra given-names: Rosa L. orcid: "https://orcid.org/0000-0002-0216-3415" - family-names: Colle given-names: Fabio De orcid: "https://orcid.org/0000-0002-3137-4633" date-published: 2024-04-08 doi: 10.21105/joss.05923 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 5923 title: "ClassiPyGRB: Machine Learning-Based Classification and Visualization of Gamma Ray Bursts using t-SNE" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05923" volume: 9 title: "ClassiPyGRB: Machine Learning-Based Classification and Visualization of Gamma Ray Bursts using t-SNE" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 7 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 7 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5231
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05923
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

dfm commented 7 months ago

@wkerzendorf β€” Many thanks for your review here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@KenethGarcia β€” Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 7 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05923/status.svg)](https://doi.org/10.21105/joss.05923)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05923">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05923/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05923/status.svg
   :target: https://doi.org/10.21105/joss.05923

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

KenethGarcia commented 7 months ago

Thank you so much @dfm @wkerzendorf !