search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[PRE REVIEW]: hp3D: A Scalable MPI/OpenMP hp-Adaptive Finite Element Software Library for Complex Multiphysics Applications #5936

Closed editorialbot closed 10 months ago

editorialbot commented 11 months ago

Submitting author: !--author-handle-->@stefanhenneking<!--end-author-handle-- (Stefan Henneking) Repository: https://github.com/Oden-EAG/hp3d Branch with paper.md (empty if default branch): joss-paper Version: v1.0-beta Editor: !--editor-->@jedbrown<!--end-editor-- Reviewers: @peterrum, @likask Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/79ef3f54fa7899384b8ffa5a94637189"><img src="https://joss.theoj.org/papers/79ef3f54fa7899384b8ffa5a94637189/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/79ef3f54fa7899384b8ffa5a94637189/status.svg)](https://joss.theoj.org/papers/79ef3f54fa7899384b8ffa5a94637189)

Author instructions

Thanks for submitting your paper to JOSS @stefanhenneking. Currently, there isn't a JOSS editor assigned to your paper.

@stefanhenneking if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 11 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 11 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.50 s (1496.0 files/s, 368367.4 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Fortran 90                      481           1349          47417          68317
Fortran 77                      153            341          19916          23983
TeX                              22           1227           3511           8987
Python                            4             11             92           1686
make                             54            306            143           1430
Bourne Shell                     14            161            426            653
C                                 1            177            227            537
Perl                              2            144            292            500
Bourne Again Shell               11            156           1079            372
Markdown                          2             31              0            164
Pascal                            1              2              0             44
C/C++ Header                      1              2              0             10
--------------------------------------------------------------------------------
SUM:                            746           3907          73103         106683
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 11 months ago

Wordcount for paper.md is 767

editorialbot commented 11 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.camwa.2021.01.006 may be a valid DOI for title: Model and computational advancements to full vectorial Maxwell model for studying fiber amplifiers
- 10.1016/j.camwa.2020.03.024 may be a valid DOI for title: A numerical study of the pollution error and DPG adaptivity for long waveguide simulations
- 10.1016/j.camwa.2023.07.006 may be a valid DOI for title: Scalable DPG Multigrid Solver for Helmholtz Problems: A Study on Convergence
- 10.2139/ssrn.4589638 may be a valid DOI for title: An anisotropic hp-adaptation framework for ultraweak discontinuous Petrov–Galerkin formulations
- 10.1016/j.camwa.2021.01.017 may be a valid DOI for title: An adaptive multigrid solver for DPG methods with applications in linear acoustics and electromagnetics
- 10.1137/s0895479899358194 may be a valid DOI for title: A fully asynchronous multifrontal solver using distributed dynamic scheduling
- 10.1016/j.parco.2007.12.001 may be a valid DOI for title: PT-Scotch: a tool for efficient parallel graph ordering
- 10.1137/s1064827595287997 may be a valid DOI for title: A fast and high quality multilevel scheme for partitioning irregular graphs
- 10.1007/978-3-540-78319-0_3 may be a valid DOI for title: Polynomial exact sequences and projection-based interpolation with application to Maxwell equations
- 10.1016/j.cma.2017.07.012 may be a valid DOI for title: Using a DPG method to validate DMA experimental calibration of viscoelastic materials
- 10.1016/j.camwa.2020.06.009 may be a valid DOI for title: MFEM: A modular finite element methods library
- 10.1109/5992.988653 may be a valid DOI for title: Zoltan data management services for parallel dynamic applications
- 10.1016/b978-012387582-2/50038-1 may be a valid DOI for title: Paraview: an end-user tool for large data visualization
- 10.1016/j.camwa.2015.04.027 may be a valid DOI for title: Orientation embedded high order shape functions for the exact sequence elements of all shapes
- 10.1016/j.camwa.2017.06.044 may be a valid DOI for title: An adaptive DPG method for high frequency time-harmonic wave propagation problems
- 10.1016/j.jcp.2017.07.051 may be a valid DOI for title: Coupled variational formulations of linear elasticity and the DPG methodology
- 10.1016/j.jcpx.2019.100002 may be a valid DOI for title: A 3D DPG Maxwell approach to nonlinear Raman gain in fiber laser amplifiers

INVALID DOIs

- None
editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 11 months ago

Hi @stefanhenneking, thanks for your submission. Unfortunately, we don't have an available editor in this area, so I have to put this on our waitlist until someone becomes available to handle it.

In the meantime, could you address the missing DOI messages in the paper? Also, any reviewer suggestions would be welcome.

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

MoFEM: An open source, parallel finite element library Submitting author: @likask Handling editor: @jedbrown (Active) Reviewers: @tjhei, @chrisrichardson, @Kevin-Mattheus-Moerman, @vijaysm, @chennachaos Similarity score: 0.8511

scikit-fem: A Python package for finite element assembly Submitting author: @kinnala Handling editor: @meg-simula (Retired) Reviewers: @thelfer, @AnjaliSandip Similarity score: 0.8450

libCEED: Fast algebra for high-order element-based discretizations Submitting author: @jedbrown Handling editor: @diehlpk (Active) Reviewers: @thelfer, @FreddieWitherden, Similarity score: 0.8398

GridapDistributed: a massively parallel finite element toolbox in Julia Submitting author: @amartinhuertas Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown Similarity score: 0.8396

OpenCMP: An Open-Source Computational Multiphysics Package Submitting author: @nasserma Handling editor: @lucydot (Active) Reviewers: @bonh, @WilkAndy Similarity score: 0.8368

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

stefanhenneking commented 11 months ago

Hi @kyleniemeyer, thank you for getting the pre-review started and for considering our paper at JOSS. Perhaps, @jedbrown is interested as an editor if available -- he'd suggested submitting to JOSS in the first place.

Yes, I will take care of the missing DOIs. For reviewers, are former contributors/collaborators of the software who are not co-authors of the paper eligible for reviewing?

stefanhenneking commented 11 months ago

@editorialbot commands

editorialbot commented 11 months ago

Hello @stefanhenneking, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
stefanhenneking commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

MoFEM: An open source, parallel finite element library Submitting author: @likask Handling editor: @jedbrown (Active) Reviewers: @tjhei, @chrisrichardson, @Kevin-Mattheus-Moerman, @vijaysm, @chennachaos Similarity score: 0.8550

scikit-fem: A Python package for finite element assembly Submitting author: @kinnala Handling editor: @meg-simula (Retired) Reviewers: @thelfer, @AnjaliSandip Similarity score: 0.8465

libCEED: Fast algebra for high-order element-based discretizations Submitting author: @jedbrown Handling editor: @diehlpk (Active) Reviewers: @thelfer, @FreddieWitherden, Similarity score: 0.8418

GridapDistributed: a massively parallel finite element toolbox in Julia Submitting author: @amartinhuertas Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown Similarity score: 0.8395

OpenCMP: An Open-Source Computational Multiphysics Package Submitting author: @nasserma Handling editor: @lucydot (Active) Reviewers: @bonh, @WilkAndy Similarity score: 0.8386

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

stefanhenneking commented 11 months ago

@editorialbot check references

editorialbot commented 11 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.camwa.2021.01.006 is OK
- 10.1016/j.camwa.2020.03.024 is OK
- 10.26153/tsw/13716 is OK
- 10.1007/978-3-031-20432-6_22 is OK
- 10.1016/j.camwa.2023.07.006 is OK
- 10.48550/arXiv.2309.00726 is OK
- 10.48550/arXiv.2207.12211 is OK
- 10.1201/9781420011692 is OK
- 10.1201/9781420011685 is OK
- 10.1016/j.camwa.2021.01.017 is OK
- 10.1137/s0895479899358194 is OK
- 10.1016/j.parco.2007.12.001 is OK
- 10.1137/s1064827595287997 is OK
- 10.1137/1.9781611977738 is OK
- 10.1007/978-3-540-78319-0_3 is OK
- 10.1016/0045-7825(89)90129-1 is OK
- 10.1016/0045-7825(89)90130-8 is OK
- 10.1016/0045-7825(89)90131-X is OK
- 10.1002/9781119176817.ecm2105 is OK
- 10.1016/j.cma.2017.07.012 is OK
- 10.1145/1268776.1268779 is OK
- 10.1016/j.camwa.2020.06.009 is OK
- 10.1109/5992.988653 is OK
- 10.1016/b978-012387582-2/50038-1 is OK
- 10.1016/j.camwa.2015.04.027 is OK
- 10.1016/j.camwa.2017.06.044 is OK
- 10.26153/tsw/2153 is OK
- 10.1016/j.jcp.2017.07.051 is OK
- 10.1016/j.jcpx.2019.100002 is OK

MISSING DOIs

- None

INVALID DOIs

- None
kyleniemeyer commented 10 months ago

@editorialbot invite @jedbrown as editor

Hey @jedbrown, could you edit this?

editorialbot commented 10 months ago

Invitation to edit this submission sent!

jedbrown commented 10 months ago

@editorialbot assign @jedbrown as editor

editorialbot commented 10 months ago

Assigned! @jedbrown is now the editor

jedbrown commented 10 months ago

@likask @jeremiah-corrado @peterrum @kinnala @amartinhuertas :wave: Hi, would any of you be available to review this submission for JOSS?

peterrum commented 10 months ago

@jedbrown Sure :+1:

likask commented 10 months ago

@jedbrown hi, I will be happy to do a review.

jedbrown commented 10 months ago

Wonderful, thanks!

jedbrown commented 10 months ago

@editorialbot add @peterrum as reviewer

editorialbot commented 10 months ago

@peterrum added to the reviewers list!

jedbrown commented 10 months ago

@editorialbot add @likask as reviewer

editorialbot commented 10 months ago

@likask added to the reviewers list!

jedbrown commented 10 months ago

@editorialbot start review

editorialbot commented 10 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5946.