openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: DynamicalSystems.jl: A Julia software library for chaos and nonlinear dynamics #594

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @Datseris (George Datserus) Repository: https://github.com/JuliaDynamics/DynamicalSystems.jl Version: v0.11.0 Editor: @kyleniemeyer Reviewer: @dhhagan

Author instructions

Thanks for submitting your paper to JOSS @Datseris. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@Datseris if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @kyleniemeyer it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
arfon commented 6 years ago

👋 @kyleniemeyer - the submitting author suggested you as the handling editor.

whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

Datseris commented 6 years ago

Great! PDF compilation and references work!

arfon commented 6 years ago

@Datseris - thanks for your submission. I note we had a (seemingly) related submission a while back in https://github.com/openjournals/joss-reviews/issues/458 . Could you explain the relationship between these?

Datseris commented 6 years ago

Both packages are part of the same GitHub organization, "JuliaDynamics" and I am the author of both of them.

As far as what they do, they are not related though. One is about 2-dimensional billiards, a quite special class of chaotic systems, while the one submitted here is about studying nonlinear dynamics and chaos.

Both packages certainly fall under the same field of science (Nonlinear Dynamics), but their underlying scope and code are very different.

Datseris commented 6 years ago

@ahwillia @mlxd have reviewed a previous submission of mine.

Both the reviewers and myself were pleased with how smoothly the review process went, so I am suggesting them for this submission as well.

ahwillia commented 6 years ago

I'm happy to review another submission! I'm busy for the next 2.5 weeks but I can do a review after that.

If you want a quicker turn around I'd suggest finding someone else...

On Feb 25, 2018 11:02 AM, "George Datseris" notifications@github.com wrote:

@ahwillia https://github.com/ahwillia @mlxd https://github.com/mlxd have reviewed a previous submission of mine.

Both the reviewers and myself were pleased with how smoothly the review process went, so I am suggesting them for this submission as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/594#issuecomment-368335001, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm20Y4wY6tkmjUzwWvtu_A8pdTy9U3Bks5tYa48gaJpZM4SST3l .

Datseris commented 6 years ago

I am not in any crazy hurry, but I can also suggest @Adrianzo @dhhagan @ygrange from the list of reviewers. Each one has some (maybe distant) connection with what the library offers.

kyleniemeyer commented 6 years ago

@ahwillia that timeline is fine, thanks!

@mlxd are you available to review as well?

dhhagan commented 6 years ago

I'm available if you need.

Datseris commented 6 years ago

Well, if I can have any say, then of course I'd prefer the faster start on the review :)

mlxd commented 6 years ago

I'm unavailable for about 2 more weeks so please go ahead if others are free to review.

kyleniemeyer commented 6 years ago

@dhhagan thanks for volunteering! We can get the review started with you, but I would also like to get some feedback from @ahwillia and/or @mlxd for a second set of eyes.

kyleniemeyer commented 6 years ago

@whedon assign @dhhagan as reviewer

whedon commented 6 years ago

OK, the reviewer is @dhhagan

kyleniemeyer commented 6 years ago

@whedon start review magic-word=bananas

whedon commented 6 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/598. Feel free to close this issue now!