[REVIEW]: GRDzhadzha: A code for evolving relativistic matter on analytic metric backgrounds

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@dinatraykova@warrickball<!--end-editor-- Reviewers: @rashti-alireza, @ekwessel Archive: 10.5281/zenodo.10839756

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/adcf79f964ea6c1126985118b90f06df"><img src="https://joss.theoj.org/papers/adcf79f964ea6c1126985118b90f06df/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/adcf79f964ea6c1126985118b90f06df/status.svg)](https://joss.theoj.org/papers/adcf79f964ea6c1126985118b90f06df)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rashti-alireza & @ekwessel, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @warrickball know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ekwessel

📝 Checklist for @rashti-alireza

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.103.104006 is OK
- 10.1088/1361-6382/ac6fa9 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1103/PhysRevD.103.083501 is OK
- 10.1103/PhysRevD.103.044059 is OK
- 10.1007/JHEP03(2022)111 is OK
- 10.1103/PhysRevX.11.021053 is OK
- 10.1088/1475-7516/2021/05/027 is OK
- 10.1088/1361-6382/abb693 is OK
- 10.1088/1361-6382/ab939b is OK
- 10.1088/1361-6382/aba28b is OK
- 10.1088/1475-7516/2020/05/030 is OK
- 10.1088/1475-7516/2020/01/027 is OK
- 10.1103/PhysRevD.105.063517 is OK
- 10.1103/PhysRevD.100.086014 is OK
- 10.1088/1475-7516/2019/07/044 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1103/PhysRevD.100.063014 is OK
- 10.1103/PhysRevD.99.064035 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.99.104028 is OK
- 10.1103/PhysRevD.98.083020 is OK
- 10.1088/1361-6382/aaf43e is OK
- 10.1088/1475-7516/2018/10/005 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.1103/PhysRevD.98.043004 is OK
- 10.1103/PhysRevD.99.044046 is OK
- 10.1088/1475-7516/2018/05/065 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1093/nsr/nwx116 is OK
- 10.1103/PhysRevLett.118.151103 is OK
- 10.48550/arXiv.1702.00786 is OK
- 10.1088/1475-7516/2017/03/055 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1088/1475-7516/2017/09/025 is OK
- 10.1103/PhysRevLett.116.061102 is OK
- 10.1103/PhysRevLett.116.071102 is OK
- 10.1088/0264-9381/33/3/035010 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.1088/0264-9381/32/7/074001 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1088/0264-9381/29/11/115001 is OK
- 10.1088/0264-9381/29/12/124007 is OK
- 10.1103/PhysRevD.85.064040 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.81.084052 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1088/0264-9381/24/12/S05 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.1103/PhysRevLett.96.111101 is OK
- 10.1103/PhysRevLett.96.111102 is OK
- 10.1088/0264-9381/22/17/025 is OK
- 10.1016/j.cpc.2006.02.002 is OK
- 10.1103/PhysRevD.70.064011 is OK
- 10.1088/0264-9381/21/6/014 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1103/PhysRevD.59.024007 is OK
- 10.1103/PhysRevD.52.5428 is OK
- 10.1143/PTPS.90.1 is OK
- 10.1016/0021-9991(84)90073-1 is OK
- 10.1109/21.120081 is OK
- 10.1002/andp.19163540702 is OK
- 10.1103/PhysRevD.89.104059 is OK
- 10.1088/1742-6596/610/1/012044 is OK
- 10.1088/1361-6382/ab0587 is OK
- 10.1088/0004-637X/774/1/48 is OK
- 10.21468/SciPostPhysCore.3.2.007 is OK
- 10.1007/s10714-008-0661-1 is OK
- 10.1103/PhysRevD.67.084023 is OK
- 10.1103/PhysRevD.104.103014 is OK
- 10.1103/PhysRevLett.129.151102 is OK
- 10.1098/rsta.2017.0122 is OK
- 10.1088/1475-7516/2015/03/007 is OK
- 10.1103/PhysRevD.107.024035 is OK
- 10.1103/PhysRevD.105.104055 is OK
- 10.1088/1361-6382/ac10ee is OK
- 10.1088/1361-6382/accc6a is OK
- 10.1145/3311790.3396656 is OK

MISSING DOIs

- No DOI given, and none found for title: Chombo software package for AMR applications - des...
- No DOI given, and none found for title: Kinematics and Dynamics of General Relativity
- No DOI given, and none found for title: Die Greensche Funktion der Schwingungslgleichung.
- No DOI given, and none found for title: Relativistic drag forces on black holes from scala...
- No DOI given, and none found for title: The Magnus Effect on black holes in scalar dark ma...
- No DOI given, and none found for title: The effect of wave dark matter on binary black hol...

INVALID DOIs

- None

warrickball commented 7 months ago

Two catches from the reference check:

It looks like Traykova et al. (2023) has been published, so you can update the reference, which should include a DOI.
You should change the in prep paper (Wang et al. 2023) to 2024.

I'm not worried about any of the other missing DOIs. (I couldn't obvious see that the paper with title "The effect of wave dark matter on binary black..." is cited anywhere, so you might fix that by dropping it from the BibTeX file.)

You can then proceed with the items in the Post-Review Checklist for Editor and Authors. In particular, you should create a tagged release and archive and upload it to an archiving service like Zenodo or Figshare, and post the version number and archive DOI here so I can attach them to our metadata.

You're welcome to do it however you like but when I once published in JOSS, I followed instructions like these to publish from GitHub to Zenodo. I've never tried Figshare but something similar looks possible.

dinatraykova commented 7 months ago

Right, thanks! Updated the references and going through the checklist now

dinatraykova commented 7 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Double check authors and affiliations (including ORCIDs)

Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.

Archive the release on Zenodo/figshare/etc and post the DOI here.

Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.

Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a pull request)

[x] Check that the archive title, author list, version tag, and the license are correct

[x] Set archive DOI with @editorialbot set <DOI here> as archive

[x] Set version with @editorialbot set <version here> as version

[x] Double check rendering of paper with @editorialbot generate pdf

[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed

[x] Recommend acceptance with @editorialbot recommend-accept

@warrickball I've gone through the checklist and archived the release, here's the doi for the archive https://doi.org/10.5281/zenodo.10839756

warrickball commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

warrickball commented 7 months ago

@editorialbot set https://doi.org/10.5281/zenodo.10839756 as archive

editorialbot commented 7 months ago

Done! archive is now 10.5281/zenodo.10839756

warrickball commented 7 months ago

@editorialbot set v1.0 as version

editorialbot commented 7 months ago

Done! version is now v1.0

warrickball commented 7 months ago

Hi @dinatraykova, I'm not sure if you noticed that I opened a PR with one last typo.

dinatraykova commented 7 months ago

Ah thanks @warrickball ! Just merged it :)

warrickball commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

warrickball commented 7 months ago

@editorialbot check references

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.103.104006 is OK
- 10.1088/1361-6382/ac6fa9 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1103/PhysRevD.103.083501 is OK
- 10.1103/PhysRevD.103.044059 is OK
- 10.1007/JHEP03(2022)111 is OK
- 10.1103/PhysRevX.11.021053 is OK
- 10.1088/1475-7516/2021/05/027 is OK
- 10.1088/1361-6382/abb693 is OK
- 10.1088/1361-6382/ab939b is OK
- 10.1088/1361-6382/aba28b is OK
- 10.1088/1475-7516/2020/05/030 is OK
- 10.1088/1475-7516/2020/01/027 is OK
- 10.1103/PhysRevD.105.063517 is OK
- 10.1103/PhysRevD.100.086014 is OK
- 10.1088/1475-7516/2019/07/044 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1103/PhysRevD.100.063014 is OK
- 10.1103/PhysRevD.99.064035 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.99.104028 is OK
- 10.1103/PhysRevD.98.083020 is OK
- 10.1088/1361-6382/aaf43e is OK
- 10.1088/1475-7516/2018/10/005 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.1103/PhysRevD.98.043004 is OK
- 10.1103/PhysRevD.99.044046 is OK
- 10.1088/1475-7516/2018/05/065 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1093/nsr/nwx116 is OK
- 10.1103/PhysRevLett.118.151103 is OK
- 10.48550/arXiv.1702.00786 is OK
- 10.1088/1475-7516/2017/03/055 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1088/1475-7516/2017/09/025 is OK
- 10.1103/PhysRevLett.116.061102 is OK
- 10.1103/PhysRevLett.116.071102 is OK
- 10.1088/0264-9381/33/3/035010 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.1088/0264-9381/32/7/074001 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1088/0264-9381/29/11/115001 is OK
- 10.1088/0264-9381/29/12/124007 is OK
- 10.1103/PhysRevD.85.064040 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.81.084052 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1088/0264-9381/24/12/S05 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.1103/PhysRevLett.96.111101 is OK
- 10.1103/PhysRevLett.96.111102 is OK
- 10.1088/0264-9381/22/17/025 is OK
- 10.1016/j.cpc.2006.02.002 is OK
- 10.1103/PhysRevD.70.064011 is OK
- 10.1088/0264-9381/21/6/014 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1103/PhysRevD.59.024007 is OK
- 10.1103/PhysRevD.52.5428 is OK
- 10.1143/PTPS.90.1 is OK
- 10.1016/0021-9991(84)90073-1 is OK
- 10.1109/21.120081 is OK
- 10.1002/andp.19163540702 is OK
- 10.1103/PhysRevD.89.104059 is OK
- 10.1088/1742-6596/610/1/012044 is OK
- 10.1088/1361-6382/ab0587 is OK
- 10.1088/0004-637X/774/1/48 is OK
- 10.21468/SciPostPhysCore.3.2.007 is OK
- 10.1007/s10714-008-0661-1 is OK
- 10.1103/PhysRevD.67.084023 is OK
- 10.1103/PhysRevD.104.103014 is OK
- 10.1103/PhysRevLett.129.151102 is OK
- 10.1098/rsta.2017.0122 is OK
- 10.1088/1475-7516/2015/03/007 is OK
- 10.1103/PhysRevD.108.L121502 is OK
- 10.1103/PhysRevD.107.024035 is OK
- 10.1103/PhysRevD.105.104055 is OK
- 10.1088/1361-6382/ac10ee is OK
- 10.1088/1361-6382/accc6a is OK
- 10.1145/3311790.3396656 is OK

MISSING DOIs

- No DOI given, and none found for title: Chombo software package for AMR applications - des...
- No DOI given, and none found for title: Kinematics and Dynamics of General Relativity
- No DOI given, and none found for title: Die Greensche Funktion der Schwingungslgleichung.
- No DOI given, and none found for title: Gravitational Magnus effect from scalar dark matte...
- No DOI given, and none found for title: The effect of wave dark matter on equal mass black...

INVALID DOIs

- None

warrickball commented 7 months ago

Hi again @dinatraykova, I have to sheepishly admit I introduced a syntax error in my fix (citations should be separated by ;, not ,) and opened a new PR to fix that. Apologies for slowing things down with this slip.

dinatraykova commented 7 months ago

@warrickball no worries, I should've also noticed! And thanks again :)

dinatraykova commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

warrickball commented 7 months ago

@editorialbot check references

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.103.104006 is OK
- 10.1088/1361-6382/ac6fa9 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1103/PhysRevD.103.083501 is OK
- 10.1103/PhysRevD.103.044059 is OK
- 10.1007/JHEP03(2022)111 is OK
- 10.1103/PhysRevX.11.021053 is OK
- 10.1088/1475-7516/2021/05/027 is OK
- 10.1088/1361-6382/abb693 is OK
- 10.1088/1361-6382/ab939b is OK
- 10.1088/1361-6382/aba28b is OK
- 10.1088/1475-7516/2020/05/030 is OK
- 10.1088/1475-7516/2020/01/027 is OK
- 10.1103/PhysRevD.105.063517 is OK
- 10.1103/PhysRevD.100.086014 is OK
- 10.1088/1475-7516/2019/07/044 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1103/PhysRevD.100.063014 is OK
- 10.1103/PhysRevD.99.064035 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.99.104028 is OK
- 10.1103/PhysRevD.98.083020 is OK
- 10.1088/1361-6382/aaf43e is OK
- 10.1088/1475-7516/2018/10/005 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.1103/PhysRevD.98.043004 is OK
- 10.1103/PhysRevD.99.044046 is OK
- 10.1088/1475-7516/2018/05/065 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1093/nsr/nwx116 is OK
- 10.1103/PhysRevLett.118.151103 is OK
- 10.48550/arXiv.1702.00786 is OK
- 10.1088/1475-7516/2017/03/055 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1088/1475-7516/2017/09/025 is OK
- 10.1103/PhysRevLett.116.061102 is OK
- 10.1103/PhysRevLett.116.071102 is OK
- 10.1088/0264-9381/33/3/035010 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.1088/0264-9381/32/7/074001 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1088/0264-9381/29/11/115001 is OK
- 10.1088/0264-9381/29/12/124007 is OK
- 10.1103/PhysRevD.85.064040 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.81.084052 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1088/0264-9381/24/12/S05 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.1103/PhysRevLett.96.111101 is OK
- 10.1103/PhysRevLett.96.111102 is OK
- 10.1088/0264-9381/22/17/025 is OK
- 10.1016/j.cpc.2006.02.002 is OK
- 10.1103/PhysRevD.70.064011 is OK
- 10.1088/0264-9381/21/6/014 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1103/PhysRevD.59.024007 is OK
- 10.1103/PhysRevD.52.5428 is OK
- 10.1143/PTPS.90.1 is OK
- 10.1016/0021-9991(84)90073-1 is OK
- 10.1109/21.120081 is OK
- 10.1002/andp.19163540702 is OK
- 10.1103/PhysRevD.89.104059 is OK
- 10.1088/1742-6596/610/1/012044 is OK
- 10.1088/1361-6382/ab0587 is OK
- 10.1088/0004-637X/774/1/48 is OK
- 10.21468/SciPostPhysCore.3.2.007 is OK
- 10.1007/s10714-008-0661-1 is OK
- 10.1103/PhysRevD.67.084023 is OK
- 10.1103/PhysRevD.104.103014 is OK
- 10.1103/PhysRevLett.129.151102 is OK
- 10.1098/rsta.2017.0122 is OK
- 10.1088/1475-7516/2015/03/007 is OK
- 10.1103/PhysRevD.108.L121502 is OK
- 10.1103/PhysRevD.107.024035 is OK
- 10.1103/PhysRevD.105.104055 is OK
- 10.1088/1361-6382/ac10ee is OK
- 10.1088/1361-6382/accc6a is OK
- 10.1145/3311790.3396656 is OK

MISSING DOIs

- No DOI given, and none found for title: Chombo software package for AMR applications - des...
- No DOI given, and none found for title: Kinematics and Dynamics of General Relativity
- No DOI given, and none found for title: Die Greensche Funktion der Schwingungslgleichung.
- No DOI given, and none found for title: Gravitational Magnus effect from scalar dark matte...
- No DOI given, and none found for title: The effect of wave dark matter on equal mass black...

INVALID DOIs

- None

warrickball commented 7 months ago

@editorialbot recommend-accept

editorialbot commented 7 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.103.104006 is OK
- 10.1088/1361-6382/ac6fa9 is OK
- 10.3847/1538-4365/ac157b is OK
- 10.1103/PhysRevD.103.083501 is OK
- 10.1103/PhysRevD.103.044059 is OK
- 10.1007/JHEP03(2022)111 is OK
- 10.1103/PhysRevX.11.021053 is OK
- 10.1088/1475-7516/2021/05/027 is OK
- 10.1088/1361-6382/abb693 is OK
- 10.1088/1361-6382/ab939b is OK
- 10.1088/1361-6382/aba28b is OK
- 10.1088/1475-7516/2020/05/030 is OK
- 10.1088/1475-7516/2020/01/027 is OK
- 10.1103/PhysRevD.105.063517 is OK
- 10.1103/PhysRevD.100.086014 is OK
- 10.1088/1475-7516/2019/07/044 is OK
- 10.1088/1475-7516/2020/01/007 is OK
- 10.1103/PhysRevD.100.063014 is OK
- 10.1103/PhysRevD.99.064035 is OK
- 10.1142/S0218271819500147 is OK
- 10.1103/PhysRevD.99.104028 is OK
- 10.1103/PhysRevD.98.083020 is OK
- 10.1088/1361-6382/aaf43e is OK
- 10.1088/1475-7516/2018/10/005 is OK
- 10.1088/1361-6382/aad7f6 is OK
- 10.1103/PhysRevD.98.043004 is OK
- 10.1103/PhysRevD.99.044046 is OK
- 10.1088/1475-7516/2018/05/065 is OK
- 10.1103/PhysRevD.97.064036 is OK
- 10.1093/nsr/nwx116 is OK
- 10.1103/PhysRevLett.118.151103 is OK
- 10.48550/arXiv.1702.00786 is OK
- 10.1088/1475-7516/2017/03/055 is OK
- 10.1016/j.jcp.2016.12.059 is OK
- 10.1088/1475-7516/2017/09/025 is OK
- 10.1103/PhysRevLett.116.061102 is OK
- 10.1103/PhysRevLett.116.071102 is OK
- 10.1088/0264-9381/33/3/035010 is OK
- 10.1103/PhysRevD.93.124059 is OK
- 10.1103/PhysRevD.93.063006 is OK
- 10.1088/0264-9381/32/24/245011 is OK
- 10.1088/0264-9381/32/7/074001 is OK
- 10.1103/PhysRevD.85.124010 is OK
- 10.1088/0264-9381/29/11/115001 is OK
- 10.1088/0264-9381/29/12/124007 is OK
- 10.1103/PhysRevD.85.064040 is OK
- 10.1103/PhysRevD.82.024005 is OK
- 10.1103/PhysRevD.81.084052 is OK
- 10.1142/9789812834300_0200 is OK
- 10.1088/0264-9381/24/12/S05 is OK
- 10.1103/PhysRevD.77.024027 is OK
- 10.1103/PhysRevD.76.104015 is OK
- 10.1103/PhysRevLett.96.111101 is OK
- 10.1103/PhysRevLett.96.111102 is OK
- 10.1088/0264-9381/22/17/025 is OK
- 10.1016/j.cpc.2006.02.002 is OK
- 10.1103/PhysRevD.70.064011 is OK
- 10.1088/0264-9381/21/6/014 is OK
- 10.1016/S0010-4655(02)00847-0 is OK
- 10.5281/zenodo.4734670 is OK
- 10.1103/PhysRevD.59.024007 is OK
- 10.1103/PhysRevD.52.5428 is OK
- 10.1143/PTPS.90.1 is OK
- 10.1016/0021-9991(84)90073-1 is OK
- 10.1109/21.120081 is OK
- 10.1002/andp.19163540702 is OK
- 10.1103/PhysRevD.89.104059 is OK
- 10.1088/1742-6596/610/1/012044 is OK
- 10.1088/1361-6382/ab0587 is OK
- 10.1088/0004-637X/774/1/48 is OK
- 10.21468/SciPostPhysCore.3.2.007 is OK
- 10.1007/s10714-008-0661-1 is OK
- 10.1103/PhysRevD.67.084023 is OK
- 10.1103/PhysRevD.104.103014 is OK
- 10.1103/PhysRevLett.129.151102 is OK
- 10.1098/rsta.2017.0122 is OK
- 10.1088/1475-7516/2015/03/007 is OK
- 10.1103/PhysRevD.108.L121502 is OK
- 10.1103/PhysRevD.107.024035 is OK
- 10.1103/PhysRevD.105.104055 is OK
- 10.1088/1361-6382/ac10ee is OK
- 10.1088/1361-6382/accc6a is OK
- 10.1145/3311790.3396656 is OK

MISSING DOIs

- No DOI given, and none found for title: Chombo software package for AMR applications - des...
- No DOI given, and none found for title: Kinematics and Dynamics of General Relativity
- No DOI given, and none found for title: Die Greensche Funktion der Schwingungslgleichung.
- No DOI given, and none found for title: Gravitational Magnus effect from scalar dark matte...
- No DOI given, and none found for title: The effect of wave dark matter on equal mass black...

INVALID DOIs

- None

editorialbot commented 7 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5226, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 7 months ago

@editorialbot accept

editorialbot commented 7 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 7 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Aurrekoetxea given-names: Josu C. orcid: "https://orcid.org/0000-0001-9584-5791" - family-names: Bamber given-names: Jamie orcid: "https://orcid.org/0000-0001-7181-3365" - family-names: Brady given-names: Sam E. orcid: "https://orcid.org/0009-0000-5568-839X" - family-names: Clough given-names: Katy orcid: "https://orcid.org/0000-0001-8841-1522" - family-names: Helfer given-names: Thomas orcid: "https://orcid.org/0000-0001-6880-1005" - family-names: Marsden given-names: James - family-names: Radia given-names: Miren orcid: "https://orcid.org/0000-0001-8861-2025" - family-names: Traykova given-names: Dina orcid: "https://orcid.org/0000-0002-3451-0987" - family-names: Wang given-names: Zipeng orcid: "https://orcid.org/0000-0002-4745-8209" doi: 10.5281/zenodo.10839756 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Aurrekoetxea given-names: Josu C. orcid: "https://orcid.org/0000-0001-9584-5791" - family-names: Bamber given-names: Jamie orcid: "https://orcid.org/0000-0001-7181-3365" - family-names: Brady given-names: Sam E. orcid: "https://orcid.org/0009-0000-5568-839X" - family-names: Clough given-names: Katy orcid: "https://orcid.org/0000-0001-8841-1522" - family-names: Helfer given-names: Thomas orcid: "https://orcid.org/0000-0001-6880-1005" - family-names: Marsden given-names: James - family-names: Radia given-names: Miren orcid: "https://orcid.org/0000-0001-8861-2025" - family-names: Traykova given-names: Dina orcid: "https://orcid.org/0000-0002-3451-0987" - family-names: Wang given-names: Zipeng orcid: "https://orcid.org/0000-0002-4745-8209" date-published: 2024-04-08 doi: 10.21105/joss.05956 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 5956 title: "GRDzhadzha: A code for evolving relativistic matter on analytic metric backgrounds" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05956" volume: 9 title: "GRDzhadzha: A code for evolving relativistic matter on analytic metric backgrounds" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 7 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 7 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5227
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05956
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 7 months ago

Many thanks to @rashti-alireza and @ekwessel for reviewing and to @warrickball for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@dinatraykova — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 7 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05956/status.svg)](https://doi.org/10.21105/joss.05956)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05956">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05956/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05956/status.svg
   :target: https://doi.org/10.21105/joss.05956

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews