openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: RainFA, a Jupyter Notebooks package for regional frequency analysis of rainfall data series #5963

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@pabloblancogomez<!--end-author-handle-- (Pablo Blanco Gómez) Repository: https://github.com/vielca/RainFA Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7da379cd4fd8d82cdf0d81122b14bedf"><img src="https://joss.theoj.org/papers/7da379cd4fd8d82cdf0d81122b14bedf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7da379cd4fd8d82cdf0d81122b14bedf/status.svg)](https://joss.theoj.org/papers/7da379cd4fd8d82cdf0d81122b14bedf)

Author instructions

Thanks for submitting your paper to JOSS @pabloblancogomez. Currently, there isn't a JOSS editor assigned to your paper.

@pabloblancogomez if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (436.9 files/s, 535952.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                 9              0          13856            512
TeX                              1             15              0            181
Markdown                         2             51              0            106
-------------------------------------------------------------------------------
SUM:                            12             66          13856            799
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1025

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jfr3.12453 is OK
- 10.1016/j.envsoft.2017.08.011 is OK
- 10.1016/S0022-1694(01)00520-0 is OK
- 10.1016/S0187-6236(14)70039-6 is OK
- 10.1016/j.envsoft.2016.11.005 is OK
- 10.1080/23311916.2015.1018704 is OK
- 10.1007/s11069-013-0775-y is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.7979740 is OK
- 10.21105/joss.01556 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1109/MCSE.2007.55 is OK

MISSING DOIs

- 10.25080/majora-92bf1922-011 may be a valid DOI for title: statsmodels: Econometric and statistical modeling with python

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

fathon: A Python package for a fast computation of detrendend fluctuation analysis and related algorithms Submitting author: @stfbnc Handling editor: @mbobra (Active) Reviewers: @ali-ramadhan, @ashwinvis Similarity score: 0.8113

flux-data-qaqc: A Python Package for Energy Balance Closure and Post-Processing of Eddy Flux Data Submitting author: @JohnVolk Handling editor: @pdebuyl (Active) Reviewers: @ashwinvis, @dgketchum Similarity score: 0.8025

Fruitbat: A Python Package for Estimating Redshifts of Fast Radio Bursts Submitting author: @abatten Handling editor: @xuanxu (Active) Reviewers: @zingale Similarity score: 0.7997

IPART: A Python Package for Image-Processing based Atmospheric River Tracking Submitting author: @Xunius Handling editor: @kbarnhart (Retired) Reviewers: @sadielbartholomew, @rabernat Similarity score: 0.7989

fishRman: A Shiny R Dashboard improving Global Fishing Watch data availability Submitting author: @Shyentist Handling editor: @KristinaRiemer (Retired) Reviewers: @jules32, @HeatherWelch Similarity score: 0.7979

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

pabloblancogomez commented 1 year ago

My reviewers suggestions are:

pabloblancogomez commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

fathon: A Python package for a fast computation of detrendend fluctuation analysis and related algorithms Submitting author: @stfbnc Handling editor: @mbobra (Active) Reviewers: @ali-ramadhan, @ashwinvis Similarity score: 0.8114

flux-data-qaqc: A Python Package for Energy Balance Closure and Post-Processing of Eddy Flux Data Submitting author: @JohnVolk Handling editor: @pdebuyl (Active) Reviewers: @ashwinvis, @dgketchum Similarity score: 0.8026

Fruitbat: A Python Package for Estimating Redshifts of Fast Radio Bursts Submitting author: @abatten Handling editor: @xuanxu (Active) Reviewers: @zingale Similarity score: 0.7998

IPART: A Python Package for Image-Processing based Atmospheric River Tracking Submitting author: @Xunius Handling editor: @kbarnhart (Retired) Reviewers: @sadielbartholomew, @rabernat Similarity score: 0.7990

fishRman: A Shiny R Dashboard improving Global Fishing Watch data availability Submitting author: @Shyentist Handling editor: @KristinaRiemer (Retired) Reviewers: @jules32, @HeatherWelch Similarity score: 0.7980

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 1 year ago

Hi @pabloblancogomez and thanks for your submission. In the future, please don't explicitly ping potential reviewers with "@" since it creates unnecessary noise for them — the editor would ping at the appropriate time.

I'm going to ask the greater editorial board to check out your submission for being in scope. Generally we find that notebook-based submissions do not come with proper documentation, installation steps, testing, nor are amenable to maintainable extension, in addition the number of lines of code is low. See more info here: https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort

This process will take 1-2 weeks.

kthyng commented 1 year ago

@editorialbot query scope

editorialbot commented 1 year ago

Submission flagged for editorial review.

pabloblancogomez commented 1 year ago

Hi @pabloblancogomez and thanks for your submission. In the future, please don't explicitly ping potential reviewers with "@" since it creates unnecessary noise for them — the editor would ping at the appropriate time.

I'm going to ask the greater editorial board to check out your submission for being in scope. Generally we find that notebook-based submissions do not come with proper documentation, installation steps, testing, nor are amenable to maintainable extension, in addition the number of lines of code is low. See more info here: https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort

This process will take 1-2 weeks.

-Dear @kthyng, sorry for the reviewers pinging, I understood the contrary. In terms of code length we already know from a previous manuscript the substancial scholarly effort and, despite having a code length a bit low (slightly above 600 lines), thought that it could result interesting, as it was already considered interesting in a national level congress about water science and engineering and the fact that the methodology has a version in R, but is not fully developed in Python. In this sense, many people in the congress was really interested in the implementation of the discordancy and homogeneity notebooks, as there is no version in Python available. Thanks for consulting the editorial board about the decision and hope that they could take these comments into consideration. Best regards, Pablo.

kthyng commented 1 year ago

Hi @pabloblancogomez unfortunately the editorial board has determined this to be out of scope, due to the items mentioned in my previous note. It sounds, however, like if you did expand this into a fully developed Python package, it may be in scope. As it is though, this is not what JOSS is aimed to do. Thank you.

kthyng commented 1 year ago

@editorialbot reject

editorialbot commented 1 year ago

Paper rejected.