openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[REVIEW]: gcamreport: An R tool to process and standardize GCAM outputs #5975

Closed editorialbot closed 4 months ago

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@klau506<!--end-author-handle-- (Clàudia Rodés-Bachs) Repository: https://github.com/bc3LC/gcamreport Branch with paper.md (empty if default branch): gcam-v7.0 Version: v7.0.1 Editor: !--editor-->@martinfleis<!--end-editor-- Reviewers: @bpbond, @ibarraespinosa Archive: 10.5281/zenodo.10960370

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/816fd8765945cd5f6fe6d8d1fefdde19"><img src="https://joss.theoj.org/papers/816fd8765945cd5f6fe6d8d1fefdde19/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/816fd8765945cd5f6fe6d8d1fefdde19/status.svg)](https://joss.theoj.org/papers/816fd8765945cd5f6fe6d8d1fefdde19)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@bpbond & @ibarraespinosa, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @martinfleis know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @ibarraespinosa

📝 Checklist for @bpbond

martinfleis commented 4 months ago

Thank you both, @bpbond and @ibarraespinosa!

martinfleis commented 4 months ago

@editorialbot generate pdf

martinfleis commented 4 months ago

@editorialbot check references

martinfleis commented 4 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance

editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8132290 is OK
- 10.5281/zenodo.7085661 is OK
- 10.1017/9781009157896 is OK
- 10.1017/9781009157940 is OK
- 10.1016/j.energy.2020.119153 is OK
- 10.1016/j.gloenvcha.2020.102191 is OK
- 10.1038/s41558-022-01349-x is OK
- 10.1038/nature08823 is OK
- 10.1007/s10584-013-0905-2 is OK
- 10.5281/zenodo.7956229 is OK
- 10.1038/s41597-020-0486-7 is OK
- 10.1038/sdata.2016.18 is OK
- 10.1017/9781009157926 is OK
- 10.1002/wcc.727 is OK
- 10.1038/nclimate3199 is OK
- 10.1038/s41558-021-01215-2 is OK
- 10.5194/gmd-12-677-2019 is OK
- 10.5194/gmd-15-2533-2022 is OK
- 10.1088/1748-9326/ac43df is OK
- 10.1073/pnas.1708290115 is OK
- 10.1145/2723872.2723882 is OK

MISSING DOIs

- No DOI given, and none found for title: IAMC Webinar: Standardization of scenario data col...
- No DOI given, and none found for title: Climate Change 2014: Impacts, Adaptation, and Vuln...
- No DOI given, and none found for title: Annex II: Metrics & Methodology

INVALID DOIs

- None
editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

martinfleis commented 4 months ago

Hi @klau506, please refer to the post-review checklist in the comment above for further author tasks. Thanks!

klau506 commented 4 months ago

Dear @martinfleis,

Thank you for all your work. I have checked all items on the post-review list and made a software release. The version number is v.7.0.1. It is available on Zenodo under this DOI: DOI. The list of authors and their ORCIDS has been checked in the manuscript and in the Zenodo archive. The license has been checked.

Best, Clàudia

martinfleis commented 4 months ago

@editorialbot set 10.5281/zenodo.10960370 as archive

editorialbot commented 4 months ago

Done! archive is now 10.5281/zenodo.10960370

martinfleis commented 4 months ago

@editorialbot set v7.0.1 as version

editorialbot commented 4 months ago

Done! version is now v7.0.1

martinfleis commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

martinfleis commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago
Attempting dry run of processing paper acceptance...
martinfleis commented 4 months ago

Thank you @klau506! I have now passed the submission to the editor in chief for the final checks.

editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8132290 is OK
- 10.5281/zenodo.7085661 is OK
- 10.1017/9781009157896 is OK
- 10.1017/9781009157940 is OK
- 10.1016/j.energy.2020.119153 is OK
- 10.1016/j.gloenvcha.2020.102191 is OK
- 10.1038/s41558-022-01349-x is OK
- 10.1038/nature08823 is OK
- 10.1007/s10584-013-0905-2 is OK
- 10.5281/zenodo.7956229 is OK
- 10.1038/s41597-020-0486-7 is OK
- 10.1038/sdata.2016.18 is OK
- 10.1017/9781009157926 is OK
- 10.1002/wcc.727 is OK
- 10.1038/nclimate3199 is OK
- 10.1038/s41558-021-01215-2 is OK
- 10.5194/gmd-12-677-2019 is OK
- 10.5194/gmd-15-2533-2022 is OK
- 10.1088/1748-9326/ac43df is OK
- 10.1073/pnas.1708290115 is OK
- 10.1145/2723872.2723882 is OK

MISSING DOIs

- No DOI given, and none found for title: IAMC Webinar: Standardization of scenario data col...
- No DOI given, and none found for title: Climate Change 2014: Impacts, Adaptation, and Vuln...
- No DOI given, and none found for title: Annex II: Metrics & Methodology

INVALID DOIs

- None
editorialbot commented 4 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5248, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 4 months ago

Hi! I will take over and my steps to wrap up are:

kthyng commented 4 months ago

@klau506 Your Zenodo archive metadata title doesn't match your JOSS paper title — can you update that?

kthyng commented 4 months ago

Also please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file.

klau506 commented 4 months ago

@kthyng Thank you so much for your checks. The Zenodo metadata title has been modified and all the capital letters in the bib file are now preserved.

Best, Clàudia

kthyng commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Rodés-Bachs given-names: Clàudia orcid: "https://orcid.org/0000-0001-6696-7685" - family-names: Sampedro given-names: Jon orcid: "https://orcid.org/0000-0002-2277-1530" - family-names: Horowitz given-names: Russell orcid: "https://orcid.org/0000-0002-0270-3127" - family-names: Ven given-names: Dirk-Jan Van name-particle: de orcid: "https://orcid.org/0000-0001-9120-564X" - family-names: Cui given-names: Ryna Yiyun orcid: "https://orcid.org/0000-0002-1186-8230" - family-names: Zhao given-names: Alicia orcid: "https://orcid.org/0000-0002-6054-8671" - family-names: Zwerling given-names: Matthew - family-names: Khan given-names: Zarrar orcid: "https://orcid.org/0000-0002-8147-8553" doi: 10.5281/zenodo.10960370 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Rodés-Bachs given-names: Clàudia orcid: "https://orcid.org/0000-0001-6696-7685" - family-names: Sampedro given-names: Jon orcid: "https://orcid.org/0000-0002-2277-1530" - family-names: Horowitz given-names: Russell orcid: "https://orcid.org/0000-0002-0270-3127" - family-names: Ven given-names: Dirk-Jan Van name-particle: de orcid: "https://orcid.org/0000-0001-9120-564X" - family-names: Cui given-names: Ryna Yiyun orcid: "https://orcid.org/0000-0002-1186-8230" - family-names: Zhao given-names: Alicia orcid: "https://orcid.org/0000-0002-6054-8671" - family-names: Zwerling given-names: Matthew - family-names: Khan given-names: Zarrar orcid: "https://orcid.org/0000-0002-8147-8553" date-published: 2024-04-22 doi: 10.21105/joss.05975 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 5975 title: "gcamreport: An R tool to process and standardize GCAM outputs" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05975" volume: 9 title: "gcamreport: An R tool to process and standardize GCAM outputs" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5262
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05975
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 4 months ago

Congrats on your new publication @klau506! Many thanks to editor @martinfleis and reviewers @bpbond and @ibarraespinosa for your time, hard work, and expertise!!

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05975/status.svg)](https://doi.org/10.21105/joss.05975)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05975">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05975/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05975/status.svg
   :target: https://doi.org/10.21105/joss.05975

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kthyng commented 4 months ago

@klau506 If you're interested in joining the reviewer database, please sign up at https://reviewers.joss.theoj.org/.

klau506 commented 4 months ago

Thank you @kthyng and @martinfleis for the edition work, and thank you @bpbond and @ibarraespinosa for your valuable comments!! Your expertise and attention to detail have undoubtedly enhanced the clarity, coherence, and scholarly rigor of the package and the manuscript! 🚀

Best, Clàudia