openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: PyTASER: Simulating transient absorption spectroscopy (TAS) for crystals from first principles #5985

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@savya10<!--end-author-handle-- (Savyasanchi Aggarwal) Repository: https://github.com/WMD-group/PyTASER Branch with paper.md (empty if default branch): paper Version: v2.2.0 Editor: !--editor-->@jgostick<!--end-editor-- Reviewers: @obaica, @JosePizarro3 Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931"><img src="https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931/status.svg)](https://joss.theoj.org/papers/dd7ab3c3c5f05568e19adc234fd5f931)

Author instructions

Thanks for submitting your paper to JOSS @savya10. Currently, there isn't a JOSS editor assigned to your paper.

@savya10 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=4.43 s (13.6 files/s, 94327.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             12              0              0         411553
Python                          10            393            422           2150
Jupyter Notebook                 3              0           1237            478
TeX                              1             17              0            241
YAML                             7             44             34            218
reStructuredText                 8            119            108            206
Markdown                         2             64              0            174
DOS Batch                        1              8              1             26
SVG                              1              0              1             16
JSON                            13              0              0             13
make                             1              4              7              9
TOML                             1              2              1              8
-------------------------------------------------------------------------------
SUM:                            60            651           1811         415092
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1720

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

Kevin-Mattheus-Moerman commented 1 year ago

@savya10 thanks for this submission. I am the AEiC on this track and here to help with initial steps.

It looks like your paper is not compiling because rather than just a newline on line 37, you have a "tab" "character". If you replace that line an actual empty line I think that might fix it. Can you update the paper? Once you have done that, you can call @editorialbot generate pdf here to retry the paper compilation.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @jgostick as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

savya10 commented 1 year ago

Thanks @Kevin-Mattheus-Moerman for the help! Have updated now.

savya10 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

Galore: Broadening and weighting for simulation of photoelectron spectroscopy Submitting author: @ajjackson Handling editor: @arfon (Active) Reviewers: @shyamd Similarity score: 0.8227

pyscal: A python module for structural analysis of atomic environments Submitting author: @srmnitc Handling editor: @melissawm (Retired) Reviewers: @lucydot, @bocklund Similarity score: 0.8204

sumo: Command-line tools for plotting and analysis of periodic ab initio calculations Submitting author: @utf Handling editor: @kyleniemeyer (Active) Reviewers: @jarvist, @cfgoldsmith Similarity score: 0.8165

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices Submitting author: @ljakoster Handling editor: @rkurchin (Active) Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie Similarity score: 0.8164

PiSCAT: A Python Package for Interferometric Scattering Microscopy Submitting author: @po60nani Handling editor: @emdupre (Active) Reviewers: @ziatdinovmax, @aquilesC Similarity score: 0.8135

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

savya10 commented 1 year ago

Here are some potential reviewers for this:

Pepe Marquez Gang Tang (obaica) Andrew S. Rosen

jgostick commented 1 year ago

@editorialbot assign @jgostick as editor

editorialbot commented 1 year ago

Assigned! @jgostick is now the editor

jgostick commented 1 year ago

@editorialbot add @obaica as reviewer

editorialbot commented 1 year ago

@obaica added to the reviewers list!

jgostick commented 1 year ago

@editorialbot add @JosePizarro3 as reviewer

editorialbot commented 1 year ago

@JosePizarro3 added to the reviewers list!

jgostick commented 1 year ago

@editorialbot begin review

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

jgostick commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5999.

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

Galore: Broadening and weighting for simulation of photoelectron spectroscopy Submitting author: @ajjackson Handling editor: @arfon (Active) Reviewers: @shyamd Similarity score: 0.8225

pyscal: A python module for structural analysis of atomic environments Submitting author: @srmnitc Handling editor: @melissawm (Retired) Reviewers: @lucydot, @bocklund Similarity score: 0.8221

sumo: Command-line tools for plotting and analysis of periodic ab initio calculations Submitting author: @utf Handling editor: @kyleniemeyer (Active) Reviewers: @jarvist, @cfgoldsmith Similarity score: 0.8185

PiSCAT: A Python Package for Interferometric Scattering Microscopy Submitting author: @po60nani Handling editor: @emdupre (Active) Reviewers: @ziatdinovmax, @aquilesC Similarity score: 0.8162

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices Submitting author: @ljakoster Handling editor: @rkurchin (Active) Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie Similarity score: 0.8161

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.