openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
719 stars 38 forks source link

[PRE REVIEW]: Fasten with Pipes #6000

Closed editorialbot closed 11 months ago

editorialbot commented 11 months ago

Submitting author: !--author-handle-->@lskatz<!--end-author-handle-- (Lee Katz) Repository: https://github.com/lskatz/fasten Branch with paper.md (empty if default branch): Version: v0.7.2 Editor: !--editor-->@kellyrowland<!--end-editor-- Reviewers: @telatin, @bovee Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d037275ee0bbfbb8c9678956c2a0d8aa"><img src="https://joss.theoj.org/papers/d037275ee0bbfbb8c9678956c2a0d8aa/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d037275ee0bbfbb8c9678956c2a0d8aa/status.svg)](https://joss.theoj.org/papers/d037275ee0bbfbb8c9678956c2a0d8aa)

Author instructions

Thanks for submitting your paper to JOSS @lskatz. Currently, there isn't a JOSS editor assigned to your paper.

@lskatz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 11 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 11 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=4.34 s (2861.6 files/s, 112808.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                         12087          18990              0         463736
Rust                            25            573           1200           2589
JavaScript                     263              0              2           1210
Bourne Shell                    31            228             63            720
Markdown                         4             78              0            239
YAML                             4             18             17            152
TOML                             1             22              3             86
TeX                              1              4              0             37
SVG                              7              0              0             30
Dockerfile                       1              9              1             28
CSS                              7              0              1              7
-------------------------------------------------------------------------------
SUM:                         12431          19922           1287         468834
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 11 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0163962 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 11 months ago

Wordcount for paper.md is 535

editorialbot commented 11 months ago

Failed to discover a Statement of need section in paper

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

Nanoq: ultra-fast quality control for nanopore reads Submitting author: @esteinig Handling editor: @luizirber (Active) Reviewers: @natir, @bovee Similarity score: 0.8302

RNAsik: A Pipeline for complete and reproducible RNA-seq analysis that runs anywhere with speed and ease Submitting author: @serine Handling editor: @pjotrp (Retired) Reviewers: @andrewyatz Similarity score: 0.8274

RAILS and Cobbler: Scaffolding and automated finishing of draft genomes using long DNA sequences Submitting author: @warrenlr Handling editor: @biorelated (Retired) Reviewers: @andrewjpage Similarity score: 0.8273

MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis Submitting author: @ParkvilleData Handling editor: @jmschrei (Active) Reviewers: @Ebedthan, @rjorton Similarity score: 0.8261

SneakerNet: A modular quality assurance and quality check workflow for primary genomic and metagenomic read data Submitting author: @lskatz Handling editor: @lpantano (Active) Reviewers: @lfaller, @erinyoung, @druvus Similarity score: 0.8138

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

Kevin-Mattheus-Moerman commented 11 months ago

@lskatz thanks for this submission. I am the AEiC for this track, and here to help process the initial steps. For the moment please address the below in order for your submission to be considered for JOSS:

lskatz commented 11 months ago

Thank you for helping me on these points. For the resolution of the figure, would it help to separate it into 9 figures? When I combine them into a single image, I think my program is compressing the resolution. Or would having 9 figures make the manuscript too verbose?

Kevin-Mattheus-Moerman commented 11 months ago

@lskatz I think a single merged figure is best. It may work if you simply have them nearly touching, so to remove the white space between them, and to then use the full page width. You also should be able to turn of compression for the software you are using. Anyway, give it a go and we'll look when you have the new draft.

lskatz commented 11 months ago

@Kevin-Mattheus-Moerman This looks much better with your suggestions. I have addressed all five of your points hopefully to your approval.

lskatz commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

RAILS and Cobbler: Scaffolding and automated finishing of draft genomes using long DNA sequences Submitting author: @warrenlr Handling editor: @biorelated (Retired) Reviewers: @andrewjpage Similarity score: 0.8148

A reproducible Snakemake pipeline to analyse Illumina paired-end data from ChiP-Seq experiments Submitting author: @mgalland Handling editor: @brainstorm (Retired) Reviewers: @vladsaveliev Similarity score: 0.8130

Finch: a tool adding dynamic abundance filtering to genomic MinHashing Submitting author: @bovee Handling editor: @biorelated (Retired) Reviewers: @HadrienG Similarity score: 0.8073

SneakerNet: A modular quality assurance and quality check workflow for primary genomic and metagenomic read data Submitting author: @lskatz Handling editor: @lpantano (Active) Reviewers: @lfaller, @erinyoung, @druvus Similarity score: 0.8040

fqfa: A pure Python package for genomic sequence files Submitting author: @afrubin Handling editor: @lpantano (Active) Reviewers: @natir, @FlorianThibord Similarity score: 0.8029

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

Kevin-Mattheus-Moerman commented 11 months ago

@lskatz this looks better indeed. Below is some more feedback for you before we proceed.

I will start looking for a handling editor but please consider the above.

Kevin-Mattheus-Moerman commented 11 months ago

@editorialbot invite @kellyrowland as editor

editorialbot commented 11 months ago

Invitation to edit this submission sent!

lskatz commented 11 months ago

Thank you! Your comments have made the manuscript better. I updated the manuscript's headers, and added onto the testing/benchmarking/documentation section, and added in the markdown files to guide in contributions.

Separately, I have separately asked @telatin if he would like to review this paper and he seems interested, and so I would like to put him forward as a possible reviewer.

lskatz commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 11 months ago

Five most similar historical JOSS papers:

RAILS and Cobbler: Scaffolding and automated finishing of draft genomes using long DNA sequences Submitting author: @warrenlr Handling editor: @biorelated (Retired) Reviewers: @andrewjpage Similarity score: 0.8111

A reproducible Snakemake pipeline to analyse Illumina paired-end data from ChiP-Seq experiments Submitting author: @mgalland Handling editor: @brainstorm (Retired) Reviewers: @vladsaveliev Similarity score: 0.8097

Finch: a tool adding dynamic abundance filtering to genomic MinHashing Submitting author: @bovee Handling editor: @biorelated (Retired) Reviewers: @HadrienG Similarity score: 0.8077

CheckQC: Quick quality control of Illumina sequencing runs Submitting author: @johandahlberg Handling editor: @pjotrp (Retired) Reviewers: @brainstorm Similarity score: 0.8000

SneakerNet: A modular quality assurance and quality check workflow for primary genomic and metagenomic read data Submitting author: @lskatz Handling editor: @lpantano (Active) Reviewers: @lfaller, @erinyoung, @druvus Similarity score: 0.8000

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

lskatz commented 11 months ago

I think some potential reviewers could include

Not all of them are on the list of self-volunteering reviewers however.

kellyrowland commented 11 months ago

I can take this on, sure. @lskatz thanks for the list of reviewers; I'll ping a few folks once I'm assigned as editor.

Kevin-Mattheus-Moerman commented 11 months ago

@editorialbot assign @kellyrowland as editor

editorialbot commented 11 months ago

Assigned! @kellyrowland is now the editor

kellyrowland commented 11 months ago

hi @telatin @bovee 👋 would you be interested and available for reviewing this JOSS submission?

telatin commented 11 months ago

Sure :)

kellyrowland commented 11 months ago

@editorialbot add @telatin as reviewer

editorialbot commented 11 months ago

@telatin added to the reviewers list!

kellyrowland commented 11 months ago

thanks @telatin ! once we have a second reviewer lined up I'll start the review.

bovee commented 11 months ago

Hi, I'd be happy to review.

kellyrowland commented 11 months ago

great, thanks!

kellyrowland commented 11 months ago

@editorialbot add @bovee as reviewer

editorialbot commented 11 months ago

@bovee added to the reviewers list!

kellyrowland commented 11 months ago

@editorialbot start review

editorialbot commented 11 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6030.