openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: mei-friend: An Interactive Web-based Editor for Digital Music Encodings #6002

Closed editorialbot closed 5 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@wergo<!--end-author-handle-- (Werner Goebl) Repository: https://github.com/mei-friend/mei-friend Branch with paper.md (empty if default branch): joss2023 Version: v1.0.14 Editor: !--editor-->@faroit<!--end-editor-- Reviewers: @stefan-balke, @rlskoeser Archive: 10.5281/zenodo.11262560

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/adf29c04baef5af968fd9308cb172f57"><img src="https://joss.theoj.org/papers/adf29c04baef5af968fd9308cb172f57/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/adf29c04baef5af968fd9308cb172f57/status.svg)](https://joss.theoj.org/papers/adf29c04baef5af968fd9308cb172f57)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@stefan-balke & @rlskoeser, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @stefan-balke

šŸ“ Checklist for @rlskoeser

wergo commented 6 months ago

We have checked all missing DOIs. They are either bib items not referenced by the paper or legitimately do not have DOIs. We have added a URL for Geertinger, 2021 (Digital Encoding of Music Notation with MEI).

wergo commented 6 months ago

Dear @faroit,

we have now released mei-friend version 1.0.14 and mirrored this release on Zenodo under https://doi.org/10.5281/zenodo.11262560. We have made sure that all bullet points of the post-review checklist are implemented.

We have merged the spell-check pull request you raised (many thanks for the thorough proof reading!) and updated the reference list with a missing URL (as described above).

We hope that the project and the paper are now ready for publication. Please let us know if we missed something or more things are needed.

Many thanks for all your work, @wergo & @musicog

faroit commented 6 months ago

@editorialbot set v1.0.14 as version

editorialbot commented 6 months ago

Done! version is now v1.0.14

faroit commented 6 months ago

@editorialbot set 10.5281/zenodo.11262560 as archive

editorialbot commented 6 months ago

Done! archive is now 10.5281/zenodo.11262560

faroit commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago
Attempting dry run of processing paper acceptance...
faroit commented 6 months ago

@wergo looks all good from my side

editorialbot commented 6 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5397, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 5 months ago

@editorialbot accept

editorialbot commented 5 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 5 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Goebl given-names: Werner orcid: "https://orcid.org/0000-0002-1722-0718" - family-names: Weigl given-names: David M. orcid: "https://orcid.org/0000-0003-1502-1528" contact: - family-names: Goebl given-names: Werner orcid: "https://orcid.org/0000-0002-1722-0718" doi: 10.5281/zenodo.11262560 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Goebl given-names: Werner orcid: "https://orcid.org/0000-0002-1722-0718" - family-names: Weigl given-names: David M. orcid: "https://orcid.org/0000-0003-1502-1528" date-published: 2024-06-11 doi: 10.21105/joss.06002 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6002 title: "mei-friend: An Interactive Web-based Editor for Digital Music Encodings" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06002" volume: 9 title: "mei-friend: An Interactive Web-based Editor for Digital Music Encodings" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 5 months ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 5 months ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5476
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06002
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

arfon commented 5 months ago

@stefan-balke, @rlskoeser ā€“ many thanks for your reviews here and to @faroit for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you āœØ

@wergo ā€“ your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 5 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06002/status.svg)](https://doi.org/10.21105/joss.06002)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06002">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06002/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06002/status.svg
   :target: https://doi.org/10.21105/joss.06002

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: