[PRE REVIEW]: Pysewer: A Python Library for Sewer Network Generation in Data Scarce Regions

[editorialbot]

Submitting author: !--author-handle-->@dbdespot<!--end-author-handle-- (Daneish Despot) Repository: https://git.ufz.de/despot/pysewer/ Branch with paper.md (empty if default branch): Version: v0.1.14 Editor: !--editor-->@olexandr-konovalov<!--end-editor-- Reviewers: @meghnathomas, @simoninireland Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1723c806b1d23252d4642a6c1b75bb9c"><img src="https://joss.theoj.org/papers/1723c806b1d23252d4642a6c1b75bb9c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1723c806b1d23252d4642a6c1b75bb9c/status.svg)](https://joss.theoj.org/papers/1723c806b1d23252d4642a6c1b75bb9c)

Author instructions

Thanks for submitting your paper to JOSS @dbdespot. Currently, there isn't a JOSS editor assigned to your paper.

@dbdespot if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (753.3 files/s, 218133.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            18           1021             54           6984
TeX                             26           1021           2445           6578
SVG                              1              0              0           2671
Python                          16            531           1254           1710
JavaScript                      12            131            221            880
CSS                              4            190             35            779
XML                              8              0              0            708
Markdown                         4            146              0            338
Jupyter Notebook                 2              0           2852            189
YAML                             5             20             12            157
reStructuredText                 6             61             69             64
make                             2             22             12             50
DOS Batch                        3             17              2             49
Bourne Shell                     1              0              0              1
-------------------------------------------------------------------------------
SUM:                           108           3160           6956          21158
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1967

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.3946761 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5281/zenodo.5884351 is OK
- 10.3389/fenvs.2021.626634 is OK
- 10.2166/wst.2015.393 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

VisWaterNet: A Python package for visualization of water distribution networks Submitting author: @meghnathomas Handling editor: @crvernon (Active) Reviewers: @erexer, @thurber Similarity score: 0.8282

RivGraph: Automatic extraction and analysis of river and delta channel network topology Submitting author: @jonschwenk Handling editor: @kbarnhart (Retired) Reviewers: @eriknes, @leotrs Similarity score: 0.8120

ur-scape: harnessing data for stakeholder participation in city-making processes Submitting author: @luyuhao0326 Handling editor: @hugoledoux (Active) Reviewers: @winstonyym, @cforgaci Similarity score: 0.8120

NetworkSedimentTransporter: A Landlab component for bed material transport through river networks Submitting author: @pfeiffea Handling editor: @kthyng (Active) Reviewers: @zsylvester, @ebgoldstein Similarity score: 0.8101

Water Systems Integrated Modelling framework, WSIMOD: A Python package for integrated modelling of water quality and quantity across the water cycle Submitting author: @barneydobson Handling editor: @crvernon (Active) Reviewers: @cheginit, @jlarsen-usgs Similarity score: 0.8098

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

Hi @dbdespot and thanks for your submission. I am going to ping the editorial board to take a look to see if the submission passes our substantial scholarly effort definition. It's ok for lines of code but the development history is quite short! We'll be back to you in a few weeks. Thanks.

[kthyng]

@editorialbot query scope

[editorialbot]

Submission flagged for editorial review.

[ddspot]

Hi @dbdespot and thanks for your submission. I am going to ping the editorial board to take a look to see if the submission passes our substantial scholarly effort definition. It's ok for lines of code but the development history is quite short! We'll be back to you in a few weeks. Thanks.

Hi @kthyng, thanks for the status update. The reason for the development history being so short is that we recently migrated to a new repository to prepare for the submission. I guess the way we migrated the project removed the original history. My apologies for that.

[kthyng]

@ddspot ok, that happens a lot. This is a high level (and imperfect) check we do — approximately how long has development been going on?

[ddspot]

@ddspot ok, that happens a lot. This is a high level (and imperfect) check we do — approximately how long has development been going on?

@kthyng, the development has been going on for 3 years now where the library we submitted was used to support a couple of our studies.

[kthyng]

@ddspot Ok my apologies, I should have asked first. Everything else looks in order so I'll remove that query. Next though I'll need to add you to our waitlist as we wait for a relevant editor to become available. Thank you!

[kthyng]

Hi @olexandr-konovalov! We aren't usually in the same track for JOSS but I wonder if you might edit this submission from the graph theory/network analysis side. What do you think?

[kthyng]

@editorialbot invite @olexandr-konovalov as editor

[editorialbot]

Invitation to edit this submission sent!

[olexandr-konovalov]

@kthyng thank you, had a look - happy to take it!

[kthyng]

@editorialbot add @olexandr-konovalov as editor

[editorialbot]

Assigned! @olexandr-konovalov is now the editor

[kthyng]

thanks @olexandr-konovalov!

[olexandr-konovalov]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

VisWaterNet: A Python package for visualization of water distribution networks Submitting author: @meghnathomas Handling editor: @crvernon (Active) Reviewers: @erexer, @thurber Similarity score: 0.8245

ur-scape: harnessing data for stakeholder participation in city-making processes Submitting author: @luyuhao0326 Handling editor: @hugoledoux (Active) Reviewers: @winstonyym, @cforgaci Similarity score: 0.8117

RivGraph: Automatic extraction and analysis of river and delta channel network topology Submitting author: @jonschwenk Handling editor: @kbarnhart (Retired) Reviewers: @eriknes, @leotrs Similarity score: 0.8092

NetworkSedimentTransporter: A Landlab component for bed material transport through river networks Submitting author: @pfeiffea Handling editor: @kthyng (Active) Reviewers: @zsylvester, @ebgoldstein Similarity score: 0.8090

Water Systems Integrated Modelling framework, WSIMOD: A Python package for integrated modelling of water quality and quantity across the water cycle Submitting author: @barneydobson Handling editor: @crvernon (Active) Reviewers: @cheginit, @jlarsen-usgs Similarity score: 0.8069

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[olexandr-konovalov]

@kthyng I keep this in my TODO list - hope to get progress in finding reviewers in February. Sorry for the delay.

[kthyng]

@olexandr-konovalov Ok sounds good. You might check out the authors from those five papers listed above — they might be good options.

[olexandr-konovalov]

@meghnathomas @simoninireland would one or both of you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

[meghnathomas]

@olexandr-konovalov yes I am happy to!

[olexandr-konovalov]

@meghnathomas thank you - we will start the review as soon as we will find the 2nd reviewer.

[simoninireland]

I will hopefully do this review next week.

[olexandr-konovalov]

@editorialbot add @meghnathomas as reviewer

[editorialbot]

@meghnathomas added to the reviewers list!

[olexandr-konovalov]

@editorialbot add @simoninireland as reviewer

[editorialbot]

@simoninireland added to the reviewers list!

[olexandr-konovalov]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6430.

[olexandr-konovalov]

Many thanks @meghnathomas and @simoninireland! Now the review starts at #6430, and all further conversations will take place there. Please see #6430 for the instructions for the reviewers and other details.

[olexandr-konovalov]

@barneydobson @jonschwenk I am looking for the 2nd reviewer for this JOSS paper (the review has already started in #6430, but one of the reviewers asked to be replaced). Would one of you be interested and able to review it?

[barneydobson]

@olexandr-konovalov sorry for the delay - I have been on leave. I have a lot to catch up on at the moment. I'm happy to review this but it wouldn't be until late September/early October (which I think is beyond the typical JOSS review time)

[olexandr-konovalov]

@barneydobson thanks for your response! Actually, I don't have anyone else agreeing to be the 2nd reviewer it at the moment, and I will be quite happy to wait for your to look at it, if late September/early October is still realistic timeline. Having a look at https://imperialcollegelondon.github.io/wsi/, your expertise would be really appreciated here.

[barneydobson]

I'll schedule it in!

[dbdespot]

@olexandr-konovalov @barneydobson, thank you for your efforts in continuing the review.

[olexandr-konovalov]

@barneydobson thank you! I have invited you as reviewer - all further communication happens in https://github.com/openjournals/joss-reviews/issues/6430. Please see instructions there how to generate your review checklist etc.