[PRE REVIEW]: AHGestimation: An R package for Computing robust, mass preserving Hydraulic Geometries and Rating Curves

editorialbot commented 12 months ago

Submitting author: !--author-handle-->@mikejohnson51@crvernon<!--end-editor-- Reviewers: @mabesa, @mengqi-z Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b"><img src="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg)](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b)

Author instructions

Thanks for submitting your paper to JOSS @mikejohnson51. Currently, there isn't a JOSS editor assigned to your paper.

@mikejohnson51 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 12 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 12 months ago

Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (853.8 files/s, 262363.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      11           2613           2665          10087
HTML                            35           1447            114           5287
R                               11            264            185            802
Rmd                              6            295            414            595
CSS                              8            106             82            463
Markdown                         4             96              0            312
TeX                              1              0              0            207
YAML                             6             31              4            165
XML                              1              0              0            105
Sass                             1              4              0             71
SVG                              1              0              1             11
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            86           4856           3465          18106
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

editorialbot commented 12 months ago

Wordcount for paper.md is 1422

editorialbot commented 12 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.5194/hess-26-6121-2022 is OK

MISSING DOIs

- 10.3133/pp252 may be a valid DOI for title: The hydraulic geometry of stream channels and some physiographic implications
- 10.1002/aaai.12035 may be a valid DOI for title: Knowledge graphs to support real-time flood impact evaluation
- 10.1016/j.jhydrol.2018.07.020 may be a valid DOI for title: Field verification of analytical at-a-station hydraulic-geometry relations
- 10.1111/1752-1688.12661 may be a valid DOI for title: River channel geometry and rating curve estimation using height above the nearest drainage
- 10.20944/preprints202212.0390.v1 may be a valid DOI for title: Determining Feature Based Hydraulic Geometry and Rating Curves using a Physically Based, Computationally Efficient Framework
- 10.1016/j.envsoft.2020.104927 may be a valid DOI for title: Mainstems: A logical data model implementing mainstem and drainage basin feature types based on WaterML2 Part 3: HY Features concepts
- 10.22541/essoar.167415214.45806648/v1 may be a valid DOI for title: Comprehensive analysis of the NOAA National Water Model: A call for heterogeneous formulations and diagnostic model selection
- 10.1016/j.jhydrol.2017.01.038 may be a valid DOI for title: Statistical filtering of river survey and streamflow data for improving At-A-Station hydraulic geometry relations
- 10.1111/jawr.12282 may be a valid DOI for title: Development and evaluation of bankfull hydraulic geometry relationships for the physiographic regions of the United States
- 10.1111/1752-1688.12460 may be a valid DOI for title: Development and comparison of multiple regression models to predict bankfull channel dimensions for use in hydrologic models

INVALID DOIs

- None

editorialbot commented 12 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 12 months ago

Hi @mikejohnson51 and thanks for your submission. Since the lines of code is on the small side (looking at the R code, being < 1000), I will ping the editorial board to take a look and see if this is in scope for substantial scholarly effort. This will take a few weeks, thanks for your patience.

kthyng commented 12 months ago

@editorialbot query scope

editorialbot commented 12 months ago

Submission flagged for editorial review.

editorialbot commented 12 months ago

Five most similar historical JOSS papers:

morphMan: Automated manipulation of vascular geometries Submitting author: @aslakbergersen Handling editor: @trallard (Retired) Reviewers: @brainstorm, @rlizzo Similarity score: 0.8110

rigr: Regression, Inference, and General Data Analysis Tools in R Submitting author: @yiqunchen Handling editor: @osorensen (Active) Reviewers: @stefanocoretta, @tomsing1 Similarity score: 0.8092

riversCentralAsia: An R package to support data pre- and postprocessing for hydrological modelling with RS MINERVE Submitting author: @mabesa Handling editor: @crvernon (Active) Reviewers: @mengqi-z, @tonyewong Similarity score: 0.8063

tidyhydat: Extract and Tidy Canadian Hydrometric Data Submitting author: @boshek Handling editor: @arfon (Active) Reviewers: @arfon Similarity score: 0.8047

The hhi Package: Streamlined Calculation and Visualization of Herfindahl-Hirschman Index Scores Submitting author: @pdwaggoner Handling editor: @leeper (Retired) Reviewers: @cskovron Similarity score: 0.8031

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 11 months ago

Hi @mikejohnson51 and thanks for your patience. This submission has been difficult to query for scope because it is borderline with votes both up and down. What has put me over the edge to send this to review is that it has been and seems to be continued to use in the community, which is one of the items we look for in deciding whether a submission is in scope. It is possible this will come up again during the review process in which case typically the reviewer opinion takes precedence, but we'll see what happens.

kthyng commented 11 months ago

@editorialbot invite @crvernon as editor

editorialbot commented 11 months ago

Invitation to edit this submission sent!

kthyng commented 11 months ago

@crvernon Would you be interested in editing this submission?