openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: Catalyst: a Python JIT compiler for auto-differentiable hybrid quantum programs #6012

Closed editorialbot closed 6 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@josh146<!--end-author-handle-- (Joshua Izaac) Repository: https://github.com/PennyLaneAI/catalyst Branch with paper.md (empty if default branch): joss-paper Version: v0.3.1 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @pmcao, @otbrown Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee"><img src="https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee/status.svg)](https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee)

Author instructions

Thanks for submitting your paper to JOSS @josh146. Currently, there isn't a JOSS editor assigned to your paper.

@josh146 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.31 s (1051.1 files/s, 205991.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          92           5928           4939          15988
C++                             69           3456           1755          13053
C/C++ Header                    51            949           1393           3133
reStructuredText                19           1171           1522           1826
YAML                            20            227             40           1556
Markdown                         8            494              0           1392
CMake                           38            152             46            674
Jupyter Notebook                 4              0           2203            598
make                             5             74             11            379
TeX                              2             83              4            321
LLVM IR                          3             93             64            177
JSON                             3              0              0            118
SVG                              6              0              0             85
Dockerfile                       2             18             11             38
TOML                             1              6              0             34
Bourne Shell                     2              9              0             30
HTML                             1              6              0             27
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           327          12666          11988          39432
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1395

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.6385575 is OK
- 10.1088/1367-2630/18/2/023023 is OK
- 10.1109/CGO51591.2021.9370308 is OK
- 10.22331/q-2022-03-30-677 is OK

MISSING DOIs

- 10.1103/physreva.104.052402 may be a valid DOI for title: Variational quantum algorithm for molecular geometry optimization
- 10.1103/physreva.99.032331 may be a valid DOI for title: Evaluating analytic gradients on quantum hardware

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

Flux: Elegant machine learning with Julia Submitting author: @MikeInnes Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @ysimillides Similarity score: 0.7871

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations Submitting author: @ml-evs Handling editor: @jgostick (Active) Reviewers: @mkhorton, @srmnitc Similarity score: 0.7868

WEdiff: A Python and C++ package for automatic differentiation Submitting author: @ctdegroot Handling editor: @arfon (Active) Reviewers: @highlando, @kyleniemeyer Similarity score: 0.7866

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.7828

ChemPy: A package useful for chemistry written in Python Submitting author: @bjodah Handling editor: @kyleniemeyer (Active) Reviewers: @bryanwweber Similarity score: 0.7823

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

@josh146 - thanks for your submission. I'll look for an editor next.

While I do so, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Also, please proofread how the references look in the pdf. I see at least one where the authors are not formatted correctly, which can be fixed by protecting a string in the .bib file using {}s.

danielskatz commented 1 year ago

πŸ‘‹ @jarvist - Are you able to edit this submission?

danielskatz commented 1 year ago

@editorialbot invite @jarvist as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

josh146 commented 1 year ago

Thanks @danielskatz! I'll update the DOIs now.

josh146 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.6385575 is OK
- 10.1088/1367-2630/18/2/023023 is OK
- 10.1103/physreva.104.052402 is OK
- 10.1109/CGO51591.2021.9370308 is OK
- 10.22331/q-2022-03-30-677 is OK
- 10.1103/physreva.99.032331 is OK

MISSING DOIs

- None

INVALID DOIs

- None
josh146 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

Flux: Elegant machine learning with Julia Submitting author: @MikeInnes Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @ysimillides Similarity score: 0.7871

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations Submitting author: @ml-evs Handling editor: @jgostick (Active) Reviewers: @mkhorton, @srmnitc Similarity score: 0.7868

WEdiff: A Python and C++ package for automatic differentiation Submitting author: @ctdegroot Handling editor: @arfon (Active) Reviewers: @highlando, @kyleniemeyer Similarity score: 0.7866

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.7828

ChemPy: A package useful for chemistry written in Python Submitting author: @bjodah Handling editor: @kyleniemeyer (Active) Reviewers: @bryanwweber Similarity score: 0.7823

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

Thanks @josh146 - there's still this one...

Screenshot 2023-11-02 at 11 38 32

but otherwise, this looks good now.

josh146 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.6385575 is OK
- 10.1088/1367-2630/18/2/023023 is OK
- 10.1103/physreva.104.052402 is OK
- 10.1109/CGO51591.2021.9370308 is OK
- 10.22331/q-2022-03-30-677 is OK
- 10.1103/physreva.99.032331 is OK

MISSING DOIs

- None

INVALID DOIs

- None
josh146 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations Submitting author: @ml-evs Handling editor: @jgostick (Active) Reviewers: @mkhorton, @srmnitc Similarity score: 0.7895

WEdiff: A Python and C++ package for automatic differentiation Submitting author: @ctdegroot Handling editor: @arfon (Active) Reviewers: @highlando, @kyleniemeyer Similarity score: 0.7892

Flux: Elegant machine learning with Julia Submitting author: @MikeInnes Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @ysimillides Similarity score: 0.7886

Heta compiler: a software tool for the development of large-scale QSP models and compilation into simulation formats Submitting author: @metelkin Handling editor: @fboehm (Active) Reviewers: @martinmodrak, @elimillera Similarity score: 0.7862

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.7860

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

josh146 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations Submitting author: @ml-evs Handling editor: @jgostick (Active) Reviewers: @mkhorton, @srmnitc Similarity score: 0.7895

WEdiff: A Python and C++ package for automatic differentiation Submitting author: @ctdegroot Handling editor: @arfon (Active) Reviewers: @highlando, @kyleniemeyer Similarity score: 0.7892

Flux: Elegant machine learning with Julia Submitting author: @MikeInnes Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @ysimillides Similarity score: 0.7886

Heta compiler: a software tool for the development of large-scale QSP models and compilation into simulation formats Submitting author: @metelkin Handling editor: @fboehm (Active) Reviewers: @martinmodrak, @elimillera Similarity score: 0.7862

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.7860

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

josh146 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

matador: a Python library for analysing, curating and performing high-throughput density-functional theory calculations Submitting author: @ml-evs Handling editor: @jgostick (Active) Reviewers: @mkhorton, @srmnitc Similarity score: 0.7895

WEdiff: A Python and C++ package for automatic differentiation Submitting author: @ctdegroot Handling editor: @arfon (Active) Reviewers: @highlando, @kyleniemeyer Similarity score: 0.7892

Flux: Elegant machine learning with Julia Submitting author: @MikeInnes Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @ysimillides Similarity score: 0.7886

Heta compiler: a software tool for the development of large-scale QSP models and compilation into simulation formats Submitting author: @metelkin Handling editor: @fboehm (Active) Reviewers: @martinmodrak, @elimillera Similarity score: 0.7862

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.7860

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

πŸ‘‹ @jarvist - a ping to see if you would be able to edit this, as previously invited

jarvist commented 1 year ago

@editorialbot assign @jarvist as editor

OK! I've been a bit snowed under with teaching, but the autumn-term pressure is starting to lessen.

editorialbot commented 1 year ago

Assigned! @jarvist is now the editor

jarvist commented 1 year ago

@josh146 - do you have any suggestions for reviewers? This style of software is really quite specialist. I was wondering if some people from the slightly more general area of quantum computing / quantum information might have a view.

jarvist commented 12 months ago

A gentle poke @josh146

josh146 commented 12 months ago

Apologies @jarvist, I have just returned from a vacation :) Potential suggestions for reviewers include Nathan Shammah, Travis Humble, Pranav Gorkhale, or Andrew Litteken.

josh146 commented 11 months ago

Just wanted to double check here if there was anything else you needed from me!

josh146 commented 10 months ago

Hi @jarvist, happy holidays and new year! Just wanted to follow up here quickly

josh146 commented 9 months ago

Hey @danielskatz! Just wondering if there's anything you need from my end to get the review process underway

danielskatz commented 9 months ago

@josh146 - we just need @jarvist to get things going, which I hope will happen soon...

danielskatz commented 9 months ago

πŸ‘‹ @jarvist - are you going to be able to do this? If not, we can try to find another editor

jarvist commented 9 months ago

Yes, should have a bit more time now! Thanks for the suggestions @josh146 .

danielskatz commented 9 months ago

πŸ‘‹ @jarvist - just another ping on this, as it's come up on my list of submissions without an update in a 2-week period...

josh146 commented 8 months ago

Hey all, just wanted to do a polite ping on this @danielskatz @jarvist :)

danielskatz commented 7 months ago

πŸ‘‹ @jarvist - are you able to keep working on this?

josh146 commented 6 months ago

Hi @danielskatz, we're wondering how best to get this moving?

danielskatz commented 6 months ago

Sorry, I'm not sure what's happened with @jarvist, who hasn't replied to me on slack either. I'll go ahead and take this over and get it started.

danielskatz commented 6 months ago

@editorialbot assign me as editor

editorialbot commented 6 months ago

Assigned! @danielskatz is now the editor

danielskatz commented 6 months ago

πŸ‘‹ @nathanshammah, @travishumble, @AndrewLitteken - would a couple of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

danielskatz commented 6 months ago

Note - I've also asked a couple of people as potential editors off-line

danielskatz commented 6 months ago

Thanks to @pmcao for agreeing to review - I'll add you, but we won't start until get one more reviewer as well