[REVIEW]: prospect: an R package to link leaf optical properties with their chemical and structural properties with the leaf model PROSPECT

editorialbot commented 11 months ago

Submitting author: !--author-handle-->@jbferet@marcosvital<!--end-editor-- Reviewers: @earth-chris, @nehakn, @ashiklom Archive: 10.5281/zenodo.10480410

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d469ff5d6ba84a1deeeaf4bbd353c5d0"><img src="https://joss.theoj.org/papers/d469ff5d6ba84a1deeeaf4bbd353c5d0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d469ff5d6ba84a1deeeaf4bbd353c5d0/status.svg)](https://joss.theoj.org/papers/d469ff5d6ba84a1deeeaf4bbd353c5d0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@earth-chris & @nehakn & @ashiklom, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @marcosvital know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @earth-chris

📝 Checklist for @nehakn

📝 Checklist for @ashiklom

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1364/JOSA.60.000542 is OK
- 10.1016/j.rse.2007.09.005 is OK
- 10.1016/j.rse.2008.02.012 is OK
- 10.1016/j.rse.2017.03.004 is OK
- 10.1016/j.rse.2018.11.002 is OK
- 10.1016/j.rse.2020.112173 is OK
- 10.1016/0034-4257(90)90100-Z is OK
- 10.1016/j.rse.2008.01.026 is OK
- 10.1016/j.rse.2016.02.029 is OK
- 10.1109/TGRS.2011.2109390 is OK
- 10.1016/j.rse.2020.112176 is OK
- 10.1016/j.rse.2006.12.013 is OK
- 10.1109/TGRS.2007.895844 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbferet commented 9 months ago

@kthyng paper has been updated following your recommendations. Thank you for noticing these mistakes!

kthyng commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 9 months ago

Here is a PR to deal with the inline references: https://github.com/jbferet/prospect/pull/12

jbferet commented 8 months ago

thank you @kthyng. The pull request was accepted. let me know if any additional acction requiredon my side!

kthyng commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 8 months ago

@jbferet I am still seeing those references as parenthetical instead of inline. Can you tell what is wrong? I see you merged the PR but I don't see the updates in the history of the repository. Did the default branch change?

jbferet commented 8 months ago

@kthyng sorry for this mistake. I accepted the PR and forgot to pull it on my local repository... so it was deleted at the next update. this should be fixed now. thank you for noticing it!

kthyng commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 8 months ago

Ok looks good! Ready to finish.

kthyng commented 8 months ago

@editorialbot accept

editorialbot commented 8 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Féret given-names: Jean-Baptiste orcid: "https://orcid.org/0000-0002-0151-1334" - family-names: Boissieu given-names: Florian name-particle: de orcid: "https://orcid.org/0000-0002-2185-9952" contact: - family-names: Féret given-names: Jean-Baptiste orcid: "https://orcid.org/0000-0002-0151-1334" doi: 10.5281/zenodo.10480410 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Féret given-names: Jean-Baptiste orcid: "https://orcid.org/0000-0002-0151-1334" - family-names: Boissieu given-names: Florian name-particle: de orcid: "https://orcid.org/0000-0002-2185-9952" date-published: 2024-02-05 doi: 10.21105/joss.06027 issn: 2475-9066 issue: 94 journal: Journal of Open Source Software publisher: name: Open Journals start: 6027 title: "prospect: an R package to link leaf optical properties with their chemical and structural properties with the leaf model PROSPECT" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06027" volume: 9 title: "`prospect`: an R package to link leaf optical properties with their chemical and structural properties with the leaf model PROSPECT" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4980
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06027
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 8 months ago

Congratulations on your new publication to @jbferet! Many thanks to reviewers @earth-chris, @nehakn, and @ashiklom for your time, hard work, and expertise!!

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06027/status.svg)](https://doi.org/10.21105/joss.06027)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06027">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06027/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06027/status.svg
   :target: https://doi.org/10.21105/joss.06027

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews