[REVIEW]: Multivariate Covariance Generalized Linear Models in Python: The mcglm library

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@jeancmaia@crvernon<!--end-editor-- Reviewers: @Spaak, @bkrayfield Archive: 10.5281/zenodo.12569050

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b0cf48e0bc9265d2ad754b1d33475936"><img src="https://joss.theoj.org/papers/b0cf48e0bc9265d2ad754b1d33475936/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b0cf48e0bc9265d2ad754b1d33475936/status.svg)](https://joss.theoj.org/papers/b0cf48e0bc9265d2ad754b1d33475936)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Spaak & @bkrayfield, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AJQuinn know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @bkrayfield

📝 Checklist for @Spaak

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.7287/PEERJ.PREPRINTS.1686V1 is OK
- 10.48550/arXiv.1809.10756 is OK
- 10.48550/arXiv.1810.09538 is OK
- 10.18637/jss.v076.i01 is OK
- 10.48550/arXiv.1409.7482 is OK
- 10.1111/j.2517-6161.1987.tb01685.x is OK
- 10.1002/1097-0258(20000730)19:14<1952::AID-SIM474>3.0.CO;2-K is OK
- 10.2307/2344614 is OK
- 10.1007/978-3-642-21551-3_24 is OK
- 10.1214/ss/1177013604 is OK
- 10.1214/aos/1176345451 is OK
- 10.1002/9781118445112.stat07536 is OK
- 10.2307/2841583 is OK
- 10.2307/2333849 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.18637/jss.v084.i04 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.3844/jcssp.2021.624.638 is OK
- 10.1177/0962280212445834 is OK
- 10.1214/12-EJS721 is OK
- 10.1016/j.jmva.2013.05.001 is OK
- 10.1093/biomet/73.1.13 is OK
- 10.1111/rssc.12145 is OK
- 10.1515/ijb-2017-0001 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 4 months ago

:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.

ID tabU003Amethods already defined

jeancmaia commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

I'm sorry @jeancmaia, I'm afraid I can't do that. That's something only editors are allowed to do.

jeancmaia commented 4 months ago

@crvernon Would you mind re-running it again? I have pushed a new paper.md version.

crvernon commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.7287/PEERJ.PREPRINTS.1686V1 is OK
- 10.48550/arXiv.1809.10756 is OK
- 10.48550/arXiv.1810.09538 is OK
- 10.18637/jss.v076.i01 is OK
- 10.48550/arXiv.1409.7482 is OK
- 10.1111/j.2517-6161.1987.tb01685.x is OK
- 10.1002/1097-0258(20000730)19:14<1952::AID-SIM474>3.0.CO;2-K is OK
- 10.2307/2344614 is OK
- 10.1007/978-3-642-21551-3_24 is OK
- 10.1214/ss/1177013604 is OK
- 10.1214/aos/1176345451 is OK
- 10.1002/9781118445112.stat07536 is OK
- 10.2307/2841583 is OK
- 10.2307/2333849 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.18637/jss.v084.i04 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.3844/jcssp.2021.624.638 is OK
- 10.1177/0962280212445834 is OK
- 10.1214/12-EJS721 is OK
- 10.1016/j.jmva.2013.05.001 is OK
- 10.1093/biomet/73.1.13 is OK
- 10.1111/rssc.12145 is OK
- 10.1515/ijb-2017-0001 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 4 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5544, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

crvernon commented 4 months ago

@ediorialbot accept

crvernon commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Maia given-names: Jean Carlos Faoot orcid: "https://orcid.org/0009-0001-3747-0669" - family-names: Bonat given-names: Wagner Hugo orcid: "https://orcid.org/0000-0002-0349-7054" doi: 10.5281/zenodo.12569050 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Maia given-names: Jean Carlos Faoot orcid: "https://orcid.org/0009-0001-3747-0669" - family-names: Bonat given-names: Wagner Hugo orcid: "https://orcid.org/0000-0002-0349-7054" date-published: 2024-06-27 doi: 10.21105/joss.06037 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6037 title: "Multivariate Covariance Generalized Linear Models in Python: The mcglm library" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06037" volume: 9 title: "Multivariate Covariance Generalized Linear Models in Python: The mcglm library" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5546
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06037
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

crvernon commented 4 months ago

🥳 Congratulations on your new publication @jeancmaia! Many thanks to @Spaak and @bkrayfield for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06037/status.svg)](https://doi.org/10.21105/joss.06037)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06037">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06037/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06037/status.svg
   :target: https://doi.org/10.21105/joss.06037

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

jeancmaia commented 4 months ago

That's fabulous. Thanks @crvernon.

For some reason, the paper is not rendering on the JOSS page. https://joss.theoj.org/papers/10.21105/joss.06037. Also, when I attempted to download it, I received a 404. Are you facing this issue too?

crvernon commented 4 months ago

@jeancmaia the record likely is still finalizing. I will check in on it in a bit.

jeancmaia commented 4 months ago

It is working now. Thank you!!

openjournals / joss-reviews