search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: Cellpy – an open-source library for processing and analysis of battery testing data #6043

Closed editorialbot closed 7 months ago

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@jepegit<!--end-author-handle-- (Jan Petter Maehlen) Repository: https://github.com/jepegit/cellpy Branch with paper.md (empty if default branch): Version: v1.0.0post4 Editor: !--editor-->@mbarzegary<!--end-editor-- Reviewers: @MaximevdHeijden, @TomTranter Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c12d3c3643db533b847ad44d19096768"><img src="https://joss.theoj.org/papers/c12d3c3643db533b847ad44d19096768/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c12d3c3643db533b847ad44d19096768/status.svg)](https://joss.theoj.org/papers/c12d3c3643db533b847ad44d19096768)

Author instructions

Thanks for submitting your paper to JOSS @jepegit. Currently, there isn't a JOSS editor assigned to your paper.

@jepegit if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 10 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 10 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.37 s (589.0 files/s, 155196.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         101           7101           6646          30019
SVG                              4              0            529           2836
reStructuredText                63           1276           1312           1727
YAML                            19             61             42            806
Markdown                        12            123              0            316
Jupyter Notebook                 6              0           3034            286
JSON                             6             12              0            253
DOS Batch                        1             29              1            212
make                             1             28              6            143
TeX                              1              8              0             83
TOML                             2              6              0             21
-------------------------------------------------------------------------------
SUM:                           216           8644          11570          36702
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 10 months ago

Wordcount for paper.md is 1200

editorialbot commented 10 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2020.100506 is OK
- 10.1016/j.jelechem.2023.117627 is OK
- 10.3390/batteries9050251 is OK
- 10.1002/celc.202001108 is OK
- 10.1038/s41598-019-51324-4 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 10 months ago

Hello @jepegit, thanks for your submission to JOSS. Unfortunately, we do not have an editor available in this area at the moment, so I have to put your submission in our waitlist until someone frees up. In the meantime, any reviewer suggestions would be welcome.

jepegit commented 9 months ago

Hi @kyleniemeyer,

Thanks. I can suggest the following reviewers:

@mdmurbach @EricaEgg

kyleniemeyer commented 8 months ago

@editorialbot add @mbarzegary as editor

@mbarzegary, thanks for volunteering to edit this submission!

editorialbot commented 8 months ago

Assigned! @mbarzegary is now the editor

mbarzegary commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

DiffCapAnalyzer: A Python Package for Quantitative Analysis of Total Differential Capacity Data Submitting author: @nicolet5 Handling editor: @jgostick (Active) Reviewers: @yangbai90, @WardLT Similarity score: 0.8311

liionpack: A Python package for simulating packs of batteries with PyBaMM Submitting author: @TomTranter Handling editor: @timtroendle (Active) Reviewers: @EricaEgg, @mefuller, @yangbai90 Similarity score: 0.8192

polypy - Analysis Tools for Solid State Molecular Dynamics and Monte Carlo Trajectories Submitting author: @symmy596 Handling editor: @richardjgowers (Active) Reviewers: @hmacdope, @lscalfi Similarity score: 0.8184

CellPyLib: A Python Library for working with Cellular Automata Submitting author: @lantunes Handling editor: @jbytecode (Active) Reviewers: @blsqr, @szhorvat Similarity score: 0.8175

impedance.py: A Python package for electrochemical impedance analysis Submitting author: @mdmurbach Handling editor: @mbobra (Active) Reviewers: @ma-sadeghi, @EricaEgg Similarity score: 0.8036

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

mbarzegary commented 8 months ago

Hi @EricaEgg and @mdmurbach👋 Considering your expertise and previous experience on reviewing for JOSS, would any of you be willing to review this submission? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06043/joss.06043/10.21105.joss.06043.pdf Software: https://github.com/jepegit/cellpy

mbarzegary commented 8 months ago

Hi @MaximevdHeijden 👋 Considering your field of expertise, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06043/joss.06043/10.21105.joss.06043.pdf Software: https://github.com/jepegit/cellpy

MaximevdHeijden commented 8 months ago

Hi @mbarzegary, I would gladly review this submission for JOSS.

mbarzegary commented 8 months ago

@editorialbot add @MaximevdHeijden as reviewer

editorialbot commented 8 months ago

@MaximevdHeijden added to the reviewers list!

mbarzegary commented 8 months ago

Hi @sarahalamdari, @nicolet5, @TomTranter, @mdmurbach 👋 Considering that you have already published your software in JOSS, would any of you be willing to review this submission? As you know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06043/joss.06043/10.21105.joss.06043.pdf Software: https://github.com/jepegit/cellpy

mbarzegary commented 8 months ago

Hi @ma-sadeghi, @yangbai90 and @WardLT 👋 Considering that you have already reviewed for JOSS, would any of you be willing to review this submission? As you know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06043/joss.06043/10.21105.joss.06043.pdf Software: https://github.com/jepegit/cellpy

TomTranter commented 8 months ago

Hi, yes I am happy to review this submission. Looks right up my street

mbarzegary commented 8 months ago

@editorialbot add @TomTranter as reviewer

editorialbot commented 8 months ago

@TomTranter added to the reviewers list!

mbarzegary commented 7 months ago

@ma-sadeghi, @yangbai90, @WardLT, @sarahalamdari, @nicolet5 I'll start the review, but you can still inform me if any of you would be willing to join the reviewers of this submission.

mbarzegary commented 7 months ago

@editorialbot start review

editorialbot commented 7 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6236.

ma-sadeghi commented 7 months ago

Hi @mbarzegary. Sure, I'd be happy to review this submission.

WardLT commented 7 months ago

Sorry for the delay, I can join in the review.

mbarzegary commented 7 months ago

@WardLT Thank you for the reply. Since we have already 3 reviewers on this submission, I can assign you to another relevant one (https://github.com/openjournals/joss-reviews/issues/6218) if you believe it fits your expertise.

WardLT commented 7 months ago

@WardLT Thank you for the reply. Since we have already 3 reviewers on this submission, I can assign you to another relevant one (#6218) if you believe it fits your expertise.

Sorry, that one is a little outside of what I know well. Electronic and Phonon structures are not my expertise. Maybe @dyllamt