openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[REVIEW]: Viash: A meta-framework for building reusable workflow modules #6089

Closed editorialbot closed 8 months ago

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@rcannood<!--end-author-handle-- (Robrecht Cannoodt) Repository: https://github.com/viash-io/viash Branch with paper.md (empty if default branch): paper Version: 0.8.4 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @wilkinson, @abhishektiwari, @mberacochea Archive: 10.5281/zenodo.10563479

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c"><img src="https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c/status.svg)](https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wilkinson & @abhishektiwari & @mberacochea, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @abhishektiwari

πŸ“ Checklist for @mberacochea

πŸ“ Checklist for @wilkinson

editorialbot commented 8 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - email: robrecht@data-intuitive.com family-names: Cannoodt given-names: Robrecht orcid: "https://orcid.org/0000-0003-3641-729X" - family-names: Cannoodt given-names: Hendrik orcid: "https://orcid.org/0000-0002-0032-6719" - family-names: Schaumont given-names: Dries orcid: "https://orcid.org/0000-0002-4389-0440" - family-names: Waldrant given-names: Kai orcid: "https://orcid.org/0009-0003-8555-1361" - family-names: Kerckhove given-names: Eric Van name-particle: de - family-names: Boschmans given-names: Andy orcid: "https://orcid.org/0009-0008-8793-4661" - family-names: Maeyer given-names: Dries De orcid: "https://orcid.org/0000-0002-1314-3348" - email: toni@data-intuitive.com family-names: Verbeiren given-names: Toni orcid: "https://orcid.org/0000-0002-7007-6866" contact: - email: robrecht@data-intuitive.com family-names: Cannoodt given-names: Robrecht orcid: "https://orcid.org/0000-0003-3641-729X" - email: toni@data-intuitive.com family-names: Verbeiren given-names: Toni orcid: "https://orcid.org/0000-0002-7007-6866" doi: 10.5281/zenodo.10563479 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - email: robrecht@data-intuitive.com family-names: Cannoodt given-names: Robrecht orcid: "https://orcid.org/0000-0003-3641-729X" - family-names: Cannoodt given-names: Hendrik orcid: "https://orcid.org/0000-0002-0032-6719" - family-names: Schaumont given-names: Dries orcid: "https://orcid.org/0000-0002-4389-0440" - family-names: Waldrant given-names: Kai orcid: "https://orcid.org/0009-0003-8555-1361" - family-names: Kerckhove given-names: Eric Van name-particle: de - family-names: Boschmans given-names: Andy orcid: "https://orcid.org/0009-0008-8793-4661" - family-names: Maeyer given-names: Dries De orcid: "https://orcid.org/0000-0002-1314-3348" - email: toni@data-intuitive.com family-names: Verbeiren given-names: Toni orcid: "https://orcid.org/0000-0002-7007-6866" date-published: 2024-01-24 doi: 10.21105/joss.06089 issn: 2475-9066 issue: 93 journal: Journal of Open Source Software publisher: name: Open Journals start: 6089 title: "Viash: A meta-framework for building reusable workflow modules" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06089" volume: 9 title: "Viash: A meta-framework for building reusable workflow modules" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4948
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06089
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

danielskatz commented 8 months ago

Congratulations to @rcannood (Robrecht Cannoodt) and co-authors on your publication!!

And thanks to @wilkinson, @abhishektiwari, and @mberacochea for reviewing! JOSS depends on volunteers and we couldn't do this without you

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06089/status.svg)](https://doi.org/10.21105/joss.06089)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06089">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06089/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06089/status.svg
   :target: https://doi.org/10.21105/joss.06089

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

rcannood commented 8 months ago

A big thank you to @abhishektiwari @mberacochea @wilkinson and @danielskatz ! :bow: :bow: :bow: :bow:

I see the names of Eric and Dries are split up incorrectly. Should I create a PR to amend https://github.com/openjournals/joss-papers/pull/4948?

danielskatz commented 8 months ago

Yes, please do

rcannood commented 7 months ago

Hi @danielskatz ! I created https://github.com/openjournals/joss-papers/pull/4949 . Is there somebody I could ask to take a look at this PR? :bow: Thanks!

danielskatz commented 7 months ago

@rcannood - The files you are trying to change in your PR are automatically generated by JOSS. So please delete this PR, and instead, make changes in your paper source. See https://joss.readthedocs.io/en/latest/submitting.html#names in the JOSS documentation for how to do this.

Let me know when this is done, and I'll redo the generation, so we can check the xml and jats files, then when we are happy, I'll republish those versions.

rcannood commented 7 months ago

Hi @danielskatz! Thanks for your help! I had missed your reply until Arfon pointed it out to me.

I made the necessary changes to the author names in the paper branch at viash-io/viash. Would you be able to regenerate the XML and Jats files?

Thanks you so much for your time! :bow:

danielskatz commented 7 months ago

@editorialbot re-accept

editorialbot commented 7 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

danielskatz commented 7 months ago

@editorialbot reaccept

editorialbot commented 7 months ago
Rebuilding paper!
editorialbot commented 7 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5004

danielskatz commented 7 months ago

@rcannood - I hope this has fixed the problem - it looks like it did to me.

rcannood commented 6 months ago

Yes -- thank you so much @danielskatz !