openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[PRE REVIEW]: jaxparrow: a Python package solving the cyclogeostrophic balance using a variational formulation #6095

Closed editorialbot closed 8 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@vadmbertr<!--end-author-handle-- (Vadim Bertrand) Repository: https://github.com/meom-group/jaxparrow Branch with paper.md (empty if default branch): joss_paper Version: 0.0.3 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/55457f870bdd764b13766ec809398d91"><img src="https://joss.theoj.org/papers/55457f870bdd764b13766ec809398d91/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/55457f870bdd764b13766ec809398d91/status.svg)](https://joss.theoj.org/papers/55457f870bdd764b13766ec809398d91)

Author instructions

Thanks for submitting your paper to JOSS @vadmbertr. Currently, there isn't a JOSS editor assigned to your paper.

@vadmbertr if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (959.5 files/s, 118340.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         5            269              0            653
Jupyter Notebook                 2              0           1191            589
Python                          10            222            380            533
TeX                              1             14              0            172
YAML                             6             36             64            156
TOML                             1              6              0             44
reStructuredText                11             26             57             28
-------------------------------------------------------------------------------
SUM:                            36            573           1692           2175
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 1319

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1073/pnas.41.10.731 is OK
- 10.3989/scimar.2006.70s2105 is OK
- 10.1002/2013JC009528 is OK
- 10.1029/2019JC015031 is OK
- 10.5281/zenodo.4032732 is OK
- 10.5194/gmd-15-5829-2022 is OK
- 10.5281/zenodo.6334656 is OK
- 10.1093/biomet/55.1.1 is OK
- 10.1029/2022JC019357 is OK
- 10.5194/os-15-1207-2019 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1175/1520-0493(1962)0903C0175:HGWA3E2.0.CO;2 is INVALID
- 10.1175/1520-0493(1961)0893C0187:CAUOGW3E2.0.CO;2 is INVALID
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

Capytaine: a Python-based linear potential flow solver Submitting author: @mancellin Handling editor: @leouieda (Retired) Reviewers: @mikaem, @harpolea Similarity score: 0.8142

Aronnax: An idealised isopycnal ocean model Submitting author: @edoddridge Handling editor: @kyleniemeyer (Active) Reviewers: @dvalters Similarity score: 0.8121

SHARPy: A dynamic aeroelastic simulation toolbox for very flexible aircraft and wind turbines Submitting author: @fonsocarre Handling editor: @labarba (Retired) Reviewers: @petebachant, @rafmudaf Similarity score: 0.8103

qgs: A flexible Python framework of reduced-order multiscale climate models Submitting author: @jodemaey Handling editor: @harpolea (Retired) Reviewers: @eviatarbach, @sadielbartholomew Similarity score: 0.8082

Wakeflow: A Python package for semi-analytic models of planetary wakes Submitting author: @TomHilder Handling editor: @dfm (Active) Reviewers: @richteague, @andizq Similarity score: 0.8060

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 9 months ago

Hi @vadmbertr and thanks for your submission! Due to its relatively small size, I am going to ping the greater editorial board to check if it is in scope according to the substantial scholarly effort requirement. This will take up to a few weeks.

kthyng commented 9 months ago

@editorialbot query scope

editorialbot commented 9 months ago

Submission flagged for editorial review.

vadmbertr commented 9 months ago

Hi @kthyng.

Maybe it can be relevant to mention that the work on this variational inversion started before the age of jaxparrow repository. The original repository can be found here: https://github.com/VictorZaia/cyclogeostrophic_balance.

If our submission is accepted, I can propose some possible reviewers (they have never reviewed for JOSS):

Regards,

kthyng commented 8 months ago

Hi @vadmbertr and sorry for such a long delay. Unfortunately, while your package is nicely put together, it is just too small at present. If you continue to develop the package, please consider submitting it to JOSS in the future.

kthyng commented 8 months ago

@editorialbot reject

editorialbot commented 8 months ago

Paper rejected.