[REVIEW]: PAM: Population Activity Modeller

[editorialbot]

Submitting author: !--author-handle-->@fredshone<!--end-author-handle-- (Fred Shone) Repository: https://github.com/arup-group/pam Branch with paper.md (empty if default branch): joss Version: v0.3.2 Editor: !--editor-->@martinfleis<!--end-editor-- Reviewers: @jamesdamillington, @martibosch Archive: 10.5281/zenodo.10948231

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c8737f0649d60fffcd3ba0aa25fa5f40"><img src="https://joss.theoj.org/papers/c8737f0649d60fffcd3ba0aa25fa5f40/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c8737f0649d60fffcd3ba0aa25fa5f40/status.svg)](https://joss.theoj.org/papers/c8737f0649d60fffcd3ba0aa25fa5f40)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jamesdamillington & @martibosch, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @martinfleis know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @jamesdamillington

📝 Checklist for @martibosch

[fredshone]

(pdf and xml look correct)

[oliviaguest]

@fredshone can you change the reference to be without the double brackets here please:

(e.g., (Castro et al., 2023)).

[oliviaguest]

see: https://github.com/arup-group/pam/pull/273

[fredshone]

@oliviaguest merged (thanks for the PR!)

[fredshone]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[oliviaguest]

@fredshone sorry, I should have clarified! That was one, but you have more. Can you check and edit them, please?

[fredshone]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[fredshone]

@oliviaguest my bad - too excited to get a PR 🥇 - I found one other (Shone & Kozlowska) which is fixed.

Otherwise we make extensive use of refs in brackets... please let me know if not ok.

[oliviaguest]

@fredshone looks beautiful ☺️

[oliviaguest]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5334/baw is OK
- 10.17226/22357 is OK
- 10.1080/12265934.2013.835118 is OK
- 10.14279/depositonce-9835 is OK
- 10.1016/j.procs.2021.03.089 is OK

MISSING DOIs

- No DOI given, and none found for title: Pandemic Activity Modifier: Intro
- No DOI given, and none found for title: European Transport Conference Papers 2022: Agent-b...
- No DOI given, and none found for title: ActivitySim: Large-Scale Agent-Based Activity Gene...

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5265, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[oliviaguest]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Shone given-names: Fred orcid: "https://orcid.org/0009-0008-1079-0081" - family-names: Chatziioannou given-names: Theodore - family-names: Pickering given-names: Bryn orcid: "https://orcid.org/0000-0003-4044-6587" - family-names: Kozlowska given-names: Kasia - family-names: Fitzmaurice given-names: Michael doi: 10.5281/zenodo.10948231 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Shone given-names: Fred orcid: "https://orcid.org/0009-0008-1079-0081" - family-names: Chatziioannou given-names: Theodore - family-names: Pickering given-names: Bryn orcid: "https://orcid.org/0000-0003-4044-6587" - family-names: Kozlowska given-names: Kasia - family-names: Fitzmaurice given-names: Michael date-published: 2024-04-23 doi: 10.21105/joss.06097 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 6097 title: "PAM: Population Activity Modeller" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06097" volume: 9 title: "PAM: Population Activity Modeller" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5266
1. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06097
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[fredshone]

thank you all 🥳

[oliviaguest]

Huge thanks to the reviewers and editor, @martinfleis, @jamesdamillington, @martibosch! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the authors @fredshone! 🥳 🍾

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06097/status.svg)](https://doi.org/10.21105/joss.06097)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06097">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06097/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06097/status.svg
   :target: https://doi.org/10.21105/joss.06097

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss