openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: Segment-Lidar: Automatic Unsupervised LiDAR-Segmentation using Segment-Anything Model (SAM) #6107

Closed editorialbot closed 9 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@yarroudh<!--end-author-handle-- (Anass Yarroudh) Repository: https://github.com/Yarroudh/segment-lidar Branch with paper.md (empty if default branch): main Version: v0.2.1 Editor: Pending Reviewers: Pending Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/35cc33b0bffc83a6337cefc3f20d5cb8"><img src="https://joss.theoj.org/papers/35cc33b0bffc83a6337cefc3f20d5cb8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/35cc33b0bffc83a6337cefc3f20d5cb8/status.svg)](https://joss.theoj.org/papers/35cc33b0bffc83a6337cefc3f20d5cb8)

Author instructions

Thanks for submitting your paper to JOSS @yarroudh. Currently, there isn't a JOSS editor assigned to your paper.

@yarroudh if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (949.5 files/s, 189569.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              0              0           2671
HTML                             9            213             27           1510
JavaScript                      12            131            221            880
CSS                              4            190             35            780
Python                           3            122            221            466
Markdown                         2            116              0            197
reStructuredText                 6            134            126            144
TeX                              2             11              0            139
YAML                             2              1              4             19
Dockerfile                       1              6              4             17
-------------------------------------------------------------------------------
SUM:                            42            924            638           6823
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 1372

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.05663 is OK
- 10.3390/rs8060501 is OK
- 10.3390/rs14225649 is OK

MISSING DOIs

- 10.1049/cp.2019.0255 may be a valid DOI for title: A Benchmark Dataset for RGB-D Sphere Based Calibration

INVALID DOIs

- https://doi.org/10.1016/B978-0-08-102696-0.00016-6 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

Volume Segmantics: A Python Package for Semantic Segmentation of Volumetric Data Using Pre-trained PyTorch Deep Learning Models Submitting author: @OllyK Handling editor: @osorensen (Active) Reviewers: @jingpengw, @estenhl Similarity score: 0.8179

lidar: A Python package for delineating nested surface depressions from digital elevation data Submitting author: @giswqs Handling editor: @kbarnhart (Retired) Reviewers: @laijingtao, @cheginit, @amanaster2 Similarity score: 0.8146

DetecTree: Tree detection from aerial imagery in Python Submitting author: @martibosch Handling editor: @kthyng (Active) Reviewers: @JeffWalton-PSC, @rmsare Similarity score: 0.8133

Pyoints: A Python package for point cloud, voxel and raster processing. Submitting author: @laempy Handling editor: @lheagy (Retired) Reviewers: @kbevers, @scivision Similarity score: 0.8016

Semi-Automatic Classification Plugin: A Python tool for the download and processing of remote sensing images in QGIS Submitting author: @semiautomaticgit Handling editor: @kthyng (Active) Reviewers: @bstabler, @joferkington Similarity score: 0.8005

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 9 months ago

Thanks for your submission to JOSS @Yarroudh. Could you please explain what the software contribution of this project is? From the looks of things, this is ~500 lines of Python that interacts with some models. Is that correct?

Yarroudh commented 9 months ago

Hello @arfon, Thanks for responding to my submission. The software contribute to 3D point cloud automatic segmentation using an image-based approach. The view module handles the projection of the point cloud into an image plane, this includes a simple top view for aerial LiDAR data and a Pinhole camera for customized views. The resulting image is segmented using Segment-Anything-Model (SAM) to extract all masks from the image. The results are reprojected on the 3D point cloud to extract individual instances. Other features are implemented like text prompts for specific objects extraction and ground points filtering for enhanced segmentation of aerial LiDAR data.

arfon commented 9 months ago

@editorialbot query scope

OK, thanks for the input. As this is on the smaller-size of what we publish in JOSS, I'm going to initiate a scope review with the JOSS editorial team. This will take a couple of weeks to complete.

editorialbot commented 9 months ago

Submission flagged for editorial review.

Yarroudh commented 9 months ago

@editorialbot commands

editorialbot commented 9 months ago

Hello @Yarroudh, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
Yarroudh commented 9 months ago

@editorialbot generate preprint

editorialbot commented 9 months ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

arfon commented 9 months ago

@Yarroudh - thanks for your submission to JOSS. Unfortunately, after review by the JOSS editorial team we've determined that this submission doesn't meet our substantial scholarly effort criterion.

One possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work.

arfon commented 9 months ago

@editorialbot reject

editorialbot commented 9 months ago

Paper rejected.