search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: OpenTerrace: A fast, flexible and extendable Python framework for thermal storage packed bed simulations #6128

Closed editorialbot closed 8 months ago

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@jakobhaervig<!--end-author-handle-- (Jakob Hærvig) Repository: https://github.com/OpenTerrace/openterrace-python Branch with paper.md (empty if default branch): development Version: v0.0.8 Editor: !--editor-->@AdamRJensen<!--end-editor-- Reviewers: @baperry2, @hewei8622 Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cc89107c74cba69a948a98e5b0604336"><img src="https://joss.theoj.org/papers/cc89107c74cba69a948a98e5b0604336/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cc89107c74cba69a948a98e5b0604336/status.svg)](https://joss.theoj.org/papers/cc89107c74cba69a948a98e5b0604336)

Author instructions

Thanks for submitting your paper to JOSS @jakobhaervig. Currently, there isn't a JOSS editor assigned to your paper.

@jakobhaervig if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 10 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 10 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (1118.9 files/s, 132383.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              9              6             39           5883
Python                          26            307            430            826
Markdown                        24            103              0            288
YAML                             7             32              4            237
HTML                             2             34              2            211
TeX                              1              3              0             44
TOML                             1              9              3             39
JavaScript                       1              1              0             15
CSS                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            72            495            478           7546
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 10 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1145/2833157.2833162 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 10 months ago

Wordcount for paper.md is 500

editorialbot commented 10 months ago

:warning: An error happened when generating the pdf. Author (Jakob Hærvig) is missing affiliation.

danielskatz commented 10 months ago

@jakobhaervig - thanks for your submission.

  1. Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

  2. I think this should be in another track, if it goes forward. It's now in 1) Computer science, Information Science, and Mathematics, and the two options that seem most appropriate to me are 2) Biomedical Engineering, Biosciences, Chemistry, and Materials or 3) Physics and Engineering. Can you let me know which of these you think best fits the work?

  3. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

danielskatz commented 10 months ago

@editorialbot query scope

editorialbot commented 10 months ago

Submission flagged for editorial review.

jakobhaervig commented 10 months ago

@editorialbot generate pdf

Thanks for getting back @danielskatz. I now updated the paper with affiliation and ensured it compiles correctly using this action: https://github.com/openjournals/openjournals-draft-action

Thanks for pointing out the wrong track. It belongs in track 3: Physics and Engineering.

editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 10 months ago

@jakobhaervig - Thanks. I've moved the submission into the correct track, and started the scope review, which @openjournals/pe-eics will handle from here.

kyleniemeyer commented 9 months ago

Hi @jakobhaervig, thanks for your patience. We're going to proceed with reviewing this - just need to find an editor now.

kyleniemeyer commented 9 months ago

@jakobhaervig unfortunately, we don't have any editors available at the moment to handle this. I'll get back to you soon, though.

kyleniemeyer commented 8 months ago

@editorialbot invite @AdamRJensen as editor

Hi @AdamRJensen, could you also take this one?

editorialbot commented 8 months ago

Invitation to edit this submission sent!

AdamRJensen commented 8 months ago

@editorialbot assign @AdamRJensen as editor

editorialbot commented 8 months ago

Assigned! @AdamRJensen is now the editor

AdamRJensen commented 8 months ago

@jakobhaervig could you search the list of people that have already agreed to review and and see if any are suitable for reviewing this submission? If so, please mention them here in this thread (without tagging them with an @).

AdamRJensen commented 8 months ago

:wave: @hewei8622, @mdoucet, I see that you both are signed up as JOSS reviewers with the tag "energy storage" and was wondering if any of you be available to review this submission?

AdamRJensen commented 8 months ago

👋 @baperry2, @hewei8622, and @mdoucet, I see that you are signed up as JOSS reviewers and was wondering if any of you be available to review this submission?

jakobhaervig commented 8 months ago

@AdamRJensen, thanks for finding suitable reviewers. Let me know if I can do anything to speed up the process.

baperry2 commented 8 months ago

@AdamRJensen I am available to be a reviewer for this submission.

AdamRJensen commented 8 months ago

@editorialbot add @baperry2 as reviewer

editorialbot commented 8 months ago

@baperry2 added to the reviewers list!

AdamRJensen commented 8 months ago

👋 @hewei8622 and @mdoucet I just wanted to check again if you are available to review this submission? If you're busy at the moment, that's of course no problem.

@jakobhaervig could you please suggest some additional potential reviewers (comment with their usernames without tagging them, i.e., remove the @ before their GH usernames).

jakobhaervig commented 8 months ago

@AdamRJensen, I searched the list of potential reviewers and found ronshnapp, dankusanovic and GregorBecker.

Thanks, Jakob

AdamRJensen commented 8 months ago

👋 @ronshnapp and @dankusanovic, I see that you are signed up as JOSS reviewers and was wondering if any of you be available to review this submission?

hewei8622 commented 8 months ago

Hi, I am happy to be a reviewer of this paper.

On Fri, Feb 23, 2024 at 12:10 AM Adam R. Jensen @.***> wrote:

👋 @hewei8622 https://github.com/hewei8622 and @mdoucet https://github.com/mdoucet I just wanted to check again if you are available to review this submission? If you're busy at the moment, that's of course no problem.

@jakobhaervig https://github.com/jakobhaervig could you please suggest some additional potential reviewers (comment with their usernames without tagging them, i.e., remove the @ before their GH usernames).

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6128#issuecomment-1960546019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPREEXV2FEO7FEA43WW2DYU7M6BAVCNFSM6AAAAABAMWFSKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGU2DMMBRHE . You are receiving this because you were mentioned.Message ID: @.***>

AdamRJensen commented 8 months ago

@editorialbot add @hewei8622 as reviewer

editorialbot commented 8 months ago

@hewei8622 added to the reviewers list!

AdamRJensen commented 8 months ago

@editorialbot start review

editorialbot commented 8 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6411.

ronshnapp commented 8 months ago

Hello Adam,

Apologies but I am totally booked these days, so I'll have to pass on this one.

Best, Ron

On Sat, Feb 24, 2024 at 1:39 AM Adam R. Jensen @.***> wrote:

👋 @ronshnapp https://github.com/ronshnapp and @dankusanovic https://github.com/dankusanovic, I see that you are signed up as JOSS reviewers and was wondering if any of you be available to review this submission?

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6128#issuecomment-1962138873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDS3TTSGG3BI4F3DX6HESTYVESCDAVCNFSM6AAAAABAMWFSKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGEZTQOBXGM . You are receiving this because you were mentioned.Message ID: @.***>

--

Dr. Ron Shnapp, Senior Lecturer of Mechanical Engineering, Ben Gurion University of the Negev Soref building, 325, POB 653, Beer-Sheva, Israel

https://ronshnapp.wordpress.com/