search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: fABBA: A Python library for the fast symbolic approximation of time series #6132

Closed editorialbot closed 8 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@chenxinye<!--end-author-handle-- (Xinye Chen) Repository: https://github.com/nla-group/fABBA Branch with paper.md (empty if default branch): master Version: v1.1.0 Editor: !--editor-->@lrnv<!--end-editor-- Reviewers: @Karangupta1994, @allie-tatarian Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61"><img src="https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61/status.svg)](https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61)

Author instructions

Thanks for submitting your paper to JOSS @chenxinye. Currently, there isn't a JOSS editor assigned to your paper.

@chenxinye if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.98 s (115.9 files/s, 360946.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                               12          16359          74932         195162
Python                          28           1607           2641           3161
Jupyter Notebook                18              0          50227           2514
C++                              7            171            294            772
C/C++ Header                     9            202            299            622
Cython                          12            346            537            562
Markdown                         7            137              0            342
reStructuredText                 9            244            236            152
TeX                              1             14              0            109
YAML                             4             40             24             83
CSS                              1             18             15             57
DOS Batch                        1              8              1             26
Bourne Shell                     1              2              0             18
make                             1              4              7              9
TOML                             1              0              0              3
SWIG                             1              0              2              0
-------------------------------------------------------------------------------
SUM:                           113          19152         129215         203592
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 875

editorialbot commented 9 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1007/s10618-020-00689-6 may be a valid DOI for title: ABBA: adaptive Brownian bridge-based symbolic aggregation of time series
- 10.1109/tit.1982.1056489 may be a valid DOI for title: Least squares quantization in PCM
- 10.1145/882082.882086 may be a valid DOI for title: A symbolic representation of time series, with implications for streaming algorithms
- 10.1145/3532622 may be a valid DOI for title: An efficient aggregation method for the symbolic representation of temporal data
- 10.1016/j.is.2023.102294 may be a valid DOI for title: ECG classification with learning ensemble based on symbolic discretization
- 10.1007/978-3-031-24378-3_4 may be a valid DOI for title: Fast Time Series Classification with Random Symbolic Subsequences
- 10.1007/s10618-007-0064-z may be a valid DOI for title: Experiencing SAX: a novel symbolic representation of time series
- 10.1109/seed55351.2022.00016 may be a valid DOI for title: Foreseer: Efficiently Forecasting Malware Event Series with Long Short-Term Memory
- 10.1016/j.ress.2023.109123 may be a valid DOI for title: Data-driven prognostics based on time-frequency analysis and symbolic recurrent neural network for fuel cells under dynamic load
- 10.1145/3448672 may be a valid DOI for title: A Framework for Generating Summaries from Temporal Personal Health Data

INVALID DOIs

- None
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python Submitting author: @davidtourigny Handling editor: @marcosvital (Active) Reviewers: @jdbrunner, @pstjohn, @synchon Similarity score: 0.8218

pyFBS: A Python package for Frequency Based Substructuring Submitting author: @tb93 Handling editor: @kyleniemeyer (Active) Reviewers: @ngoiz, @LolloCappo, @Gunnstein Similarity score: 0.8105

FreqAI: generalizing adaptive modeling for chaotic time-series market forecasts Submitting author: @robcaulk Handling editor: @Fei-Tao (Active) Reviewers: @ady00, @shagunsodhani Similarity score: 0.8055

BATMAN: Statistical analysis for expensive computer codes made easy Submitting author: @tupui Handling editor: @katyhuff (Retired) Reviewers: @mikeckennedy Similarity score: 0.8026

ECabc: A feature tuning program focused on Artificial Neural Network hyperparameters Submitting author: @sanskriti-s Handling editor: @arokem (Retired) Reviewers: @annoviko Similarity score: 0.8014

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 9 months ago

@chenxinye – thanks for your submission to JOSS. When including the C code, this looks to be a very large submission. Could you clarify which aspects of this submission you are asking the JOSS reviewers to review?

Also, we're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

chenxinye commented 9 months ago

@arfon Thanks! fABBA is a native Python library and is completely driven by Python code, which has no reliance on C++ at all, so we just hope JOSS reviewers can help to review the Python code, on which our fABBA library is based.

We provide native C++ implementation just for C++ users for reference.

chenxinye commented 9 months ago

@arfon, I just removed the C++ code to for clarifying. Please let us know if you have any questions! Many thanks

arfon commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.94 s (103.5 files/s, 372887.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                               12          16359          74932         195162
Python                          28           1607           2641           3161
Jupyter Notebook                18              0          50227           2514
Cython                          12            346            537            562
Markdown                         7            136              0            346
reStructuredText                 9            244            236            152
TeX                              2             14              0            128
YAML                             4             40             24             83
CSS                              1             18             15             57
DOS Batch                        1              8              1             26
Bourne Shell                     1              2              0             18
make                             1              4              7              9
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            97          18778         128620         202221
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 875

arfon commented 9 months ago

@arfon Thanks! fABBA is a native Python library and is completely driven by Python code, which has no reliance on C++ at all, so we just hope JOSS reviewers can help to review the Python code, on which our fABBA library is based.

Thanks for clarifying. Just to confirm, the C code doesn't need reviewing either?

chenxinye commented 9 months ago

Yes @arfon, many thanks!

arfon commented 8 months ago

@editorialbot invite @lrnv as editor

:wave: @lrnv – would you be willing to edit this submission for JOSS?

/ cc @vissarion for visibility.

editorialbot commented 8 months ago

Invitation to edit this submission sent!

lrnv commented 8 months ago

@editorialbot assign me as editor

editorialbot commented 8 months ago

Assigned! @lrnv is now the editor

lrnv commented 8 months ago

@chenxinye Hey !

Would you please take a look at the list of reviewers to potentially identify a few that would be suitable to review this submission ?

chenxinye commented 8 months ago

Hi @lrnv ,

I suggest @allie-tatarian @@Karangupta1994 @djmannion @dgerosa @wmvanvliet? It would be nice if you can refer to some more.

Many thanks, Xinye

lrnv commented 8 months ago

:wave: @allie-tatarian @@Karangupta1994 @djmannion @dgerosa @wmvanvliet, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

wmvanvliet commented 8 months ago

I'm a bit too busy at the moment to be a reviewer for this one. Project looks good though!

Karangupta1994 commented 8 months ago

Hi Oskar,

Sure, I will be happy to review. Please let me know how to proceed.

Thank you, Karan

On Mon, Jan 22, 2024 at 4:27 AM Oskar Laverny @.***> wrote:

👋 @allie-tatarian https://github.com/allie-tatarian @@Karangupta1994 https://github.com/Karangupta1994 @djmannion https://github.com/djmannion @dgerosa https://github.com/dgerosa @wmvanvliet https://github.com/wmvanvliet, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6132#issuecomment-1903687398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKUCAUFLPKN6P337MC3PQVLYPY5KPAVCNFSM6AAAAABAN75N7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTGY4DOMZZHA . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks and Regards, Karan Gupta 201.238.6498 | @. @.> Linkedin https://www.linkedin.com/in/karan0707/

lrnv commented 8 months ago

@Karangupta1994 Ok great ! Basically instructions will come later when we identified at least another reviewer.

lrnv commented 8 months ago

@editorialbot add @Karangupta1994 as reviewer

editorialbot commented 8 months ago

@Karangupta1994 added to the reviewers list!

allie-tatarian commented 8 months ago

Hi, I can help review this paper. Thanks!

lrnv commented 8 months ago

@allie-tatarian Great thanks ! I'll add you up and we will wait a bit more in case a third invited person manifests.

lrnv commented 8 months ago

@editorialbot add @allie-tatarian as reviewer

editorialbot commented 8 months ago

@allie-tatarian added to the reviewers list!

djmannion commented 8 months ago

Apologies, but I won't be able to be a reviewer for this paper.

lrnv commented 8 months ago

@editorialbot start review

editorialbot commented 8 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6294.