editorialbot commented 10 months ago

Submitting author: !--author-handle-->@mikejohnson51@crvernon<!--end-editor-- Reviewers: @mabesa, @mengqi-z Archive: 10.5281/zenodo.10969037

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b"><img src="https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b/status.svg)](https://joss.theoj.org/papers/f7a4ff717b4430f053da9c34563e705b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mabesa & @mengqi-z, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @mabesa

📝 Checklist for @mengqi-z

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikejohnson51 commented 7 months ago

I updated a citation to point to the published (recent) version opposed to a preprint!

@editorialbot generate pdf

danielskatz commented 7 months ago

FYI, editorialbot commands need to be the first thing in a comment

crvernon commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 7 months ago

:wave: Great work on this @mikejohnson51 !

Here are some things that need to be addressed in the paper:

[ ] In the Summary/Background section, I know you site the Leopold & Maddock paper, but please call out in the text the description of all of the constants in play here (e.g., b, f, m, a, c, k). Also, just as a note to check, the Leopold & Maddock paper lists your V (theirs is listed as v) as mean velocity where you describe this as velocity to a given discharge.
[ ] LINE 71: misspelling of "GitHub" and should use the capital "H"
[ ] LINE 83: you have a double parenthesis around your in-text citation for "Water Prediction, 2023", this should use a single parenthesis.
[ ] LINE 85: Normalized RMSE should use the acronym having a capital "N" as in "NRMSE"
[ ] LINE 85: Should "...or the source data..." be "of the source data"?
[ ] LINE 85: Something is not right with the following (J. ;. C. Johnson J. M.; Coll, 2022) where "J. ;" is likely being referenced incorrectly. I believe this is from the author formatting in the actual reference where a semicolon was used instead of a comma.
[ ] LINE 87: The in-text citations in this sentence should use the format "...like Enzminger et al. (2023) or Afshari (2019), ..." where the comma is also after the last one not before the "or"
[ ] LINE 92: I think there is a sentence structure issue here in "...Institute and clear evidence channel shape may..." perhaps adding in a "that" after the "and" would help.
[ ] LINE 97: Same issue on the "J. ;" citation as above
[ ] LINE 117: Missing a DOI on the Balckburn-Lynch, Agouridis, and Barton paper. Perhaps this one: https://doi.org/10.1111/1752-1688.12540
[ ] LINE 120: Missing a DOI on the Blodgett, Johnson, & Bock 2023 EMS paper. Perhaps this one: https://doi.org/10.1016/j.envsoft.2023.105726
[ ] LINE 131: DOI points to the wrong paper
[ ] LINE 151: Missing DOI: maybe https://doi.org/10.5194/nhess-19-2405-2019
[ ] LINE 170: GitHub should have a capital "H"

Once these are knocked out, we can move to the next step towards getting this published. Thanks!

crvernon commented 7 months ago

Just following up on the status of the above @mikejohnson51. Thanks!

crvernon commented 6 months ago

Just a reminder on the status of the above @mikejohnson51. Thanks!

mikejohnson51 commented 6 months ago

Hi @crvernon thanks for all the feedback (and patience!), we have incorporated this, and the internal review we were required to go through. I think is in in good shape now!

[X] In the Summary/Background section, I know you site the Leopold & Maddock paper, but please call out in the text the description of all of the constants in play here (e.g., b, f, m, a, c, k). Also, just as a note to check, the Leopold & Maddock paper lists your V (theirs is listed as v) as mean velocity where you describe this as velocity to a given discharge.

This now reads: These equations collectively define the "at a station hydraulic geometry" (AHG), with coefficients (a, c, k) and exponents (b, f, m) for the Q-TW, Q-Y, and Q-V relationships. Further we modified the text to say mean velocity (V)

[X] LINE 71: misspelling of "GitHub" and should use the capital "H"

Fixed throughout. Thank you!

[X] LINE 83: you have a double parenthesis around your in-text citation for "Water Prediction, 2023", this should use a single parenthesis.

Fixed and changed to NOAA.

[X] LINE 85: Normalized RMSE should use the acronym having a capital "N" as in "NRMSE"

Changed throughout text.

[X] LINE 85: Should "...or the source data..." be "of the source data"?

changed to read ... accuracy within 0.4% NRMSE of the source data

[X] LINE 85: Something is not right with the following (J. ;. C. Johnson J. M.; Coll, 2022) where "J. ;" is likely being referenced incorrectly. I believe this is from the author formatting in the actual reference where a semicolon was used instead of a comma.

Thank you this has been fixed!

[X] LINE 87: The in-text citations in this sentence should use the format "...like Enzminger et al. (2023) or Afshari (2019), ..." where the comma is also after the last one not before the "or"

Now reads This reduction to a consistent AHG formulation not only enhances interoperability with efforts such as those by Enzminger (2023) or Afshari (2019), but....

[X] LINE 92: I think there is a sentence structure issue here in "...Institute and clear evidence channel shape may..." perhaps adding in a "that" after the "and" would help.

Now reads The development of this package began following the 2017 NOAA/NWS Office of Water Prediction Summer Institute (Johnson et al. 2017) where discussions highlighted the potential influence of channel shap representation on the performance of the National Water Model.

[X] LINE 97: Same issue on the "J. ;" citation as above

Resolved. Thank you!

[X] LINE 117: Missing a DOI on the Balckburn-Lynch, Agouridis, and Barton paper. Perhaps this one: https://doi.org/10.1111/1752-1688.12540

This has been added!

[X] LINE 120: Missing a DOI on the Blodgett, Johnson, & Bock 2023 EMS paper. Perhaps this one: https://doi.org/10.1016/j.envsoft.2023.105726

This has been added!

[X] LINE 131: DOI points to the wrong paper
[X] LINE 151: Missing DOI: maybe https://doi.org/10.5194/nhess-19-2405-2019

Fixed.

[X] LINE 170: GitHub should have a capital "H"

Fixed.

mikejohnson51 commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3133/pp252 is OK
- 10.1002/aaai.12035 is OK
- 10.1016/j.jhydrol.2018.07.020 is OK
- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.1111/1752-1688.12661 is OK
- 10.1111/1752-1688.12474 is OK
- 10.5194/nhess-19-2405-2019 is OK
- 10.1111/1752-1688.12540 is OK
- 10.20944/preprints202212.0390.v1 is OK
- 10.5194/hess-26-6121-2022 is OK
- 10.1016/j.envsoft.2020.104927 is OK
- 10.1016/j.envsoft.2023.105726 is OK
- 10.1029/2023JD038534 is OK
- 10.1016/j.jhydrol.2017.01.038 is OK
- 10.1111/jawr.12282 is OK
- 10.1111/1752-1688.12460 is OK
- 10.1002/env.2711 is OK
- 10.4211/technical.20171009 is OK
- 10.1111/1752-1688.13184 is OK
- 10.1002/2015WR017498 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric Reference an...
- No DOI given, and none found for title: mco: Multiple Criteria Optimization Algorithms and...
- No DOI given, and none found for title: Inundation Mapping
- No DOI given, and none found for title: The WRF-Hydro® modeling system technical descripti...
- No DOI given, and none found for title: Height Above Nearest Drainage (HAND) and Hydraulic...

INVALID DOIs

- None

crvernon commented 6 months ago

Thanks @mikejohnson51 this is looking good! I just see a few more things that need to be corrected before we move on to the next steps...

[ ] LINES 15 & 44: you stated the acronym for OLS in line 15 so no need to redefine in line 44
[ ] LINE 79: your link on "GitHub" points to a page not found
[ ] LINE 74: missing comma after "...Model (Johnson, Narock, et al., 2022) (2) help..." so it should be "...Model (Johnson, Narock, et al., 2022), (2) help..."
[ ] LINE 85: your link to "here" does not open for me
[ ] Figure 1 is listed in the paper but is not called out in the text or your code example at all. You can check out how these figure links are done in text, and in the image caption, in this recent paper published in JOSS: https://joss.theoj.org/papers/10.21105/joss.06298. Let me know if you have questions concerning this and I'll provide additional guidance.
[ ] LINES 127-128: "united states" is lower case in the reference, to maintain capitalization in the bib file, you can wrap the content you want to target in brackets. For example, "....{United States}..."
[ ] LINE 135: "united states" should be first letter capitalized

Thanks so much and great work!

mikejohnson51 commented 6 months ago

Thank you for the very careful review @crvernon! I have made the following changes to the paper and bib files.

[X] LINES 15 & 44: you stated the acronym for OLS in line 15 so no need to redefine in line 44

Removed in Line 44

[X] LINE 79: your link on "GitHub" points to a page not found

Fixed. Thank you!

[X] LINE 74: missing comma after "...Model (Johnson, Narock, et al., 2022) (2) help..." so it should be "...Model (Johnson, Narock, et al., 2022), (2) help..."

Added this comma and tweaked the third element to be more grammatically correct.

[X] LINE 85: your link to "here" does not open for me

Added the complete script URL opposed to the relative repo path. Thank you!. I will test this when the new version is rendered.

[X] Figure 1 is listed in the paper but is not called out in the text or your code example at all. You can check out how these figure links are done in text, and in the image caption, in this recent paper published in JOSS: https://joss.theoj.org/papers/10.21105/joss.06298. Let me know if you have questions concerning this and I'll provide additional guidance.

I added a call out to the figure in the sentence that now reads: The script to generate the plot found in Figure 1 can be found here...

[X] LINES 127-128: "united states" is lower case in the reference, to maintain capitalization in the bib file, you can wrap the content you want to target in brackets. For example, "....{United States}..."
[X] LINE 135: "united states" should be first letter capitalized

I wrapped all titles in {...} to ensure capitalization is retained throughout. Thank you for this tip!

mikejohnson51 commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikejohnson51 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3133/pp252 is OK
- 10.1002/aaai.12035 is OK
- 10.1016/j.jhydrol.2018.07.020 is OK
- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.1111/1752-1688.12661 is OK
- 10.1111/1752-1688.12474 is OK
- 10.5194/nhess-19-2405-2019 is OK
- 10.1111/1752-1688.12540 is OK
- 10.20944/preprints202212.0390.v1 is OK
- 10.5194/hess-26-6121-2022 is OK
- 10.1016/j.envsoft.2020.104927 is OK
- 10.1016/j.envsoft.2023.105726 is OK
- 10.1029/2023JD038534 is OK
- 10.1016/j.jhydrol.2017.01.038 is OK
- 10.1111/jawr.12282 is OK
- 10.1111/1752-1688.12460 is OK
- 10.1002/env.2711 is OK
- 10.4211/technical.20171009 is OK
- 10.1111/1752-1688.13184 is OK
- 10.1002/2015WR017498 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric Reference an...
- No DOI given, and none found for title: mco: Multiple Criteria Optimization Algorithms and...
- No DOI given, and none found for title: Inundation Mapping
- No DOI given, and none found for title: The WRF-Hydro® modeling system technical descripti...
- No DOI given, and none found for title: Height Above Nearest Drainage (HAND) and Hydraulic...
- No DOI given, and none found for title: Improved National-Scale Above-Normal Flow Predicti...

INVALID DOIs

- 129787b468aa4d55ace7b124ed27dbde is INVALID

mikejohnson51 commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikejohnson51 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3133/pp252 is OK
- 10.1002/aaai.12035 is OK
- 10.1016/j.jhydrol.2018.07.020 is OK
- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.1111/1752-1688.12661 is OK
- 10.1111/1752-1688.12474 is OK
- 10.5194/nhess-19-2405-2019 is OK
- 10.1111/1752-1688.12540 is OK
- 10.20944/preprints202212.0390.v1 is OK
- 10.5194/hess-26-6121-2022 is OK
- 10.1016/j.envsoft.2020.104927 is OK
- 10.1016/j.envsoft.2023.105726 is OK
- 10.1029/2023JD038534 is OK
- 10.1016/j.jhydrol.2017.01.038 is OK
- 10.1111/jawr.12282 is OK
- 10.1111/1752-1688.12460 is OK
- 10.1002/env.2711 is OK
- 10.4211/technical.20171009 is OK
- 10.1111/1752-1688.13184 is OK
- 10.1002/2015WR017498 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric Reference an...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric (Hydrofabric...
- No DOI given, and none found for title: mco: Multiple Criteria Optimization Algorithms and...
- No DOI given, and none found for title: Inundation Mapping
- No DOI given, and none found for title: The WRF-Hydro® modeling system technical descripti...
- No DOI given, and none found for title: Height Above Nearest Drainage (HAND) and Hydraulic...
- No DOI given, and none found for title: Improved National-Scale Above-Normal Flow Predicti...

INVALID DOIs

- None

mikejohnson51 commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikejohnson51 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3133/pp252 is OK
- 10.1002/aaai.12035 is OK
- 10.1016/j.jhydrol.2018.07.020 is OK
- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.1111/1752-1688.12661 is OK
- 10.1111/1752-1688.12474 is OK
- 10.5194/nhess-19-2405-2019 is OK
- 10.1111/1752-1688.12540 is OK
- 10.20944/preprints202212.0390.v1 is OK
- 10.5194/hess-26-6121-2022 is OK
- 10.1016/j.envsoft.2020.104927 is OK
- 10.1016/j.envsoft.2023.105726 is OK
- 10.1029/2023JD038534 is OK
- 10.1016/j.jhydrol.2017.01.038 is OK
- 10.1111/jawr.12282 is OK
- 10.1111/1752-1688.12460 is OK
- 10.1002/env.2711 is OK
- 10.4211/technical.20171009 is OK
- 10.1111/1752-1688.13184 is OK
- 10.1002/2015WR017498 is OK
- 10.1029/2023WR034557 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric Reference an...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric (Hydrofabric...
- No DOI given, and none found for title: mco: Multiple Criteria Optimization Algorithms and...
- No DOI given, and none found for title: Inundation Mapping
- No DOI given, and none found for title: The WRF-Hydro® modeling system technical descripti...
- No DOI given, and none found for title: Height Above Nearest Drainage (HAND) and Hydraulic...

INVALID DOIs

- None

crvernon commented 6 months ago

👋 @mikejohnson51 - Thanks for making the changes to the paper, it looks great! We are almost there! Next is just setting up the archive for your new release.

We want to make sure the archival has the correct metadata that JOSS requires. This includes a title that matches the paper title and a correct author list.

So here is what we have left to do:

[x] Conduct a GitHub release of the current reviewed version of the software and archive the reviewed software in Zenodo or a similar service (e.g., figshare, an institutional repository). Please ensure that the software archive in Zenodo uses the same license as the license you have posted on GitHub. If using Zendo, you can link your GitHub repository to it so when you conduct the release it will automatically mint an archive in Zenodo. Let me know if you have questions and I'll be happy to help.
[ ] Check the archival deposit (e.g., in Zenodo) to ensure it has the correct metadata. This includes the title (should match the paper title) and author list (make sure the list is correct and people who only made a small fix are not on it). You may also add the authors' ORCID.
[x] Please respond with the DOI of the archived version and the version number of the release here.

I can then move forward with accepting the submission.

mikejohnson51 commented 6 months ago

Hi @crvernon thanks for the very clear directions. I have uploaded a release artifact on Zenodo, using a MIT license and modified metadata. The DOI is: 10.5281/zenodo.10969037.

Please let me know what else is needed!

crvernon commented 6 months ago

@editorialbot set 0.2.0 as version

editorialbot commented 6 months ago

Done! version is now 0.2.0

crvernon commented 6 months ago

@editorialbot set 10.5281/zenodo.10969037 as archive

editorialbot commented 6 months ago

Done! archive is now 10.5281/zenodo.10969037

crvernon commented 6 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Double check authors and affiliations (including ORCIDs)
Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
Archive the release on Zenodo/figshare/etc and post the DOI here.
Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a pull request)
[x] Check that the archive title, author list, version tag, and the license are correct
[x] Set archive DOI with @editorialbot set <DOI here> as archive
[x] Set version with @editorialbot set <version here> as version
[x] Double check rendering of paper with @editorialbot generate pdf
[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed
[x] Recommend acceptance with @editorialbot recommend-accept

crvernon commented 6 months ago

Thanks @mikejohnson51! You missed one of your co-author's names in the Zenodo archive. No need to do an additional release, but could you please edit the metadata in your Zenodo record to show the same authors and author order as you have in your paper? Thanks!

mikejohnson51 commented 6 months ago

Thanks @crvernon. Sorry about that. I was confused by inclusion comment about code contributions. While Shahab was not able to contribute to the code directly, the work, ideas, and progression of the project could not have been done without him. I have added him to the Zenodo archive along with both authors ORCID.

crvernon commented 6 months ago

👋 @mikejohnson51 - I am recommending that this submission be accepted for publication. An EiC will review shortly and if all goes well this will go live soon! Thanks to @mabesa and @mengqi-z for a timely and constructive review! Congrats!

crvernon commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3133/pp252 is OK
- 10.1002/aaai.12035 is OK
- 10.1016/j.jhydrol.2018.07.020 is OK
- 10.5281/zenodo.7868764 is OK
- 10.5281/zenodo.2558565 is OK
- 10.1111/1752-1688.12661 is OK
- 10.1111/1752-1688.12474 is OK
- 10.5194/nhess-19-2405-2019 is OK
- 10.1111/1752-1688.12540 is OK
- 10.20944/preprints202212.0390.v1 is OK
- 10.5194/hess-26-6121-2022 is OK
- 10.1016/j.envsoft.2020.104927 is OK
- 10.1016/j.envsoft.2023.105726 is OK
- 10.1029/2023JD038534 is OK
- 10.1016/j.jhydrol.2017.01.038 is OK
- 10.1111/jawr.12282 is OK
- 10.1111/1752-1688.12460 is OK
- 10.1002/env.2711 is OK
- 10.4211/technical.20171009 is OK
- 10.1111/1752-1688.13184 is OK
- 10.1002/2015WR017498 is OK
- 10.1029/2023WR034557 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric Reference an...
- No DOI given, and none found for title: National Hydrologic Geospatial Fabric (Hydrofabric...
- No DOI given, and none found for title: mco: Multiple Criteria Optimization Algorithms and...
- No DOI given, and none found for title: Inundation Mapping
- No DOI given, and none found for title: The WRF-Hydro® modeling system technical descripti...
- No DOI given, and none found for title: Height Above Nearest Drainage (HAND) and Hydraulic...

INVALID DOIs

- None

editorialbot commented 6 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5242, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 6 months ago

Hi @mikejohnson51, I'll be taking over. Here is my to do list:

[x] Check that version was updated
[x] Check that software archive exists, has been input to JOSS, and title and author list look good
[x] Check paper

kthyng commented 6 months ago

Paper:

pg 2, paragraph 2: ... drainage area assumptions found in Bieger et al (2015), Bieger et al (2016), and Blackburn-Lynch et al (2017).
paragraph 3: interoperability is spelled wrong
Under 3. Add "They" in front of "Formalize in code". Then the reference "Dingman" should not be parenthetical

mikejohnson51 commented 6 months ago

Hello @kthyng, thanks for the review!

[X] I have changed the ; in pg 2, paragraph 2 to ,
[X] I have fixed the spelling of interoperability
[X] I have refined the 3rd item to read:

These functions formalize many of the concepts derived in Dingman and Afshari (2018) that relate AHG coefficients and exponents to cross-section hydraulics and geometry

kthyng commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 6 months ago

For the first bullet point I meant to change it to a proper sentence when changing the ";" to "," and add an "and" too as in (I can't copy paste so it's hard to write out...)

... Bieger, Bieger, and Blackburn-Lynch.

Otherwise keep it as ";" but have them be parenthetical and don't incorporate them into the sentence. Does that make sense?

mikejohnson51 commented 6 months ago

Good morning @kthyng! Yes this makes sense. The sentence now reads

For instance, the National Oceanic and Atmospheric Administration National Water Model (Cosgrove et al. 2024)
uses trapezoidal geometries (Gochis et al. 2020) that are in part derived from hydraulic geometry relationships
and drainage area assumptions found in Bieger et al. (2015), Bieger et al. (2016), and Blackburn-Lynch,
Agouridis, and Barton (2017).

mikejohnson51 commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

openjournals / joss-reviews

[REVIEW]: AHGestimation: An R package for Computing robust, mass preserving Hydraulic Geometries and Rating Curves #6145

Status

Reviewer instructions & questions

Checklists

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance