openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: NebulaSEM: A high-order discontinuous Galerkin spectral element code for atmospheric modeling #6180

Closed editorialbot closed 8 months ago

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@dshawul<!--end-author-handle-- (Daniel Abdi) Repository: https://github.com/dshawul/NebulaSEM Branch with paper.md (empty if default branch): master Version: 1.0 Editor: !--editor-->@observingClouds<!--end-editor-- Reviewers: @capitalaslash, @esclapez Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b89b0f085fc62dd87d6797ded45e4a32"><img src="https://joss.theoj.org/papers/b89b0f085fc62dd87d6797ded45e4a32/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b89b0f085fc62dd87d6797ded45e4a32/status.svg)](https://joss.theoj.org/papers/b89b0f085fc62dd87d6797ded45e4a32)

Author instructions

Thanks for submitting your paper to JOSS @dshawul. Currently, there isn't a JOSS editor assigned to your paper.

@dshawul if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 10 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 10 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (1079.9 files/s, 176953.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             32            680           1203           6804
C/C++ Header                    23            548            582           5165
Markdown                         7            111              0            473
CMake                           31             34             82            377
Bourne Shell                     3             20             12            123
TeX                              1              5              0             97
YAML                             3             10              4             56
-------------------------------------------------------------------------------
SUM:                           100           1408           1883          13095
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 10 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.advengsoft.2014.05.002 is OK
- 10.2514/3.8290 is OK
- 10.1137/100791634 is OK
- 10.1175/1520-0493(1963)091<0099:GCEWTP>2.3.CO;2 is OK
- 10.7551/mitpress/3014.001.0001 is OK
- 10.1177/1094342017694427 is OK
- 10.1155/2015/295393 is OK

MISSING DOIs

- 10.1088/0031-9112/29/6/037 may be a valid DOI for title: Atmospheric Science: An Introductory Survey

INVALID DOIs

- https://doi.org/10.1175/1520-0469(1993)050<1865:BCEWAS>2.0.CO;2 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 10 months ago

Wordcount for paper.md is 1173

editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 10 months ago

Five most similar historical JOSS papers:

emg3d: A multigrid solver for 3D electromagnetic diffusion Submitting author: @prisae Handling editor: @jedbrown (Active) Reviewers: @akelbert, @emersodb, @lukeolson Similarity score: 0.8259

libCEED: Fast algebra for high-order element-based discretizations Submitting author: @jedbrown Handling editor: @diehlpk (Active) Reviewers: @thelfer, @FreddieWitherden, Similarity score: 0.8238

AtomNeb: IDL Library for Atomic Data of Ionized Nebulae Submitting author: @danehkar Handling editor: @arfon (Active) Reviewers: @mgalloy, @mdpiper Similarity score: 0.8220

SARAS: A general-purpose PDE solver for fluid dynamics Submitting author: @roshansamuel Handling editor: @kyleniemeyer (Active) Reviewers: @dlagrava, @olgadoronina, @nickwimer Similarity score: 0.8214

PetIBM: toolbox and applications of the immersed-boundary method on distributed-memory architectures Submitting author: @labarba Handling editor: @kyleniemeyer (Active) Reviewers: @jedbrown Similarity score: 0.8179

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 10 months ago

Hi @dshawul and thanks for your submission! Please take a look at the notes about for DOIs. Also do you have any hosted docs to check out?

dshawul commented 10 months ago

Hi @kthyng Thank you for starting the review process! I believe that I have now fixed the DOI issue by removing the prefix. Regarding potential editors, one of the editors you mentioned above "kyleniemeyer" seems to be a very good fit for this work. Edit: I have added a link to the github hosted API documentation in the README of the repository. The link is here: https://dshawul.github.io/html/index.html Thank you

kthyng commented 10 months ago

@dshawul Ok great on the docs! Unfortunately we have a backlog of submissions right now so I will add this to it now. In the meantime please check out the reviewers database and list 5 reviewers that you think are relevant for this work, or from your extended (non-conflicted) network. Please don't use "@" so as to avoid pinging people prematurely. Thanks.

dshawul commented 10 months ago

@kthyng My apologies, I misread the suggestion to be for editors not reviewers. Anyway, here are potential reviewers that I think are a good fit. I have removed "@" from their user names

highlando
JaroslavHron
ctdegroot
zbeekman
capitalaslash
esclapez
kathlandgren
roshansamuel
kthyng commented 10 months ago

@observingClouds Could you edit this submission?

kthyng commented 10 months ago

@editorialbot invite @observingClouds as editor

editorialbot commented 10 months ago

Invitation to edit this submission sent!

observingClouds commented 10 months ago

@editorialbot assign me as editor

editorialbot commented 10 months ago

Assigned! @observingClouds is now the editor

observingClouds commented 10 months ago

Hi @dshawul, Thank you for your submission. I'll be the editor for this submission and will now look for reviewers in the next couple of days. Thank you very much for your suggestions. As soon as I have found 2-3 reviewers we will start the review process. If you have any questions in the meantime, feel free to write a comment and mention me (@observingClouds).

dshawul commented 9 months ago

Hi @observingClouds, Any luck finding reviewers? I can try to find more active reviewers from the list of JOSS reviewers if that helps. Thank you.

observingClouds commented 9 months ago

Thanks for offering your help @dshawul. I'm positive to find reviewers within the next weeks.

observingClouds commented 9 months ago

@editorialbot add @capitalaslash as reviewer

editorialbot commented 9 months ago

@capitalaslash added to the reviewers list!

observingClouds commented 8 months ago

@editorialbot add @esclapez as reviewer

editorialbot commented 8 months ago

@esclapez added to the reviewers list!

observingClouds commented 8 months ago

@editorialbot start review

editorialbot commented 8 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6448.