[REVIEW]: Pywaterflood: Well connectivity analysis through capacitance-resistance modeling

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@frank1010111@elbeejay<!--end-editor-- Reviewers: @mgcooper, @amandersillinois Archive: 10.5281/zenodo.10815882

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2fdffa96e936553d289e622e5e12388c"><img src="https://joss.theoj.org/papers/2fdffa96e936553d289e622e5e12388c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2fdffa96e936553d289e622e5e12388c/status.svg)](https://joss.theoj.org/papers/2fdffa96e936553d289e622e5e12388c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mgcooper & @amandersillinois, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @elbeejay know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @amandersillinois

📝 Checklist for @mgcooper

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2118/83381-PA is OK
- 10.3390/en11123368 is OK
- 10.1016/j.petrol.2010.05.006 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1016/j.egypro.2013.06.290 is OK
- 10.2118/51793-PA is OK
- 10.2118/95322-PA is OK

MISSING DOIs

- No DOI given, and none found for title: Optimization of reinjection allocation in geotherm...
- No DOI given, and none found for title: Development and application of capacitance-resisti...

INVALID DOIs

- None

editorialbot commented 6 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5131, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 6 months ago

[x] Check that version was updated
[x] Check that software archive exists, has been input to JOSS, and title and author list look good
[x] Check paper

kthyng commented 6 months ago

Hi @frank1010111. Please make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.

frank1010111 commented 6 months ago

Hi @kthyng, I've updated the archive to match title and author (and ORCID) to the JOSS paper.

kthyng commented 6 months ago

Paper comments:

first paragraph line 4: "based on another's" -> either "based on another" or "based on another's behavior"
first paragraph line 7: "They are so-called" -> Something like "Their name refers to the fact that the equations describing well..." or something else.
2nd paragraph: "... to each producer has the same time constant ..." the phrases in the sentence switch in a way that is not grammatically consistent

frank1010111 commented 6 months ago

Thank you for your edits. I have made the changes in this commit: https://github.com/frank1010111/pywaterflood/commit/4e9d0a8d9aa0ed345628795d9d06525b8c5da04f

kthyng commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 6 months ago

Ok looks good so we are ready to go.

kthyng commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Male given-names: Frank orcid: "https://orcid.org/0000-0002-3402-5578" contact: - family-names: Male given-names: Frank orcid: "https://orcid.org/0000-0002-3402-5578" doi: 10.5281/zenodo.10815882 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Male given-names: Frank orcid: "https://orcid.org/0000-0002-3402-5578" date-published: 2024-03-20 doi: 10.21105/joss.06191 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 6191 title: "Pywaterflood: Well connectivity analysis through capacitance-resistance modeling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06191" volume: 9 title: "Pywaterflood: Well connectivity analysis through capacitance-resistance modeling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 6 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5154
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06191
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 6 months ago

Congrats on your new publication @frank1010111! Many thanks to editor @elbeejay and reviewers @mgcooper and @amandersillinois for your time, hard work, and expertise!!

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06191/status.svg)](https://doi.org/10.21105/joss.06191)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06191">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06191/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06191/status.svg
   :target: https://doi.org/10.21105/joss.06191

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kthyng commented 6 months ago

@frank1010111 If you're interested in participating in the future as a reviewer, please sign up at https://reviewers.joss.theoj.org/!

frank1010111 commented 6 months ago

Thanks everyone! I really love how JOSS does these reviews, and I've signed up to be a reviewer myself to help this great community.

openjournals / joss-reviews