Closed editorialbot closed 5 months ago
@ivastar @evamariaa, yes, I can fix this issue. This turned out to be a bug in the code that prevented animations from working. I am releasing a new version in a few minutes and I will update all notebooks in the folder to use the latest version of spelunker
.
@ivastar @evamariaa , Okay, I have updated the notebooks!
@ivastar I have updated spelunker to 1.1.17! Is there a way to update the JOSS submission to have the latest version as well?
@GalagaBits I will set the final version before publications. But before we get there I have some editorial comments for the manuscript. Please let me know if you have any questions. Ping me when the changes have been done and we will proceed with the post-review checklist.
Overall comments:
datamodels
library) I think should all be written as separate phrases (including in the title). Happy to be corrected if the JWST documentation for example consistently uses a different style but a brief look through the internet suggests separate words. jwstuser
library. " Or maybe @nespinoza can push that to pypi....Smaller comments:
@ivastar Sorry for the long reply! I just graduated! finished responding to all of the comments above in the latest commit.
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1088/1538-3873/acd1b5 is OK
- 10.1117/12.926578 is OK
- 10.1117/12.2311973 is OK
- 10.1086/160554 is OK
- 10.1007/BF00648343 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@editorialbot set <DOI here> as archive
@editorialbot set <version here> as version
@editorialbot generate pdf
@editorialbot check references
and ask author(s) to update as needed@editorialbot recommend-accept
I just made another commit to the paper
How do I archive the release on Zenodo?
@ivastar Okay! I finished the additional author tasks!
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot set 10.5281/zenodo.11115733 as archive
Done! archive is now 10.5281/zenodo.11115733
@editorialbot set v.1.1.17 as version
Done! version is now v.1.1.17
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1088/1538-3873/acd1b5 is OK
- 10.1117/12.926578 is OK
- 10.1117/12.2311973 is OK
- 10.1086/160554 is OK
- 10.1007/BF00648343 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1088/1538-3873/acd1b5 is OK
- 10.1117/12.926578 is OK
- 10.1117/12.2311973 is OK
- 10.1086/160554 is OK
- 10.1007/BF00648343 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.
Check final proof :point_right::page_facing_up: Download article
If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5308, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept
@GalagaBits and @nespinoza, congratulations on the publication of this paper! @evamariaa, @taylorbell57 thank you for your detailed review! Thank you all for the dedicated work on this paper and quick turnaround of all comments and revisions.
Thank you all for reviewing our paper!! @ivastar, I noticed a small typo in line 53. I updated the paper again, is there a way to update the final paper where I did not format mnemonics
correctly. Is there a way we can update the final paper again? I made the paper change to GitHub again.
@dfm can look at this again when he does the actual publication.
@ivastar That sounds great! So now I have to wait on @dfm to publish to JOSS?
Yes, I recommended publication as the editor for this submission, @dfm is the editor in chief for the AASS track and he does the honors for the final publication.
I've opened another small PR with some last edits before publication, and after merging that, the other changes will also be incorporated!
@dfm Okay! I have merged the pull request!!
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1088/1538-3873/acd1b5 is OK
- 10.1117/12.926578 is OK
- 10.1117/12.2311973 is OK
- 10.1086/160554 is OK
- 10.1007/BF00648343 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.
Check final proof :point_right::page_facing_up: Download article
If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5329, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept
@editorialbot accept
Doing it live! Attempting automated processing of paper acceptance...
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.
If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.
You can copy the contents for your CITATION.cff file here:
``` cff-version: "1.2.0" authors: - family-names: Deal given-names: Derod orcid: "https://orcid.org/0009-0006-6758-4751" - family-names: Espinoza given-names: NΓ©stor orcid: "https://orcid.org/0000-0001-9513-1449" doi: 10.5281/zenodo.11115733 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Deal given-names: Derod orcid: "https://orcid.org/0009-0006-6758-4751" - family-names: Espinoza given-names: NΓ©stor orcid: "https://orcid.org/0000-0001-9513-1449" date-published: 2024-05-08 doi: 10.21105/joss.06202 issn: 2475-9066 issue: 97 journal: Journal of Open Source Software publisher: name: Open Journals start: 6202 title: "Spelunker: A quick-look Python pipeline for JWST NIRISS FGS Guide Star Data" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06202" volume: 9 title: "Spelunker: A quick-look Python pipeline for JWST NIRISS FGS Guide Star Data" ```
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.
πππ π Toot for this paper π πππ
π¨π¨π¨ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! π¨π¨π¨
Here's what you must now do:
Any issues? Notify your editorial technical team...
Many thanks to @evamariaa and @taylorbell57 for reviewing and to @ivastar for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!
@GalagaBits β Your paper is now accepted and published in JOSS! :zap::rocket::boom:
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06202/status.svg)](https://doi.org/10.21105/joss.06202)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06202">
<img src="https://joss.theoj.org/papers/10.21105/joss.06202/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06202/status.svg
:target: https://doi.org/10.21105/joss.06202
This is how it will look in your documentation:
We need your help!
The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
@editorialbot generate preprint
:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:
Submitting author: !--author-handle-->@GalagaBits<!--end-author-handle-- (Derod Deal) Repository: https://github.com/GalagaBits/JWST-FGS-Spelunker Branch with paper.md (empty if default branch): Version: v.1.1.17 Editor: !--editor-->@ivastar<!--end-editor-- Reviewers: @evamariaa, @taylorbell57 Archive: 10.5281/zenodo.11115733
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@evamariaa & @taylorbell57, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.
β¨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest β¨
Checklists
π Checklist for @evamariaa
π Checklist for @taylorbell57