openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: pySLM2: A full-stack python package for holographic beam shaping #6205

Closed editorialbot closed 8 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@ldes89150<!--end-author-handle-- (Chung-You Shih) Repository: https://github.com/QITI/pySLM2 Branch with paper.md (empty if default branch): paper Version: v0.1.0 Editor: !--editor-->@HaoZeke<!--end-editor-- Reviewers: @brandondube, @sidihamady, @ktahar Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/70246ad674d3806798e343f6ecffa686"><img src="https://joss.theoj.org/papers/70246ad674d3806798e343f6ecffa686/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/70246ad674d3806798e343f6ecffa686/status.svg)](https://joss.theoj.org/papers/70246ad674d3806798e343f6ecffa686)

Author instructions

Thanks for submitting your paper to JOSS @ldes89150. Currently, there isn't a JOSS editor assigned to your paper.

@ldes89150 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
HaoZeke commented 8 months ago

Sorry @sidihamady, I need to wait for @ldes89150 to confirm the [not-reviewed] label for the hardware section before I can start this one.

The checklist can be generated after that, in the [REVIEW] thread.

ldes89150 commented 8 months ago

@editorialbot commands

editorialbot commented 8 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

ldes89150 commented 8 months ago

@editorialbot commands

editorialbot commented 8 months ago

Hello @ldes89150, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
ldes89150 commented 8 months ago

@editorialbot generate my checklist

editorialbot commented 8 months ago

Checklists can only be created once the review has started in the review issue

ldes89150 commented 8 months ago

@HaoZeke What exactly do I need to do? I confirm no review for the hardware section (pySLM2/utils).

ldes89150 commented 8 months ago

I added it to the paper. Let me know if there is still something I need to do. https://github.com/QITI/pySLM2/blob/paper/paper.md#hardware-controls-not-reviewed

Thanks!

ldes89150 commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

SkyPy: A package for modelling the Universe Submitting author: @rrjbca Handling editor: @arfon (Active) Reviewers: @cescalara, @rmorgan10 Similarity score: 0.8171

PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry Submitting author: @piotrbartman Handling editor: @dhhagan (Active) Reviewers: @darothen, @josephhardinee Similarity score: 0.8155

beamshapes: a Python package to generate directivity patterns for various sound source models Submitting author: @thejasvibr Handling editor: @faroit (Active) Reviewers: @nils-werner, @hagenw Similarity score: 0.8144

prysm: A Python optics module Submitting author: @brandondube Handling editor: @xuanxu (Active) Reviewers: @aquilesC Similarity score: 0.8119

PiSCAT: A Python Package for Interferometric Scattering Microscopy Submitting author: @po60nani Handling editor: @emdupre (Active) Reviewers: @ziatdinovmax, @aquilesC Similarity score: 0.8100

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

SkyPy: A package for modelling the Universe Submitting author: @rrjbca Handling editor: @arfon (Active) Reviewers: @cescalara, @rmorgan10 Similarity score: 0.8171

PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry Submitting author: @piotrbartman Handling editor: @dhhagan (Active) Reviewers: @darothen, @josephhardinee Similarity score: 0.8155

beamshapes: a Python package to generate directivity patterns for various sound source models Submitting author: @thejasvibr Handling editor: @faroit (Active) Reviewers: @nils-werner, @hagenw Similarity score: 0.8144

prysm: A Python optics module Submitting author: @brandondube Handling editor: @xuanxu (Active) Reviewers: @aquilesC Similarity score: 0.8119

PiSCAT: A Python Package for Interferometric Scattering Microscopy Submitting author: @po60nani Handling editor: @emdupre (Active) Reviewers: @ziatdinovmax, @aquilesC Similarity score: 0.8100

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

ktahar commented 8 months ago

I could review this paper but the situation is the same as the other reviewers; I don't have the hardware. (This reply might be too late, sorry.)

HaoZeke commented 8 months ago

@editorialbot add @ktahar as reviewer

I could review this paper but the situation is the same as the other reviewers; I don't have the hardware.

That's alright, thanks for accepting the request to review.

editorialbot commented 8 months ago

@ktahar added to the reviewers list!

HaoZeke commented 8 months ago

@editorialbot start review

@ldes89150 thanks for the quick turn-around. We can now proceed with the review.

editorialbot commented 8 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6315.