[REVIEW]: SelfEEG: A Python library for Self-Supervised Learning in Electroencephalography

editorialbot commented 10 months ago

Submitting author: !--author-handle-->@fedepup@emdupre<!--end-editor-- Reviewers: @vferat, @wmvanvliet Archive: 10.5281/zenodo.10813095

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ab7eaf53973996e7c8d49dada734de78"><img src="https://joss.theoj.org/papers/ab7eaf53973996e7c8d49dada734de78/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ab7eaf53973996e7c8d49dada734de78/status.svg)](https://joss.theoj.org/papers/ab7eaf53973996e7c8d49dada734de78)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@vferat & @wmvanvliet & @Bsingstad, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @wmvanvliet

📝 Checklist for @Bsingstad

📝 Checklist for @vferat

emdupre commented 8 months ago

@editorialbot set v0.1.1 as version

editorialbot commented 8 months ago

Done! version is now v0.1.1

emdupre commented 8 months ago

Thank you, @fedepup !

As you can see, I'm having a little difficulty setting the archive with a non-valid DOI. I hope / expect that this will be resolved soon on the DataCite side, but in the meantime I'll try to confirm what we can do on our end.

fedepup commented 8 months ago

Hi @emdupre. The SelEEG v0.1.1 DOI on Zenodo now works.

Il Gio 14 Mar 2024, 06:02 Elizabeth DuPre @.***> ha scritto:

Thank you, @fedepup https://github.com/fedepup !

As you can see, I'm having a little difficulty setting the archive with a non-valid DOI. I hope / expect that this will be resolved soon on the DataCite side, but in the meantime I'll try to confirm what we can do on our end.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6224#issuecomment-1996488233, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4NECZKR5TDDIAE6E2QJUSDYYEVPTAVCNFSM6AAAAABBYYQR7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWGQ4DQMRTGM . You are receiving this because you were mentioned. Message ID: @.***>

emdupre commented 8 months ago

@editorialbot set 10.5281/zenodo.10813095 as archive

editorialbot commented 8 months ago

Done! archive is now 10.5281/zenodo.10813095

emdupre commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

emdupre commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 8 months ago

@editorialbot check references

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
- 10.1016/j.eswa.2024.123550 is OK

MISSING DOIs

- No DOI given, and none found for title: Lightly
- No DOI given, and none found for title: VISSL

INVALID DOIs

- None

emdupre commented 8 months ago

Thank you, @fedepup ! I'm now happy to recommend SelfEEG to the EiC team for publication in JOSS ✨🚀 And my personal congratulations on this impressive work !

Thank you, too, to @wmvanvliet and @vferat for your reviews ! JOSS works because of your work 💐

emdupre commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
- 10.1016/j.eswa.2024.123550 is OK

MISSING DOIs

- No DOI given, and none found for title: Lightly
- No DOI given, and none found for title: VISSL

INVALID DOIs

- None

editorialbot commented 8 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5134, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 7 months ago

@editorialbot accept

editorialbot commented 7 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 7 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Del Pup given-names: Federico orcid: "https://orcid.org/0009-0004-0698-962X" - family-names: Zanola given-names: Andrea orcid: "https://orcid.org/0000-0001-6973-8634" - family-names: Tshimanga given-names: Louis Fabrice orcid: "https://orcid.org/0009-0002-1240-4830" - family-names: Mazzon given-names: Paolo Emilio - family-names: Atzori given-names: Manfredo orcid: "https://orcid.org/0000-0001-5397-2063" doi: 10.5281/zenodo.10813095 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Del Pup given-names: Federico orcid: "https://orcid.org/0009-0004-0698-962X" - family-names: Zanola given-names: Andrea orcid: "https://orcid.org/0000-0001-6973-8634" - family-names: Tshimanga given-names: Louis Fabrice orcid: "https://orcid.org/0009-0002-1240-4830" - family-names: Mazzon given-names: Paolo Emilio - family-names: Atzori given-names: Manfredo orcid: "https://orcid.org/0000-0001-5397-2063" date-published: 2024-03-17 doi: 10.21105/joss.06224 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 6224 title: "SelfEEG: A Python library for Self-Supervised Learning in Electroencephalography" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06224" volume: 9 title: "SelfEEG: A Python library for Self-Supervised Learning in Electroencephalography" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 7 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 7 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5140
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06224
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 7 months ago

@vferat, @wmvanvliet – many thanks for your reviews here and to @emdupre for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@fedepup – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 7 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06224/status.svg)](https://doi.org/10.21105/joss.06224)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06224">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06224/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06224/status.svg
   :target: https://doi.org/10.21105/joss.06224

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews