search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: EllipticForest: A Direct Solver Library for Elliptic Partial Differential Equations on Adaptive Meshes #6278

Closed editorialbot closed 9 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@DamynChipman<!--end-author-handle-- (Damyn Chipman) Repository: https://github.com/DamynChipman/EllipticForest Branch with paper.md (empty if default branch): v1-joss-paper Version: v1.0.1 Editor: !--editor-->@vissarion<!--end-editor-- Reviewers: @sandeshkatakam, @lukeolson Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/99b10d1d1b714cdccf6306eb6edfad2c"><img src="https://joss.theoj.org/papers/99b10d1d1b714cdccf6306eb6edfad2c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/99b10d1d1b714cdccf6306eb6edfad2c/status.svg)](https://joss.theoj.org/papers/99b10d1d1b714cdccf6306eb6edfad2c)

Author instructions

Thanks for submitting your paper to JOSS @DamynChipman. Currently, there isn't a JOSS editor assigned to your paper.

@DamynChipman if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (1508.2 files/s, 217777.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             60           1359           1322           5013
C/C++ Header                    31           1264           3496           3642
Markdown                        12            236              0            622
CMake                           13             72             31            316
TeX                              1             16              0            106
YAML                             2              1             12             69
Bourne Shell                     2              6              7             18
INI                              1              0              0              8
-------------------------------------------------------------------------------
SUM:                           122           2954           4868           9794
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 1784

editorialbot commented 9 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1137/130918988 may be a valid DOI for title: A direct solver with O(N) complexity for variable coefficient elliptic PDEs discretized via a high-order composite spectral collocation method
- 10.1016/b978-012387582-2/50038-1 may be a valid DOI for title: ParaView: An End-User Tool for Large Data Visualization
- 10.1007/978-94-009-1908-2_14 may be a valid DOI for title: Theory and application of Steklov-Poincaré operators for boundary-value problems

INVALID DOIs

- None
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

AMReX: a framework for block-structured adaptive mesh refinement Submitting author: @asalmgren Handling editor: @kyleniemeyer (Active) Reviewers: @MatthewTurk, @RemiLehe, @cmsquared Similarity score: 0.8010

PDLSM-FEM: Solver of Coupled Peridynamics Least Squares Minimization with Finite Element Method Submitting author: @QibangLiu Handling editor: @prashjha (Active) Reviewers: @TLCFEM, @karthikncsu, @Balaje Similarity score: 0.8007

FEM_2D: A Rust Package for 2D Finite Element Method Computations with Extensive Support for hp-refinement Submitting author: @jeremiah-corrado Handling editor: @jedbrown (Active) Reviewers: @jeremylt, @YohannDudouit Similarity score: 0.7988

MoFEM: An open source, parallel finite element library Submitting author: @likask Handling editor: @jedbrown (Active) Reviewers: @tjhei, @chrisrichardson, @Kevin-Mattheus-Moerman, @vijaysm, @chennachaos Similarity score: 0.7986

SARAS: A general-purpose PDE solver for fluid dynamics Submitting author: @roshansamuel Handling editor: @kyleniemeyer (Active) Reviewers: @dlagrava, @olgadoronina, @nickwimer Similarity score: 0.7980

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 9 months ago

👋 @DamynChipman - thanks for your submission. While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 9 months ago

👋 @vissarion - would you be able to edit this submission?

danielskatz commented 9 months ago

@editorialbot invite @vissarion as editor

editorialbot commented 9 months ago

Invitation to edit this submission sent!

DamynChipman commented 9 months ago

@editorialbot check references

editorialbot commented 9 months ago

Checking the BibTeX entries failed with the following error: 

Failed to parse BibTeX on value "doi" (NAME) [#<BibTeX::Bibliography data=[11]>, "@", #<BibTeX::Entry >, {:author=>["Quarteroni, A and Valli, A"], :booktitle=>["Applied and Industrial Mathematics"], :pages=>["179--203"], :publisher=>["Springer"], :title=>["Theory and application of Steklov-Poincar{\\'e} operators for boundary-value problems"], :year=>["1991"]}]
DamynChipman commented 9 months ago

@editorialbot check references

editorialbot commented 9 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/130918988 is OK
- 10.1016/b978-012387582-2/50038-1 is OK
- 10.1007/978-94-009-1908-2_14 is OK

MISSING DOIs

- None

INVALID DOIs

- None
DamynChipman commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 9 months ago

Five most similar historical JOSS papers:

AMReX: a framework for block-structured adaptive mesh refinement Submitting author: @asalmgren Handling editor: @kyleniemeyer (Active) Reviewers: @MatthewTurk, @RemiLehe, @cmsquared Similarity score: 0.8010

PDLSM-FEM: Solver of Coupled Peridynamics Least Squares Minimization with Finite Element Method Submitting author: @QibangLiu Handling editor: @prashjha (Active) Reviewers: @TLCFEM, @karthikncsu, @Balaje Similarity score: 0.8007

FEM_2D: A Rust Package for 2D Finite Element Method Computations with Extensive Support for hp-refinement Submitting author: @jeremiah-corrado Handling editor: @jedbrown (Active) Reviewers: @jeremylt, @YohannDudouit Similarity score: 0.7988

MoFEM: An open source, parallel finite element library Submitting author: @likask Handling editor: @jedbrown (Active) Reviewers: @tjhei, @chrisrichardson, @Kevin-Mattheus-Moerman, @vijaysm, @chennachaos Similarity score: 0.7986

SARAS: A general-purpose PDE solver for fluid dynamics Submitting author: @roshansamuel Handling editor: @kyleniemeyer (Active) Reviewers: @dlagrava, @olgadoronina, @nickwimer Similarity score: 0.7980

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

vissarion commented 9 months ago

@editorialbot assign me as editor

editorialbot commented 9 months ago

Assigned! @vissarion is now the editor

vissarion commented 9 months ago

:wave: @asalmgren, @QibangLiu, @jeremiah-corrado, @likask, @roshansamuel would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

vissarion commented 9 months ago

Hi @josemanuel22, @sandeshkatakam, @lukeolson, @kris-rowe and @chaypaterson

Would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

sandeshkatakam commented 9 months ago

Hi @josemanuel22, @sandeshkatakam, @lukeolson, @kris-rowe and @chaypaterson

Would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Yes, I can do this review

vissarion commented 9 months ago

Thanks @sandeshkatakam !

@editorialbot add @sandeshkatakam as reviewer

vissarion commented 9 months ago

@editorialbot add @sandeshkatakam as reviewer

editorialbot commented 9 months ago

@sandeshkatakam added to the reviewers list!

DamynChipman commented 9 months ago

@vissarion Just following up here... Would it be beneficial to re-ping potential reviewers? How many are required/recommended for a review?

vissarion commented 9 months ago

@DamynChipman thanks for the heads up! I would like to have at least 2 reviewers. Therefore, I will ping some more experts in differential equations and C++. If you know reviewers that you can recommend please share them in this thread (please do not ping them with "@" just mention their github id if you know it).

vissarion commented 9 months ago

Hi @mbudisic, @slayoo, @dawbarton, @Jgoldfar and @arghdos.

Would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

slayoo commented 9 months ago

Thanks for reaching out, but I've just agreed to review another paper for JOSS a few days ago.

chaypaterson commented 9 months ago

How long is the article?

Chay

On Thu, 8 Feb 2024, 10:11 am Vissarion Fisikopoulos, < @.***> wrote:

Hi @mbudisic https://github.com/mbudisic, @slayoo https://github.com/slayoo, @dawbarton https://github.com/dawbarton, @jgoldfar https://github.com/jgoldfar and @arghdos.

Would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6278#issuecomment-1933750716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4O2QDEGJCZLNZJRLPARMTYSSQEJAVCNFSM6AAAAABCJEITI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTG42TANZRGY . You are receiving this because you were mentioned.Message ID: @.***>

vissarion commented 9 months ago

@chaypaterson thanks for your reply. The paper it is 6 pages long (you can find the pdf in the current thread) but a JOSS reviewer is expected to also review other aspects of the software package such as documentation and functionality see https://joss.readthedocs.io/en/latest/review_criteria.html for more details.

lukeolson commented 9 months ago

Hi @josemanuel22, @sandeshkatakam, @lukeolson, @kris-rowe and @chaypaterson

Would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I can do a review if you need another reviewer.

vissarion commented 9 months ago

@editorialbot add @lukeolson as reviewer

editorialbot commented 9 months ago

@lukeolson added to the reviewers list!

vissarion commented 9 months ago

@DamynChipman with the two assigned reviewers @sandeshkatakam and @lukeolson we can move forward to the review (this will be in a new thread)

@sandeshkatakam, @lukeolson thanks for your willingness to review for JOSS!

vissarion commented 9 months ago

@editorialbot start review

editorialbot commented 9 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6339.

DamynChipman commented 9 months ago

Awesome, thank you @sandeshkatakam and @lukeolson!